Repository navigation
Emoji Suggestions Adjustments + Remove Duplicates - #26507
Conversation
Reviewer Checklist
Screenshots/VideosWebchrome-desktop-2023-09-05_14.26.29.mp4Mobile Web - Chromeandroid-chrome-2023-09-05_14.59.22.mp4Mobile Web - Safariios-safari-2023-09-05_14.31.10.mp4Desktopmac-desktop-2023-09-05_14.22.12.mp4iOSios-native-2023-09-05_14.11.28.mp4Androidandroid-native-2023-09-05_15.15.33.mp4 |
|
@jjcoffee Got it, refactored names to be more clear. I changed them based on your last comment on the issue post before my PR 😄 |
jjcoffee
left a comment
There was a problem hiding this comment.
Just a few minor comments to resolve, otherwise great work! 😄
|
Thank you for the review @jjcoffee 🙏 Updated code! |
johnmlee101
left a comment
There was a problem hiding this comment.
Tested. Seems to be working well!
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/johnmlee101 in version: 1.3.67-0 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.67-3 🚀
|
|
🚀 Deployed to staging by https://github.com/johnmlee101 in version: 1.3.68-0 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.68-17 🚀
|
Details
When the user had selected Spanish as the preferred language, he was able to look for English names of the emojis as well as Spanish, but there were duplicate occurrences in many scenarios, the most obvious one being
:bomb:and:bomba:, same emoji, one after the other in suggestions.In this PR, the user will still be able to search using the English emojis, but the suggestions will only show the Spanish ones.
Fixed Issues
$ #25735
PROPOSAL: #25735 (comment)
Tests
:bomb:fire:Offline tests
:bomb:fire:QA Steps
:bomb:fire:PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Screen.Recording.2023-09-01.at.7.29.14.PM.mov
Mobile Web - Chrome
Screen.Recording.2023-09-01.at.8.05.08.PM.mov
Mobile Web - Safari
Screen.Recording.2023-09-01.at.7.50.32.PM.mov
Desktop
Screen.Recording.2023-09-01.at.7.53.54.PM.mov
iOS
Screen.Recording.2023-09-01.at.7.46.06.PM.mov
Android
Screen.Recording.2023-09-01.at.8.05.08.PM.mov