Repository navigation
Conversation
Contributor
Reviewer Checklist
Screenshots/VideosWebMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #24810 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
fabioh8010
reviewed
Sep 11, 2023
| * @returns {String} string representation of a randomly generated 64 bit signed integer | ||
| */ | ||
| function rand64() { | ||
| function rand64(): string { |
Contributor
There was a problem hiding this comment.
Suggested change
| function rand64(): string { | |
| /** | |
| * Generates a random positive 64 bit numeric string by randomly generating the left, middle, and right parts and concatenating them. Used to generate client-side ids. | |
| * @returns string representation of a randomly generated 64 bit signed integer | |
| */ | |
| function rand64(): string { |
We should keep the @returns description.
| * @returns {Number} random integer between a and b | ||
| */ | ||
| function generateRandomInt(a, b) { | ||
| function generateRandomInt(a: number, b: number): number { |
Contributor
There was a problem hiding this comment.
Suggested change
| function generateRandomInt(a: number, b: number): number { | |
| /** | |
| * Generates a random integer between a and b | |
| * It's and equivalent of _.random(a, b) | |
| * | |
| * @returns random integer between a and b | |
| */ | |
| function generateRandomInt(a: number, b: number): number { |
fabioh8010
approved these changes
Sep 11, 2023
fabioh8010
left a comment
Contributor
There was a problem hiding this comment.
LGTM, CK still need to do the checklist.
Contributor
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-09-12.at.00.14.52.movScreen.Recording.2023-09-12.at.00.15.17.movDesktopScreen.Recording.2023-09-12.at.00.16.02.movMobile Web - ChromeScreen.Recording.2023-09-12.at.00.16.30.movAndroidScreen.Recording.2023-09-12.at.00.17.17.movMobile Web - SafariScreen.Recording.2023-09-12.at.00.18.36.moviOSScreen.Recording.2023-09-12.at.00.19.15.mov |
fabioh8010
approved these changes
Sep 11, 2023
MariaHCD
approved these changes
Sep 12, 2023
Contributor
|
🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.68-4 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.68-17 🚀
|
Contributor
|
🚀 Deployed to staging by https://github.com/MariaHCD in version: 1.3.70-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.70-8 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Migrate 'NumberUtils.js' lib file to TypeScript
Fixed Issues
$ #24810
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
web.mov
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
ios.mov
Android
android.mov