You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] Create an ESLint rule to detect multiple uses of withOnyx #27463
When withOnyx is used multiple times while composing components, it adds overhead to what Onyx has to keep track of and also prevents optimizations like batched render updates from working to their full potential.
changed the title [-]Create an ESLint rule to detect multiple uses of withOnyx[/-][+][$500] Create an ESLint rule to detect multiple uses of withOnyx[/+]on Sep 14, 2023
Hey @tgolen, as the PR is merged 6 days ago, and @MelvinBot didn't automatically report it. I believe the waiting time for payment is only 1 day left and tomorrow it should be released right?
I believe so, but I am not involved in that part of the process too much. @mallenexpensify might know better since he is handling the payment side for this issue.
Thanks for it @tgolen, This is also happening on another PR, in which we have to change the Title of the Issue. If I need to do anything, do let me know @mallenexpensify, thanks!
Hey @tgolen, as the PR is merged 6 days ago, and @MelvinBot didn't automatically report it. I believe the waiting time for payment is only 1 day left and tomorrow it should be released right?
Can we have a guide on this condition @mallenexpensify ? Thanks!
Contributor: @studentofcoding paid $750 via Upwork, includes 50% urgency bonus
Contributor+: @mollfpr is due $750. Unsure if paying via Upwork or NewDot yet, will know next week.
Reacted by Mohammad Luthfi Fathur Rahman and Architype
Activity
[-]Create an ESLint rule to detect multiple uses of withOnyx[/-][+][$500] Create an ESLint rule to detect multiple uses of withOnyx[/+]melvin-bot commentedon Sep 14, 2023
Triggered auto assignment to @mallenexpensify (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.melvin-bot commentedon Sep 14, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01f185d4f92edd4f6c
melvin-bot commentedon Sep 14, 2023
Triggered auto assignment to @puneetlath (
External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.melvin-bot commentedon Sep 14, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (
External)needpower commentedon Sep 14, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
withOnyx()can be called multiple times while composing components.What is the root cause of that problem?
Sometimes developers do not notice that
withOnyx()is already called, and create a new call instead of extending the existing one.What changes do you think we should make in order to solve the problem?
Create a new eslint rule in https://github.com/Expensify/eslint-config-expensify/blob/main/eslint-plugin-expensify/ called
no-multiple-onyx-callswhich will display an error message in case of multiple calls, e.g.What alternative solutions did you explore? (Optional)
N/A
23 remaining items
studentofcoding commentedon Sep 19, 2023
Thanks, @neil-marcellini
Upon Reading the Readme on https://github.com/Expensify/eslint-config-expensify it's said that the PR should be there, therefore it's ready to review on Expensify/eslint-config-expensify#73 @mollfpr @tgolen
studentofcoding commentedon Sep 21, 2023
The follow up PR is ready for review @tgolen @mollfpr #27840, thanks!
studentofcoding commentedon Sep 22, 2023
Hey @MelvinBot the PR is merged yesterday (takes 2 days)
studentofcoding commentedon Sep 27, 2023
Hey @tgolen, as the PR is merged 6 days ago, and @MelvinBot didn't automatically report it. I believe the waiting time for payment is only 1 day left and tomorrow it should be released right?
tgolen commentedon Sep 27, 2023
I believe so, but I am not involved in that part of the process too much. @mallenexpensify might know better since he is handling the payment side for this issue.
studentofcoding commentedon Sep 27, 2023
Thanks for it @tgolen, This is also happening on another PR, in which we have to change the Title of the Issue. If I need to do anything, do let me know @mallenexpensify, thanks!
studentofcoding commentedon Sep 27, 2023
Can we have a guide on this condition @mallenexpensify ? Thanks!
mallenexpensify commentedon Sep 29, 2023
Contributor: @studentofcoding paid $750 via Upwork, includes 50% urgency bonus
Contributor+: @mollfpr is due $750. Unsure if paying via Upwork or NewDot yet, will know next week.
mallenexpensify commentedon Oct 2, 2023
confirming payment for @mollfpr internally
https://expensify.slack.com/archives/C01SKUP7QR0/p1696254687480909
mollfpr commentedon Oct 19, 2023
@mallenexpensify I should be paid via Upwork since I already have the contract for this issue.
mallenexpensify commentedon Oct 20, 2023
Thanks @mollfpr , I agree, updated the above to reflect you've been paid via Upwork!