You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-18] [HOLD] [$500] iOS - App crashes on accessing the Date of Birth page in Spanish language #28315
changed the title [-]iOS - App crashes on accessing the Date of Birth page in Spanish language[/-][+][$500] iOS - App crashes on accessing the Date of Birth page in Spanish language[/+]on Sep 27, 2023
changed the title [-][HOLD] [$500] iOS - App crashes on accessing the Date of Birth page in Spanish language[/-][+][HOLD for payment 2023-10-18] [HOLD] [$500] iOS - App crashes on accessing the Date of Birth page in Spanish language[/+]on Oct 11, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.80-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-18. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
[@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@Ollyws] Determine if we should create a regression test for this bug.
[@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
[-]iOS - App crashes on accessing the Date of Birth page in Spanish language[/-][+][$500] iOS - App crashes on accessing the Date of Birth page in Spanish language[/+]melvin-bot commentedon Sep 27, 2023
Triggered auto assignment to @miljakljajic (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Sep 27, 2023
Job added to Upwork: https://www.upwork.com/jobs/~010dec7e5c136a9983
melvin-bot commentedon Sep 27, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Sep 27, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (
External)ahmedGaber93 commentedon Sep 27, 2023
I think a similar issue is fixed here #26719, and this also should be fixed.
umerfarooq492 commentedon Sep 27, 2023
@ahmedGaber93 this issue has been fixed in v1.3.68-17 and I tested this on v1.3.73-1 and it's still reproducible on v1.3.74-0
kushu7 commentedon Sep 27, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Fix ios crash on date-picker page
What is the root cause of that problem?
es locale import is missing
import 'moment/locale/es';is got removed.This is regression from this PR: #26248
What changes do you think we should make in order to solve the problem?
we should add
import 'moment/locale/es';in this file to fix crash.
What alternative solutions did you explore? (Optional)
None
pradeepmdk commentedon Sep 27, 2023
I think we need to wait this pr merge #28175
because moment js removing ongoing in the project.
7 remaining items
[-][HOLD] [$500] iOS - App crashes on accessing the Date of Birth page in Spanish language[/-][+][HOLD for payment 2023-10-18] [HOLD] [$500] iOS - App crashes on accessing the Date of Birth page in Spanish language[/+]melvin-bot commentedon Oct 11, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.80-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-18. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Oct 11, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
miljakljajic commentedon Oct 20, 2023
Looking back it seems like this issue is a duplicate of #26719 given that the app is crashing upon trying to open the date. Going to close.
situchan commentedon Nov 26, 2023
@mountiny are we eligible for compensation here based on This caused a regression but it was found after 7 days it was deployed to production?
We fixed crash in #26719 but #26248 (we never involved in this PR) caused regression. So we had to re-fix in #28948.
There was no compensation here only because the contributors were same working on 2 PRs.