You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] Fix style regressions caused by new Global Nav component #29057
This issue handles all regressions stemmed from the addition if the new Global Nav component in this PR. Any proposals should handle all these regressions. Please refer to the screenshots attached for the new design requirements to solve these issues.
When using set status we have sidebarStatusAvatarContainer width 84px so it will crop the avatar
What changes do you think we should make in order to solve the problem?
we can increase the width of global navigation to 86px or more, I think 92 is better, and we should center the float button.
The better we should wait for the design for that.
What alternative solutions did you explore? (Optional)
changed the title [-]Dev: Login - Sign in button for anonymous user on New LHN Nav is not fitting[/-][+][$500] Dev: Login - Sign in button for anonymous user on New LHN Nav is not fitting[/+]on Oct 7, 2023
Sign in button for anonymous user on New LHN Nav is not fitting properly.
Problem
Sign in Button has a width of 82 px while the globalNavigation container has width of 70 px so the sign in button does not fit in container
Changes
We can increase the size for the globalNavigation container to fit the sign in button but that would decrease the size for the container for chats, especially for small screen devices.
Also the decreasing the size for sign in button won't look appealing.
IMO, we should not the change the position for the sign in button and keep it next to the Search Icon. We can remove the avatar when user is not signed in or have the avatar but the onPress action should redirect sign in button we can use Session.checkIfActionIsAllowed for this.
edit -
Just noticed that the same issue is reproduced if signed in user sets a status the staus and avatar also not fit in the container. I think we should let the Design team decide the expected behaviour here
The most interesting thing for us is styles.ph5 and styles.globalNavigation
When these styles were created, perhaps the idea was that the width of the sidebar would be 72(styles.globalNavigation) + 20/20(styles.ph5)
But since in react native box-sizing is equal to border-box
We get the width which equals only 72
And if my theory is correct
Then in this case we need to increase the width to 112 (but 92 is better )
In which 72 is content and 20+20(10+10) is the border
What alternative solutions did you explore? (Optional)
The best way to fix this is to first contact the designers ))))
ashishBajracharyaFrostidi commented on Oct 8, 2023
the sidebar has a fixed width which is causing this issue, giving a variable width to the sidebar relative to the button width will solve this issue, even in the future if the button text changes or the font size increases, it won't cause a problem. #simpleCSSHacks
📣 @ashishBajracharyaFrostidi! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>
ashishBajracharyaFrostidi commented on Oct 8, 2023
Activity
namhihi237 commentedon Oct 7, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Sign in button and avatar with status should fit into the Sub LHN
What is the root cause of that problem?
Currently, global navigation has width 72px
App/src/styles/variables.ts
Lines 83 to 84 in 389d7b0
But the button sign-in has width 80px.
App/src/styles/styles.js
Lines 2296 to 2298 in 389d7b0
When using set status we have
sidebarStatusAvatarContainerwidth 84px so it will crop the avatarWhat changes do you think we should make in order to solve the problem?
we can increase the width of global navigation to
86pxor more, I think 92 is better, and we should center the float button.The better we should wait for the design for that.
What alternative solutions did you explore? (Optional)
N/A
[-]Dev: Login - Sign in button for anonymous user on New LHN Nav is not fitting[/-][+][$500] Dev: Login - Sign in button for anonymous user on New LHN Nav is not fitting[/+]melvin-bot commentedon Oct 7, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01289f055aecd3e696
melvin-bot commentedon Oct 7, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (
External)ishpaul777 commentedon Oct 7, 2023
Proposal
Problem
Sign in button for anonymous user on New LHN Nav is not fitting properly.
Problem
Sign in Button has a width of 82 px while the
globalNavigationcontainer has width of 70 px so the sign in button does not fit in containerChanges
We can increase the size for the
globalNavigationcontainer to fit the sign in button but that would decrease the size for the container for chats, especially for small screen devices.Also the decreasing the size for sign in button won't look appealing.
IMO, we should not the change the position for the sign in button and keep it next to the Search Icon. We can remove the avatar when user is not signed in or have the avatar but the onPress action should redirect sign in button we can use
Session.checkIfActionIsAllowedfor this.edit -
Just noticed that the same issue is reproduced if signed in user sets a status the staus and avatar also not fit in the container. I think we should let the Design team decide the expected behaviour here
ZhenjaHorbach commentedon Oct 7, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
The button is too big for sidebar
What is the root cause of that problem?
Sidebar width(72) is smaller than the button(80)
What changes do you think we should make in order to solve the problem?
First we need to look at the sidebar styles
App/src/pages/home/sidebar/GlobalNavigation/index.js
Line 32 in 389d7b0
The most interesting thing for us is
styles.ph5andstyles.globalNavigationWhen these styles were created, perhaps the idea was that the width of the sidebar would be 72(styles.globalNavigation) + 20/20(styles.ph5)
But since in react native box-sizing is equal to border-box
We get the width which equals only 72
And if my theory is correct
Then in this case we need to increase the width to 112 (but 92 is better )
In which 72 is content and 20+20(10+10) is the border
What alternative solutions did you explore? (Optional)
The best way to fix this is to first contact the designers ))))
ashishBajracharyaFrostidi commentedon Oct 8, 2023
the sidebar has a fixed width which is causing this issue, giving a variable width to the sidebar relative to the button width will solve this issue, even in the future if the button text changes or the font size increases, it won't cause a problem. #simpleCSSHacks
melvin-bot commentedon Oct 8, 2023
📣 @ashishBajracharyaFrostidi! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
ashishBajracharyaFrostidi commentedon Oct 8, 2023
Contributor details
Your Expensify account email: ashish.bajracharya.frostdigi.ai@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0135bbe272a370da40
melvin-bot commentedon Oct 8, 2023
✅ Contributor details stored successfully. Thank you for contributing to Expensify!
maxconnectAbhi commentedon Oct 8, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue
Login - Sign in button for anonymous user on New LHN Nav is not fitting
What is the root cause of that problem?
Sign in Button has a width of 82 px while the globalNavigation container has width of 70 px so the sign in button does not fit in container
What changes do you think we should make in order to solve the problem?
We should make the width for sign in button 95% of the container here
width: '95%'App/src/styles/styles.js
Lines 2296 to 2298 in 389d7b0
What alternative solutions did you explore? (Optional)
NA
58 remaining items
hayata-suenaga commentedon Dec 11, 2023
Please handle the payment according to this suggestion please 🙇
situchan commentedon Dec 11, 2023
I noticed that @zanyrenney's slack status indicates OOO until Wed
zanyrenney commentedon Dec 13, 2023
payment summary - @ishpaul777 $50 for regression reports.
@situchan $500 for C+ review
As per this comment, closing.
zanyrenney commentedon Dec 14, 2023
Paid @situchan through bonus due to problem with hourly contract.
zanyrenney commentedon Dec 14, 2023
Paid @situchan via a bonus as I messed up the orignal offer and made it hourly. Closing!
zanyrenney commentedon Dec 14, 2023