Skip to content

[$500] Fix style regressions caused by new Global Nav component #29057

Closed

Description

@kbecciv

This issue handles all regressions stemmed from the addition if the new Global Nav component in this PR. Any proposals should handle all these regressions. Please refer to the screenshots attached for the new design requirements to solve these issues.

cc: @allroundexperts

Screenshot 2023-10-11 at 2 35 05 PM

Activity

  1. namhihi237 commented on Oct 7, 2023

    @namhihi237
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Sign in button and avatar with status should fit into the Sub LHN

    What is the root cause of that problem?

    Currently, global navigation has width 72px

    globalNavigationWidth: 72,
    sideBarWidth: 303 + 72,

    But the button sign-in has width 80px.

    App/src/styles/styles.js

    Lines 2296 to 2298 in 389d7b0

    signInButtonAvatar: {
    width: 80,
    },

    When using set status we have sidebarStatusAvatarContainer width 84px so it will crop the avatar

    What changes do you think we should make in order to solve the problem?

    we can increase the width of global navigation to 86px or more, I think 92 is better, and we should center the float button.
    The better we should wait for the design for that.

    What alternative solutions did you explore? (Optional)

    N/A

  2. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 7, 2023
  3. changed the title [-]Dev: Login - Sign in button for anonymous user on New LHN Nav is not fitting[/-] [+][$500] Dev: Login - Sign in button for anonymous user on New LHN Nav is not fitting[/+] on Oct 7, 2023
  4. melvin-bot commented on Oct 7, 2023

    @melvin-bot
  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 7, 2023
  6. melvin-bot commented on Oct 7, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

  7. ishpaul777 commented on Oct 7, 2023

    @ishpaul777
    Contributor

    Proposal

    Problem

    Sign in button for anonymous user on New LHN Nav is not fitting properly.

    Problem

    Sign in Button has a width of 82 px while the globalNavigation container has width of 70 px so the sign in button does not fit in container

    Changes

    We can increase the size for the globalNavigation container to fit the sign in button but that would decrease the size for the container for chats, especially for small screen devices.

    Also the decreasing the size for sign in button won't look appealing.

    Screenshot 2023-10-08 at 3 17 02 AM

    IMO, we should not the change the position for the sign in button and keep it next to the Search Icon. We can remove the avatar when user is not signed in or have the avatar but the onPress action should redirect sign in button we can use Session.checkIfActionIsAllowed for this.

    edit -
    Just noticed that the same issue is reproduced if signed in user sets a status the staus and avatar also not fit in the container. I think we should let the Design team decide the expected behaviour here

  8. ZhenjaHorbach commented on Oct 7, 2023

    @ZhenjaHorbach
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The button is too big for sidebar

    What is the root cause of that problem?

    Sidebar width(72) is smaller than the button(80)

    What changes do you think we should make in order to solve the problem?

    First we need to look at the sidebar styles

    <View style={[styles.ph5, styles.pv3, styles.alignItemsCenter, styles.h100, styles.globalNavigation]}>

    The most interesting thing for us is styles.ph5 and styles.globalNavigation

    When these styles were created, perhaps the idea was that the width of the sidebar would be 72(styles.globalNavigation) + 20/20(styles.ph5)

    But since in react native box-sizing is equal to border-box
    We get the width which equals only 72

    And if my theory is correct
    Then in this case we need to increase the width to 112 (but 92 is better )
    In which 72 is content and 20+20(10+10) is the border

    What alternative solutions did you explore? (Optional)

    The best way to fix this is to first contact the designers ))))

  9. ashishBajracharyaFrostidi commented on Oct 8, 2023

    @ashishBajracharyaFrostidi

    the sidebar has a fixed width which is causing this issue, giving a variable width to the sidebar relative to the button width will solve this issue, even in the future if the button text changes or the font size increases, it won't cause a problem. #simpleCSSHacks

  10. melvin-bot commented on Oct 8, 2023

    @melvin-bot

    📣 @ashishBajracharyaFrostidi! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  11. ashishBajracharyaFrostidi commented on Oct 8, 2023

    @ashishBajracharyaFrostidi

    Contributor details
    Your Expensify account email: ashish.bajracharya.frostdigi.ai@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~0135bbe272a370da40

  12. melvin-bot commented on Oct 8, 2023

    @melvin-bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  13. maxconnectAbhi commented on Oct 8, 2023

    @maxconnectAbhi

    Proposal

    Please re-state the problem that we are trying to solve in this issue

    Login - Sign in button for anonymous user on New LHN Nav is not fitting

    What is the root cause of that problem?

    Sign in Button has a width of 82 px while the globalNavigation container has width of 70 px so the sign in button does not fit in container

    What changes do you think we should make in order to solve the problem?

    We should make the width for sign in button 95% of the container here
    width: '95%'

    App/src/styles/styles.js

    Lines 2296 to 2298 in 389d7b0

    signInButtonAvatar: {
    width: 80,
    },

    What alternative solutions did you explore? (Optional)

    NA

  14. 58 remaining items

  15. hayata-suenaga commented on Dec 11, 2023

    @hayata-suenaga
    Contributor

    Please handle the payment according to this suggestion please 🙇

  16. situchan commented on Dec 11, 2023

    @situchan
    Contributor

    I noticed that @zanyrenney's slack status indicates OOO until Wed

  17. zanyrenney commented on Dec 13, 2023

    @zanyrenney
    Contributor

    2023-12-13_19-03-52

    payment summary - @ishpaul777 $50 for regression reports.
    @situchan $500 for C+ review

    As per this comment, closing.

  18. zanyrenney commented on Dec 14, 2023

    @zanyrenney
    Contributor

    Paid @situchan through bonus due to problem with hourly contract.

  19. zanyrenney commented on Dec 14, 2023

    @zanyrenney
    Contributor

    Paid @situchan via a bonus as I messed up the orignal offer and made it hourly. Closing!

  20. zanyrenney commented on Dec 14, 2023

    @zanyrenney
    Contributor

    2023-12-14_16-20-46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions