Skip to content

[$500] Desktop - The upper left "Apple icons" have a faint tinted line through them #29162

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.3.80-0

Reproducible in staging?: Y

Reproducible in production?: N, this is a new feature

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

Action Performed:

  1. Open the New Expensify Desktop app
  2. Sign into a valid account
  3. Observe the top left corner

Expected Result:

User expects that there is no overlapping and items are spaced evenly

Actual Result:

There is a very faint green line running through the Desktop Apple icons in the upper left corner. Also, these icons are very closely displayed to the users avatar image and when there is an error message (Red dot) on the users profile, they almost overlap.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

Bug6231461_1696915877805!Zoomed_in_screenshot
Bug6231461_1696915877827!Desktop_apple_icons_slightly_overlap_with_fading_effect
Bug6231461_1696915877794!How_it_displays_when_there_is_an_error_icon

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0121122693d769b021
  • Upwork Job ID: 1711662396186996736
  • Last Price Increase: 2023-10-10

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 10, 2023
  2. melvin-bot commented on Oct 10, 2023

    @melvin-bot

    Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. changed the title [-] Desktop - The upper left "Apple icons" have a faint tinted line through them[/-] [+][$500] Desktop - The upper left "Apple icons" have a faint tinted line through them[/+] on Oct 10, 2023
  4. melvin-bot commented on Oct 10, 2023

    @melvin-bot
  5. melvin-bot commented on Oct 10, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 10, 2023
  7. melvin-bot commented on Oct 10, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

  8. 7 remaining items

  9. shawnborton commented on Oct 10, 2023

    @shawnborton
    Contributor

    We should not be taking proposals for this, this is a known follow-up item for @adamgrzybowski

  10. madmax330 commented on Oct 10, 2023

    @madmax330
    Contributor

    Cool so we can close this @shawnborton or should I assign @adamgrzybowski ?

  11. shawnborton commented on Oct 10, 2023

    @shawnborton
    Contributor

    Let's first confirm with @hayata-suenaga - I'm not sure what our plan is for consolidating design bugs for the hybrid web project.

  12. jasperhuangg commented on Oct 10, 2023

    @jasperhuangg
    Contributor

    Gonna take the Deploy Blocker label off if this is a known followup

  13. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Oct 10, 2023
  14. trjExpensify commented on Oct 10, 2023

    @trjExpensify
    Contributor

    I asked @stitesExpensify if he knew here, but I think we'll have to wait for @hayata-suenaga to confirm the plan for these design followups.

  15. hayata-suenaga commented on Oct 11, 2023

    @hayata-suenaga
    Contributor

    This issue is consolidated to this issue. This issue was reported by Applause, so no payment is necessary for bug report.

  16. kosmydel commented on Oct 12, 2023

    @kosmydel
    Contributor

    Hey, some questions related to design here:

    I'm considering the following options:

    1. Increase padding on the desktop (I believe that 27px will have even paddings from the top and bottom) and change the background color of the header gap (screen).
    2. Or maybe increase padding for the avatar. Downside: Avatar will no longer align with the other items at the top ("Chats" text, Search loop, etc.).

    Here is what the first option looks like:
    Screenshot 2023-10-12 at 12 39 49

    We also have to take into consideration that the Avatar displays a popup when is hovered:
    Screenshot 2023-10-12 at 12 40 01

    Which option is the preferred one?

    cc @shawnborton, @hayata-suenaga

  17. shawnborton commented on Oct 12, 2023

    @shawnborton
    Contributor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions