You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] Dev: LHN - Border color around profile pic is different in LHN #29079
Click on the group and verify border color around profile pic in LHN
Expected Result:
Border color is different
Actual Result:
Border color should not be different
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android / native
Android / Chrome
iOS / native
iOS / Safari
MacOS / Chrome / Safari
MacOS / Desktop
Version Number: Dev 1.3.79.3 Reproducible in staging?: n Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Notes/Photos/Videos: Any additional supporting documentation
changed the title [-]Dev: LHN - Border color around profile pic is different in LHN[/-][+][$500] Dev: LHN - Border color around profile pic is different in LHN[/+]on Oct 9, 2023
Not sure but looks like a regression from #28277, styling issues from #28277 are consolidated in #29057 and being taken care of in #29428 cc @hayata-suenaga
Activity
[-]Dev: LHN - Border color around profile pic is different in LHN[/-][+][$500] Dev: LHN - Border color around profile pic is different in LHN[/+]melvin-bot commentedon Oct 9, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01092e70102b992daf
saranshbalyan-1234 commentedon Oct 9, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
border color around focused profile pic is different in LHN
What is the root cause of that problem?
The problem is in the secondaryAvatarStyle being passed to the MultipleAvatars component.
App/src/components/LHNOptionsList/OptionRowLHN.js
Lines 209 to 219 in 389d7b0
When focused we are passing focusedBackgroundColor which is different from the activeComponentBG color
What changes do you think we should make in order to solve the problem?
instead of focusedBackgroundColor we should pass activeComponentBG

Result
What alternative solutions did you explore? (Optional)
We can also change the value of styles.sidebarLinkActiveLHN.backgroundColor to themeColors.activeComponentBG's values
melvin-bot commentedon Oct 9, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (
External)PiyushChandra17 commentedon Oct 9, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
LHN - Border color around profile pic is different in LHN
What is the root cause of that problem?
We are using
themeColors.sidebarhere,App/src/components/LHNOptionsList/OptionRowLHN.js
Line 214 in 619aee6
What changes do you think we should make in order to solve the problem?
We need to replace
themeColors.sidebarwiththemeColors.appBG,What alternative solutions did you explore? (Optional)
NA
Result:
ishpaul777 commentedon Oct 9, 2023
this can be fixed with #29058
Santhosh-Sellavel commentedon Oct 9, 2023
@saranshbalyan-1234's proposals LGTM!
C+ Reviewed
🎀 👀 🎀
melvin-bot commentedon Oct 9, 2023
Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.
saranshbalyan-1234 commentedon Oct 12, 2023
Hi @grgia friendly bump for review
grgia commentedon Oct 12, 2023
@Santhosh-Sellavel this seems like a recent regression, have we determined if a recent PR caused this and the author should fix it?
ishpaul777 commentedon Oct 12, 2023
Not sure but looks like a regression from #28277, styling issues from #28277 are consolidated in #29057 and being taken care of in #29428 cc @hayata-suenaga
saranshbalyan-1234 commentedon Oct 12, 2023
Nope,I checked and this won't take care of this scenario at all
hayata-suenaga commentedon Oct 16, 2023
I feel like I remember we talked about this as a regression. Checking in the consolidated issue
hayata-suenaga commentedon Oct 16, 2023
@Santhosh-Sellavel please check the linked consolidated issue and let the Bug Zero team know if we should close this issue
melvin-bot commentedon Oct 16, 2023
@grgia, @Santhosh-Sellavel Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Santhosh-Sellavel commentedon Oct 16, 2023
I guess we can close this one, as it is being handled as part of #29057
hayata-suenaga commentedon Oct 17, 2023
sorry I thought I was assigned to this issue 😓 @grgia please open the issue if you feel like it needs some more work