Skip to content

[$500] Dev: LHN - Border color around profile pic is different in LHN #29079

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Create a group
  2. Click on the group and verify border color around profile pic in LHN

Expected Result:

Border color is different

Actual Result:

Border color should not be different

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: Dev 1.3.79.3
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

image (9)
image (8)
image (7)

RPReplay_Final1696655902.MP4
Screen_Recording_20231007_104615_New.Expensify.Dev.mp4
Screen_Recording_20231007_104703_Chrome.mp4
Screen.Recording.2023-10-07.at.10.34.04.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696655745191809

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01092e70102b992daf
  • Upwork Job ID: 1711339977280749568
  • Last Price Increase: 2023-10-09

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 9, 2023
  2. changed the title [-]Dev: LHN - Border color around profile pic is different in LHN[/-] [+][$500] Dev: LHN - Border color around profile pic is different in LHN[/+] on Oct 9, 2023
  3. melvin-bot commented on Oct 9, 2023

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 9, 2023
  5. saranshbalyan-1234 commented on Oct 9, 2023

    @saranshbalyan-1234
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    border color around focused profile pic is different in LHN

    What is the root cause of that problem?

    The problem is in the secondaryAvatarStyle being passed to the MultipleAvatars component.

    <MultipleAvatars
    icons={optionItem.icons}
    isFocusMode={props.viewMode === CONST.OPTION_MODE.COMPACT}
    size={props.viewMode === CONST.OPTION_MODE.COMPACT ? CONST.AVATAR_SIZE.SMALL : CONST.AVATAR_SIZE.DEFAULT}
    secondAvatarStyle={[
    StyleUtils.getBackgroundAndBorderStyle(themeColors.sidebar),
    props.isFocused ? StyleUtils.getBackgroundAndBorderStyle(focusedBackgroundColor) : undefined,
    hovered && !props.isFocused ? StyleUtils.getBackgroundAndBorderStyle(hoveredBackgroundColor) : undefined,
    ]}
    shouldShowTooltip={OptionsListUtils.shouldOptionShowTooltip(optionItem)}
    />

    When focused we are passing focusedBackgroundColor which is different from the activeComponentBG color

    What changes do you think we should make in order to solve the problem?

    instead of focusedBackgroundColor we should pass activeComponentBG
    Result
    Screenshot 2023-10-07 at 3 11 00 PM

    What alternative solutions did you explore? (Optional)

    We can also change the value of styles.sidebarLinkActiveLHN.backgroundColor to themeColors.activeComponentBG's values

  6. melvin-bot commented on Oct 9, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

  7. PiyushChandra17 commented on Oct 9, 2023

    @PiyushChandra17
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    LHN - Border color around profile pic is different in LHN

    What is the root cause of that problem?

    We are using themeColors.sidebar here,

    StyleUtils.getBackgroundAndBorderStyle(themeColors.sidebar),

    What changes do you think we should make in order to solve the problem?

    We need to replace themeColors.sidebar with themeColors.appBG,

    StyleUtils.getBackgroundAndBorderStyle(themeColors.appBG),
    
    

    What alternative solutions did you explore? (Optional)

    NA

    Result:

    Screenshot 2023-10-09 at 5 11 06 PM
  8. ishpaul777 commented on Oct 9, 2023

    @ishpaul777
    Contributor

    this can be fixed with #29058

  9. Santhosh-Sellavel commented on Oct 9, 2023

    @Santhosh-Sellavel
    Collaborator

    @saranshbalyan-1234's proposals LGTM!
    C+ Reviewed
    🎀 👀 🎀

  10. melvin-bot commented on Oct 9, 2023

    @melvin-bot

    Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

  11. saranshbalyan-1234 commented on Oct 12, 2023

    @saranshbalyan-1234
    Contributor

    Hi @grgia friendly bump for review

  12. grgia commented on Oct 12, 2023

    @grgia
    Contributor

    @Santhosh-Sellavel this seems like a recent regression, have we determined if a recent PR caused this and the author should fix it?

  13. ishpaul777 commented on Oct 12, 2023

    @ishpaul777
    Contributor

    Not sure but looks like a regression from #28277, styling issues from #28277 are consolidated in #29057 and being taken care of in #29428 cc @hayata-suenaga

  14. saranshbalyan-1234 commented on Oct 12, 2023

    @saranshbalyan-1234
    Contributor

    Nope,I checked and this won't take care of this scenario at all

  15. hayata-suenaga commented on Oct 16, 2023

    @hayata-suenaga
    Contributor

    I feel like I remember we talked about this as a regression. Checking in the consolidated issue

  16. hayata-suenaga commented on Oct 16, 2023

    @hayata-suenaga
    Contributor

    @Santhosh-Sellavel please check the linked consolidated issue and let the Bug Zero team know if we should close this issue

  17. melvin-bot commented on Oct 16, 2023

    @melvin-bot

    @grgia, @Santhosh-Sellavel Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  18. Santhosh-Sellavel commented on Oct 16, 2023

    @Santhosh-Sellavel
    Collaborator

    I guess we can close this one, as it is being handled as part of #29057

  19. hayata-suenaga commented on Oct 17, 2023

    @hayata-suenaga
    Contributor

    sorry I thought I was assigned to this issue 😓 @grgia please open the issue if you feel like it needs some more work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions