Skip to content

[$750] Desktop - "Hmm... it's not here" is displayed when a profile deeplink is opened two or more times #29372

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Found when executing PR : #29277

Version Number: v1.3.81-6

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause-Internal Team

Slack conversation: @

Action Performed:

Precondition: User A and User B should have no prior chat history

As User A:

  1. Open a tab and sign in as User A
  2. Click on 'Profile avatar' > Share code > Copy URL to clipboard

As User B:

  1. Open staging.new.expensify.com and sign in as User B
  2. Paste the URL into the address bar
  3. Press enter
  4. In the ''Open New Expensify'' modal, click on the CTA button to open the app
  5. Close the profile page
  6. Go back to the web page and paste the profile link for a second time
  7. Repeat step 4

Expected Result:

There should be no errors when opening the deeplink from the same profile page multiple times.

Actual Result:

The user encounters a "page not found" error when attempting to open the profile page deeplink two or more times in Desktop app.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
Bug6233436_1697049112244.Profile_page_in_desktop_app_-error.mp4

utest-dl.s3.amazonaws.com_12102_26469_432782_6233436_bugAttachment_Bug6233436_1697049112244%21Profile_page_-_Desktop.log_X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Date=20231011T195222Z&X-Amz-SignedHeaders=host&X-Amz-Expires=86400&X-Amz.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019231ee47ef138a05
  • Upwork Job ID: 1712194879740461056
  • Last Price Increase: 2023-10-27
  • Automatic offers:
    • situchan | Contributor | 27546164

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 11, 2023
  2. changed the title [-]Desktop - "Hmm... it's not here" is displayed when a profile deeplink is opened two or more times[/-] [+][$500] Desktop - "Hmm... it's not here" is displayed when a profile deeplink is opened two or more times[/+] on Oct 11, 2023
  3. melvin-bot commented on Oct 11, 2023

    @melvin-bot

    Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot commented on Oct 11, 2023

    @melvin-bot
  5. melvin-bot commented on Oct 11, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 11, 2023
  7. melvin-bot commented on Oct 11, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

  8. akamefi202 commented on Oct 13, 2023

    @akamefi202
    Contributor

    Not reproducible.

  9. NicMendonca commented on Oct 13, 2023

    @NicMendonca
    Contributor

    @izarutskaya can you still reproduce this issue?

  10. izarutskaya commented on Oct 14, 2023

    @izarutskaya
    Author

    Yes, @NicMendonca, we can reproduce this still on Version 1.3.83-10 (1.3.83-10)

    Screen.Recording.2023-10-13.at.17.47.45.mov
    Screen.Recording.2023-10-13.at.17.46.30.mov
  11. 81 remaining items

  12. situchan commented on Dec 5, 2023

    @situchan
    Contributor

    @ikevin127 I am not ignoring this issue but keep tracking.
    can you check if this is still reproducible on main after applying #32158.
    Not found page on staging will be fixed in #32158.

  13. situchan commented on Dec 5, 2023

    @situchan
    Contributor

    Also I was holding based on #29372 (comment).
    If we wanna fix infinite loading here (I can reliably reproduce), we can go ahead.
    @NicMendonca seems like #31195 is being fixed internally and different from this one.

  14. ikevin127 commented on Dec 5, 2023

    @ikevin127
    Contributor

    @situchan Sure! My take is that this issue and #28495 have different root cause.

    I checked out tienifr's branch and here are the results:

    What his PR does to help this issue is that it fixes the not found page that we get on the staging build of the desktop app in the following scenarios:

    • when deep linking from web to desktop while user is not authenticated yet in desktop app
    • when deep linking from web to desktop while user is already authenticated

    What the PR does not fix for the current issue:

    • while we don't get the not found page anymore, what happens now is that it unifies the behaviour with the one on local development of desktop app: meaning infinite loading spinner everytime deeplinking from web happens
    • it also doesn't fix this additional bug where while trying to logout while the infinite loading spinner is ongoing, the app doesn't actually logout (see videos below)

    Videos with tienifr's branch from #32158

    • you can now notice that we have unified behaviour on both staging and local dev desktop (infinite loading spinner)
    MacOS: Desktop (staging / local)
    • staging
    stg-tienifr.mov
    • local dev
    dev-tienifr.mp4

    If we wanna fix infinite loading here (I can reliably reproduce), we can go ahead.

    I agree, and for this, in addition to my updated proposal I think the root cause is the fact that we're still calling the navigate here:

    Navigation.navigate(route, CONST.NAVIGATION.ACTION_TYPE.PUSH);

    when that's not necesarry and causes the infinite loading spinner and the logout bug mentioned above.

    So to move forward with this issue I think we can agree on fixing the infinite loading spinner and the logout bug in order to finally conclude this issue.

    Also I can confirm that #31195 is a completely different issue that has to be fixed with code changes in OldDot's codebase hence why I recommended the issue to go internal.

  15. melvin-bot commented on Dec 8, 2023

    @melvin-bot

    @barttom, @NicMendonca, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

  16. NicMendonca commented on Dec 11, 2023

    @NicMendonca
    Contributor

    @situchan bump ^^

  17. situchan commented on Dec 14, 2023

    @situchan
    Contributor
  18. NicMendonca commented on Dec 14, 2023

    @NicMendonca
    Contributor

    Looks like #31195 is being closed

  19. NicMendonca commented on Dec 14, 2023

    @NicMendonca
    Contributor

    Based on this post here, I am going to close this

    @situchan feel free to start a brand new discussion around infinite loading

  20. ikevin127 commented on Dec 15, 2023

    @ikevin127
    Contributor

    I will handle it here #33149, all good !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions