You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$750] Desktop - "Hmm... it's not here" is displayed when a profile deeplink is opened two or more times #29372
changed the title [-]Desktop - "Hmm... it's not here" is displayed when a profile deeplink is opened two or more times[/-][+][$500] Desktop - "Hmm... it's not here" is displayed when a profile deeplink is opened two or more times[/+]on Oct 11, 2023
@ikevin127 I am not ignoring this issue but keep tracking.
can you check if this is still reproducible on main after applying #32158.
Not found page on staging will be fixed in #32158.
Also I was holding based on #29372 (comment).
If we wanna fix infinite loading here (I can reliably reproduce), we can go ahead. @NicMendonca seems like #31195 is being fixed internally and different from this one.
@situchan Sure! My take is that this issue and #28495 have different root cause.
I checked out tienifr's branch and here are the results:
What his PR does to help this issue is that it fixes the not found page that we get on the staging build of the desktop app in the following scenarios:
when deep linking from web to desktop while user is not authenticated yet in desktop app
when deep linking from web to desktop while user is already authenticated
What the PR does not fix for the current issue:
while we don't get the not found page anymore, what happens now is that it unifies the behaviour with the one on local development of desktop app: meaning infinite loading spinner everytime deeplinking from web happens
it also doesn't fix this additional bug where while trying to logout while the infinite loading spinner is ongoing, the app doesn't actually logout (see videos below)
when that's not necesarry and causes the infinite loading spinner and the logout bug mentioned above.
So to move forward with this issue I think we can agree on fixing the infinite loading spinner and the logout bug in order to finally conclude this issue.
Also I can confirm that #31195 is a completely different issue that has to be fixed with code changes in OldDot's codebase hence why I recommended the issue to go internal.
Activity
[-]Desktop - "Hmm... it's not here" is displayed when a profile deeplink is opened two or more times[/-][+][$500] Desktop - "Hmm... it's not here" is displayed when a profile deeplink is opened two or more times[/+]melvin-bot commentedon Oct 11, 2023
Triggered auto assignment to @NicMendonca (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Oct 11, 2023
Job added to Upwork: https://www.upwork.com/jobs/~019231ee47ef138a05
melvin-bot commentedon Oct 11, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Oct 11, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (
External)akamefi202 commentedon Oct 13, 2023
Not reproducible.
NicMendonca commentedon Oct 13, 2023
@izarutskaya can you still reproduce this issue?
izarutskaya commentedon Oct 14, 2023
Yes, @NicMendonca, we can reproduce this still on Version 1.3.83-10 (1.3.83-10)
Screen.Recording.2023-10-13.at.17.47.45.mov
Screen.Recording.2023-10-13.at.17.46.30.mov
81 remaining items
situchan commentedon Dec 5, 2023
@ikevin127 I am not ignoring this issue but keep tracking.
can you check if this is still reproducible on main after applying #32158.
Not found page on staging will be fixed in #32158.
situchan commentedon Dec 5, 2023
Also I was holding based on #29372 (comment).
If we wanna fix infinite loading here (I can reliably reproduce), we can go ahead.
@NicMendonca seems like #31195 is being fixed internally and different from this one.
ikevin127 commentedon Dec 5, 2023
@situchan Sure! My take is that this issue and #28495 have different root cause.
I checked out tienifr's branch and here are the results:
What his PR does to help this issue is that it fixes the not found page that we get on the staging build of the desktop app in the following scenarios:
What the PR does not fix for the current issue:
Videos with tienifr's branch from #32158
MacOS: Desktop (staging / local)
stg-tienifr.mov
dev-tienifr.mp4
I agree, and for this, in addition to my updated proposal I think the root cause is the fact that we're still calling the navigate here:
App/src/libs/actions/Report.js
Line 2005 in 4aa5d8e
when that's not necesarry and causes the infinite loading spinner and the logout bug mentioned above.
So to move forward with this issue I think we can agree on fixing the infinite loading spinner and the logout bug in order to finally conclude this issue.
Also I can confirm that #31195 is a completely different issue that has to be fixed with code changes in OldDot's codebase hence why I recommended the issue to go internal.
melvin-bot commentedon Dec 8, 2023
@barttom, @NicMendonca, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!
NicMendonca commentedon Dec 11, 2023
@situchan bump ^^
situchan commentedon Dec 14, 2023
@NicMendonca do you agree #29372 (comment)?
NicMendonca commentedon Dec 14, 2023
Looks like #31195 is being closed
NicMendonca commentedon Dec 14, 2023
Based on this post here, I am going to close this
@situchan feel free to start a brand new discussion around infinite loading
ikevin127 commentedon Dec 15, 2023
I will handle it here #33149, all good !