Skip to content

[HOLD for payment 2023-10-30] [HOLD for payment 2023-10-27] [$250] Login - App crash on login #29965

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.87.1
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan /Applause- Internal team reported later
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697694190199399

Action Performed:

  1. Logout if you logged in
  2. Create new account
  3. Enter email which is not used before and enter magic code

Expected Result:

App should not crash

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2023-10-19.at.11.15.49.AM.mov
MacOS: Desktop
Screen.Recording.2023-10-19.at.11.18.06.AM.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0110ec104becd93e90
  • Upwork Job ID: 1715007628320174080
  • Last Price Increase: 2023-10-19
  • Automatic offers:
    • hoangzinh | Reviewer | 27283181
    • gadhiyamanan | Reporter | 27283182
    • situchan | Contributor | 27283230

Activity

  1. dukenv0307 commented on Oct 19, 2023

    @dukenv0307
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    App crash on login

    What is the root cause of that problem?

    After login with a new account ReportActionsView is rendered with reportActions as an empty object briefly

    image

    And then the app crashes with this condition because reportActions is {}

    const iouRequestActions = reportActions?.filter((action) => action.actionName === CONST.REPORT.ACTIONS.TYPE.IOU && iouRequestTypes.includes(action.originalMessage.type)) ?? [];

    What changes do you think we should make in order to solve the problem?

    We should safely using _.filter instead of using reportActions?.filter

    const iouRequestActions = _.filter(reportActions, (action) => action.actionName === CONST.REPORT.ACTIONS.TYPE.IOU && iouRequestTypes.includes(action.originalMessage.type))
    

    const iouRequestActions = reportActions?.filter((action) => action.actionName === CONST.REPORT.ACTIONS.TYPE.IOU && iouRequestTypes.includes(action.originalMessage.type)) ?? [];

    What alternative solutions did you explore? (Optional)

  2. OSBotify commented on Oct 19, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. melvin-bot commented on Oct 19, 2023

    @melvin-bot

    Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  4. situchan commented on Oct 19, 2023

    @situchan
    Contributor

    @dukenv0307 It's intentional to get rid of _ in TS.

    After login with a new account ReportActionsView is rendered with reportActions as an empty object briefly

    We should fix this root cause. So there should be no case of reportActions being set to non-array.

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 19, 2023
  6. changed the title [-]Login - App crash on login[/-] [+][$500] Login - App crash on login[/+] on Oct 19, 2023
  7. melvin-bot commented on Oct 19, 2023

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 19, 2023
  9. 39 remaining items

  10. changed the title [-][HOLD for payment 2023-10-27] [$250] Login - App crash on login[/-] [+][HOLD for payment 2023-10-30] [HOLD for payment 2023-10-27] [$250] Login - App crash on login[/+] on Oct 23, 2023
  11. melvin-bot commented on Oct 23, 2023

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.88-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2023-10-30. 🎊

    After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

    • External issue reporter
    • Contributor that fixed the issue
    • Contributor+ that helped on the issue and/or PR

    For reference, here are some details about the assignees on this issue:

    As a reminder, here are the bonuses/penalties that should be applied for any External issue:

    • Merged PR within 3 business days of assignment - 50% bonus
    • Merged PR more than 9 business days after assignment - 50% penalty
  12. melvin-bot commented on Oct 23, 2023

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@situchan] The PR that introduced the bug has been identified. Link to the PR:
    • [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@situchan] Determine if we should create a regression test for this bug.
    • [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  13. melvin-bot commented on Oct 30, 2023

    @melvin-bot

    @kubabutkiewicz, @stephanieelliott, @mountiny, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

  14. mountiny commented on Oct 30, 2023

    @mountiny
    Contributor

    @mallenexpensify could you please share console logs with that crash?

  15. situchan commented on Oct 30, 2023

    @situchan
    Contributor

    @mallenexpensify could you please share console logs with that crash?

    It's different crash - #30109

  16. stephanieelliott commented on Oct 31, 2023

    @stephanieelliott
    Contributor

    Is there a regression? Or are we all good to pay here? cc: @mallenexpensify

  17. mountiny commented on Nov 1, 2023

    @mountiny
    Contributor

    @stephanieelliott I think we are good to pay @situchan suggested its a different issue

  18. stephanieelliott commented on Nov 1, 2023

    @stephanieelliott
    Contributor

    Summarizing payment on this issue:

    • Issue reporter: @gadhiyamanan $50 -Upwork - PAID
    • Contributor: N/A
    • Contributor+: @situchan $250 - Upwork - PAID

    Upwork job is here, no bonus is included on final payout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions