You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2023-10-30] [HOLD for payment 2023-10-27] [$250] Login - App crash on login #29965
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-][HOLD for payment 2023-10-27] [$250] Login - App crash on login[/-][+][HOLD for payment 2023-10-30] [HOLD for payment 2023-10-27] [$250] Login - App crash on login[/+]on Oct 23, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.88-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-30. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR
For reference, here are some details about the assignees on this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@situchan] The PR that introduced the bug has been identified. Link to the PR:
[@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@situchan] Determine if we should create a regression test for this bug.
[@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
dukenv0307 commentedon Oct 19, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
App crash on login
What is the root cause of that problem?
After login with a new account
ReportActionsViewis rendered withreportActionsas an empty object brieflyAnd then the app crashes with this condition because
reportActionsis{}App/src/libs/ReportActionsUtils.ts
Line 175 in 229cb5d
What changes do you think we should make in order to solve the problem?
We should safely using
_.filterinstead of usingreportActions?.filterApp/src/libs/ReportActionsUtils.ts
Line 175 in 229cb5d
What alternative solutions did you explore? (Optional)
OSBotify commentedon Oct 19, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
StagingDeployCashdeploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:melvin-bot commentedon Oct 19, 2023
Triggered auto assignment to @robertjchen (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.situchan commentedon Oct 19, 2023
@dukenv0307 It's intentional to get rid of _ in TS.
We should fix this root cause. So there should be no case of
reportActionsbeing set to non-array.[-]Login - App crash on login[/-][+][$500] Login - App crash on login[/+]melvin-bot commentedon Oct 19, 2023
Job added to Upwork: https://www.upwork.com/jobs/~0110ec104becd93e90
39 remaining items
[-][HOLD for payment 2023-10-27] [$250] Login - App crash on login[/-][+][HOLD for payment 2023-10-30] [HOLD for payment 2023-10-27] [$250] Login - App crash on login[/+]melvin-bot commentedon Oct 23, 2023
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.88-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-10-30. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
melvin-bot commentedon Oct 23, 2023
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
melvin-bot commentedon Oct 30, 2023
@kubabutkiewicz, @stephanieelliott, @mountiny, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!
mountiny commentedon Oct 30, 2023
@mallenexpensify could you please share console logs with that crash?
situchan commentedon Oct 30, 2023
It's different crash - #30109
stephanieelliott commentedon Oct 31, 2023
Is there a regression? Or are we all good to pay here? cc: @mallenexpensify
mountiny commentedon Nov 1, 2023
@stephanieelliott I think we are good to pay @situchan suggested its a different issue
stephanieelliott commentedon Nov 1, 2023
Summarizing payment on this issue:
Upwork job is here, no bonus is included on final payout