Repository navigation
Closed
Labels
DailyKSv2KSv2ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsApply this label when an issue is open to proposals by contributorsStagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Description
Release Version: 1.4.12-2
Compare Changes: production...staging
This release contains changes from the following pull requests:
- [TS migration] Migrate 'Report.js' lib to TypeScript #28730
- Add Approve button for collect policies in the Settlement button #28976
- Fix/ios wrong permission message #30374
- Update CONSTS to direct developers to use role instead of accessibilityRole #31590
- [TS migration] Migrate 'Indicator.js' component to TypeScript #31713
- [NO QA] update wallet banner UI, wallet red dot condition #32106
- Feature: refactor requiresAttentionFromCurrentUser function #32140
- Add desktop's
app://-/origin to linking prefixes #32158 - [TS Migration] migrate MapView component to TypeScript #32186
- [TS migration] Migrate 'ReportActionItemGrouped.js' component to TypeScript #32192
- [TS migration] Migrate 'WalletSection.js' component to TypeScript #32197
- [NoQA] change performance tests workflow #32265
- [Form Provider Refactor] AddressForm and AddressPage #32276
- Fix beneficial owner form is not shown after revisiting the page #32278
- [Wave 6: Referral Program] Promote referral program messaging in NewDot Redesign the Referral page #32362
- Fix task title escaping #32364
- Add validation error for category #32394
- fix: sort participant avatars by its accountID #32419
- Update Domains-Overview.md #32420
- using isLoadingApp instead of isLoadingReportData #32465
- Fix:
GetAssistancepage does not navigate back properly after reloading #32466 - [TS migration] Migrate 'InlineCodeBlock' component to TypeScript #32477
- Delete docs/articles/expensify-classic/getting-started/Mobile-App.md #32493
- Delete docs/articles/expensify-classic/bank-accounts-and-credit-cards… #32494
- Delete docs/articles/expensify-classic/account-settings/Profile-Setti… #32495
- Fix/ Chat - WS custom avatar is not updated in chat conversation after request money #32546
- [TS migration] Migrate 'CardPreview.js' component to TypeScript #32570
- Update Request-Money.md #32580
- Updating colors for the Help Site, add fine print to footer #32586
- IOU - Back button unresponsive on touches on IOU details page in offline #32592
- fix: translate channel log #32612
- Fix tooltip doesn't show on a mention with a user we never chat before #32632
- Update inline code replace regex to not include code block #32639
- Fix the current issue and regression #32647
- Remove the hasOutstandingIOU key #32653
- Migrate QRShare to function component #32690
- Add optimistic violations data to deleteMoneyRequest #32696
- Fix/31730: Remove green dot after deleting the Money request #32707
- [Snyk] Upgrade electron-updater from 6.1.4 to 6.1.6 #32723
- Fix text selection in composer disappears after dragging it over the FAB #32772
- Fix modifying workspace distance rate with an old data doesn't show an error #32773
- Fix: Use TaskUtils for copying the task report actions to clipboard #32774
- Fix loggedInDuringSession logic #32775
- Feat/29780/hide list while initial scrolling #32777
- Move Referral article to get paid back #32787
- Create personal detail optimistic data when inviting member to the room #32788
- Fix/32080: Referral button is not focused #32790
- Add budget policy changelogs actions #32803
- [NoQA] Remove remaining paypal keys #32805
- fix "Split scan - Unable to select workspace as recipient when creating split scan in WS chat" #32830
- Hide Members option from non-workspace member #32857
- [NoQA] Sync clock on setupGitForOSBotifyApp / remove old action #32859
- Add missing import to unblock native staging build testing #32925
- [CP Staging] Fix greyed out workspace icon for workspace distance requests #33005
- [CP Staging] Fix for - Unable to leave public room #33053
Deploy Blockers:
- [HOLD for payment 2023-12-20] [$500] Desktop - Expired magic code page for a valid code with no prior use + inability to exit the screen #32795
- [$500] Wallet-Tapping "Enable wallet",add bank account page with select Chase is displayed. #32906
- [HOLD for payment 2024-03-07] [LOW] [P2P] [$500] IOU-Add a contact to request money and tap back button, contact added to split. #32912
- [HOLD for payment 2023-12-26] [$500] Web - Chat - Workspace avatar is greyed out in the conversation report preview #32984
- [$500] Thread - App crashes when leaving thread #33009
- [HOLD for payment 2023-12-26] Room - Unable to leave public room #33010
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01ad8b114ce89fa5e6
- Upwork Job ID: 1735306198742843392
- Last Price Increase: 2023-12-14
Metadata
Metadata
Assignees
Labels
DailyKSv2KSv2ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsApply this label when an issue is open to proposals by contributorsStagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Activity
OSBotify commentedon Dec 13, 2023
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.12-0 🚀
luacmartins commentedon Dec 13, 2023
Checking off #32803. Will be tested with https://github.com/Expensify/Web-Expensify/pull/39897
luacmartins commentedon Dec 13, 2023
Checking off #32795, #32906, #32912. They were in the previous checklist and got fixed, we just never removed the label.
kavimuru commentedon Dec 14, 2023
Regression is 72% progress.
#32394 failing with existing issue #30683 (checking it off)
#32362 failing with existing issue #32874 (checking it off)
Julesssss commentedon Dec 14, 2023
Checking off #32106 as this is internal testing only
Julesssss commentedon Dec 14, 2023
#32592 is testing well for me on
1.4.12-0, checking off. Fixed by #32408Julesssss commentedon Dec 14, 2023
Checked off #32857
kavimuru commentedon Dec 14, 2023
Regression is completed.
Waiting for the build release to validate the cp #33053
Julesssss commentedon Dec 14, 2023
#33005 was cherry-picked to resolve #32984
#33053 was cherry-picked to resolve #33009 & #33010
[-]Deploy Checklist: New Expensify 2023-12-13[/-][+][$500] Deploy Checklist: New Expensify 2023-12-13[/+]melvin-bot commentedon Dec 14, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01ad8b114ce89fa5e6
Julesssss commentedon Dec 14, 2023
QA is complete
Julesssss commentedon Dec 14, 2023
Checking off #33009 & #33010
Julesssss commentedon Dec 14, 2023
RangeError: Invalid time valueexception that occurs in prev versions🚀
Julesssss commentedon Dec 14, 2023