Skip to content

[$500] Android - Workspace - Gap between the dots and the admin tag is big, name is very cut off #33542

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Found when executing PR: #33293

Version Number: v1.4.16-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

  1. Open the App
  2. Login with any account
  3. Go to Settings -> Workspace -> Open any WS -> Member
  4. Notice that the gap between the dots and the admin tag is big, name is very cut off

Expected Result:

Gap between the dots and the admin tag is not so big, name is not cut off so much

Actual Result:

Gap between the dots and the admin tag is big, name is very cut off

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6324799_1703324917429.Record_2023-12-22-21-24-25_4f9154176b47c00da84e32064abf1c48.mp4

Bug6324799_1703324917413!Screenshot_2023-12-22-21-24-20-72_4f9154176b47c00da84e32064abf1c48

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017b6f39b9a20b0de4
  • Upwork Job ID: 1738521163245367297
  • Last Price Increase: 2023-12-30
  • Automatic offers:
    • aswin-s | Contributor | 28089976

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 23, 2023
  2. changed the title [-]Android - Workspace - Gap between the dots and the admin tag is big, name is very cut off[/-] [+][$500] Android - Workspace - Gap between the dots and the admin tag is big, name is very cut off[/+] on Dec 23, 2023
  3. melvin-bot commented on Dec 23, 2023

    @melvin-bot
  4. melvin-bot commented on Dec 23, 2023

    @melvin-bot

    Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  5. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 23, 2023
  6. melvin-bot commented on Dec 23, 2023

    @melvin-bot

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
  7. melvin-bot commented on Dec 23, 2023

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

  8. aswin-s commented on Dec 23, 2023

    @aswin-s
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Admin name label on Workspace invite member page is not taking full width

    What is the root cause of that problem?

    UserListItem component has a container with flex direction set as column and alignItems property set to flexStart. This causes child elements to not fill the entire width.

    <View style={[styles.flex1, styles.flexColumn, styles.justifyContentCenter, styles.alignItemsStart, styles.optionRow]}>

    What changes do you think we should make in order to solve the problem?

    Set alignItems style of container to alignItemsStretch. This will cause all child elements to stretch to full width of the parent and use the available width.

    <View style={[styles.flex1, styles.flexColumn, styles.justifyContentCenter, styles.alignItemsStretch, styles.optionRow]}>
    

    Result

    Before After
    Screenshot_1703333139 Screenshot_1703333170

    What alternative solutions did you explore? (Optional)

    None (edited)

  9. melvin-bot commented on Dec 26, 2023

    @melvin-bot

    @anmurali, @sobitneupane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  10. melvin-bot commented on Dec 28, 2023

    @melvin-bot

    @anmurali, @sobitneupane Huh... This is 4 days overdue. Who can take care of this?

  11. 13 remaining items

  12. roryabraham commented on Jan 9, 2024

    @roryabraham
    Contributor

    Minor piece of advice @aswin-s – if you put before/after screenshots in a table they become much easier to look at 🙂

    Before After
    Screenshot_1703333139 Screenshot_1703333170

    Or replace the ![Screenshot](url) with a <img src="url" alt="" width="350px" />, that works too if the table makes things too small.

  13. added
    ReviewingHas a PR in review
    and removed on Jan 9, 2024
  14. aswin-s commented on Jan 18, 2024

    @aswin-s
    Contributor

    @sobitneupane Could you please have a look at the PR?

  15. sobitneupane commented on Jan 24, 2024

    @sobitneupane
    Contributor

    Sorry for the delay @aswin-s. I will try to get to it asap. But I will have to ask you to wait for 1 day or 2 days. I am working partially and it's not a high priority issue.

  16. mkhutornyi commented on Feb 2, 2024

    @mkhutornyi
    Contributor

    This caused regression - #35691

  17. aswin-s commented on Feb 13, 2024

    @aswin-s
    Contributor

    PR got deployed to prod last week. However the status is not updated here.

  18. aswin-s commented on Feb 16, 2024

    @aswin-s
    Contributor

    @anmurali Gentle Reminder ☝️

  19. anmurali commented on Feb 16, 2024

    @anmurali

    Payment Summary:

  20. JmillsExpensify commented on Mar 12, 2024

    @JmillsExpensify
    Contributor

    $500 approved for @sobitneupane based on summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions