You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] Android - Workspace - Gap between the dots and the admin tag is big, name is very cut off #33542
Version Number: v1.4.16-4 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause-Internal Team Slack conversation: @
Action Performed:
Open the App
Login with any account
Go to Settings -> Workspace -> Open any WS -> Member
Notice that the gap between the dots and the admin tag is big, name is very cut off
Expected Result:
Gap between the dots and the admin tag is not so big, name is not cut off so much
Actual Result:
Gap between the dots and the admin tag is big, name is very cut off
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
changed the title [-]Android - Workspace - Gap between the dots and the admin tag is big, name is very cut off[/-][+][$500] Android - Workspace - Gap between the dots and the admin tag is big, name is very cut off[/+]on Dec 23, 2023
Please re-state the problem that we are trying to solve in this issue.
Admin name label on Workspace invite member page is not taking full width
What is the root cause of that problem?
UserListItem component has a container with flex direction set as column and alignItems property set to flexStart. This causes child elements to not fill the entire width.
What changes do you think we should make in order to solve the problem?
Set alignItems style of container to alignItemsStretch. This will cause all child elements to stretch to full width of the parent and use the available width.
Sorry for the delay @aswin-s. I will try to get to it asap. But I will have to ask you to wait for 1 day or 2 days. I am working partially and it's not a high priority issue.
Activity
[-]Android - Workspace - Gap between the dots and the admin tag is big, name is very cut off[/-][+][$500] Android - Workspace - Gap between the dots and the admin tag is big, name is very cut off[/+]melvin-bot commentedon Dec 23, 2023
Job added to Upwork: https://www.upwork.com/jobs/~017b6f39b9a20b0de4
melvin-bot commentedon Dec 23, 2023
Triggered auto assignment to @anmurali (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Dec 23, 2023
Bug0 Triage Checklist (Main S/O)
Platformsin OP are ✅)melvin-bot commentedon Dec 23, 2023
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (
External)aswin-s commentedon Dec 23, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
Admin name label on Workspace invite member page is not taking full width
What is the root cause of that problem?
UserListItem component has a container with flex direction set as column and alignItems property set to flexStart. This causes child elements to not fill the entire width.
App/src/components/SelectionList/UserListItem.js
Line 21 in b74be72
What changes do you think we should make in order to solve the problem?
Set alignItems style of container to
alignItemsStretch. This will cause all child elements to stretch to full width of the parent and use the available width.Result
What alternative solutions did you explore? (Optional)
None (edited)
melvin-bot commentedon Dec 26, 2023
@anmurali, @sobitneupane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Dec 28, 2023
@anmurali, @sobitneupane Huh... This is 4 days overdue. Who can take care of this?
13 remaining items
roryabraham commentedon Jan 9, 2024
Minor piece of advice @aswin-s – if you put before/after screenshots in a table they become much easier to look at 🙂
Or replace the
with a<img src="url" alt="" width="350px" />, that works too if the table makes things too small.aswin-s commentedon Jan 18, 2024
@sobitneupane Could you please have a look at the PR?
sobitneupane commentedon Jan 24, 2024
Sorry for the delay @aswin-s. I will try to get to it asap. But I will have to ask you to wait for 1 day or 2 days. I am working partially and it's not a high priority issue.
mkhutornyi commentedon Feb 2, 2024
This caused regression - #35691
aswin-s commentedon Feb 13, 2024
PR got deployed to prod last week. However the status is not updated here.
aswin-s commentedon Feb 16, 2024
@anmurali Gentle Reminder ☝️
anmurali commentedon Feb 16, 2024
Payment Summary:
JmillsExpensify commentedon Mar 12, 2024
$500 approved for @sobitneupane based on summary.