Skip to content

[$500] [HOLD for payment 2024-01-18] Web - Double <Payer:> for IOU report preview in Search #33760

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.19-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. [User A] Request money from User B.
  2. [User B] Pay the request.
  3. [User A] Click on the IOU preview to open IOU report.
  4. [User A] Click Search icon.
  5. Note that the IOU report shows double Payer: in the preview in Search list.

Expected Result:

Single Payer: for IOU report preview in Search

Actual Result:

Double Payer: for IOU report preview in Search

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screenshot 2023-12-29 at 22 37 08

20231229_223646.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016165d0cee06c5ac9
  • Upwork Job ID: 1748381394601844736
  • Last Price Increase: 2024-01-19

Activity

  1. github-actions commented on Dec 29, 2023

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Dec 29, 2023

    @melvin-bot

    Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. kbecciv commented on Dec 29, 2023

    @kbecciv
    Author

    Issue is not Reproduced on production

    Screenshot 2023-12-29 at 22 44 08

  4. paultsimura commented on Dec 29, 2023

    @paultsimura
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    What is the root cause of that problem?

    We prepend the payer name twice:

    App/src/libs/ReportUtils.ts

    Lines 2029 to 2032 in 8432563

    const actualPayerName = report.managerID === currentUserAccountID ? '' : `${getDisplayNameForParticipant(report.managerID, true)}:`;
    const payerDisplayName = isPreviewMessageForParentChatReport ? payerName : actualPayerName;
    return Localize.translateLocal(translatePhraseKey, {amount: formattedAmount, payer: payerDisplayName ?? ''});

    And:

    const lastMessageTextFromReport = getLastMessageTextForReport(report);
    const lastActorDetails = personalDetailMap[report.lastActorAccountID] || null;
    const lastActorDisplayName =
    hasMultipleParticipants && lastActorDetails && lastActorDetails.accountID !== currentUserAccountID ? lastActorDetails.firstName || lastActorDetails.displayName : '';
    let lastMessageText = lastActorDisplayName ? `${lastActorDisplayName}: ${lastMessageTextFromReport}` : lastMessageTextFromReport;

    What changes do you think we should make in order to solve the problem?

    Since the lastMessageTextFromReport has changed for the money reports to include the payer name, we should handle this case and set result.alternateText to only lastMessageTextFromReport, not lastMessageText for such options.

    We currently do similar thing for tasks:

    } else if (result.isTaskReport) {
    result.alternateText = showChatPreviewLine && lastMessageText ? lastMessageTextFromReport : Localize.translate(preferredLocale, 'report.noActivityYet');
    } else {

    What alternative solutions did you explore? (Optional)

  5. mountiny commented on Dec 29, 2023

    @mountiny
    Contributor

    I think this was known and wanted to address in a follow up @koko57

  6. koko57 commented on Dec 29, 2023

    @koko57
    Contributor

    It was occuring long before the merge and I found it while I was working on it (it was spotted by me on staging) #30042 (comment)

    it displayed [firstName lastName]: [firstName]: but after my changes I had to make for LHN it displays firstName doubled. We agreed that it will be fixed in a separate PR

  7. 40 remaining items

  8. situchan commented on Jan 18, 2024

    @situchan
    Contributor

    BZ Checklist:
    Offending PR: #33346, though the root cause already existed - #33760 (comment)
    As this was caught during staging regression testing, no need new regression test.
    To prevent such bugs further, we decided to make LHN and search logic consistent as follow-up here


    @situchan Can you complete the checklist here? this was a simple follow up to previou PR, I feel like the reward should be $250 for this one

    I'm fine with any reward change but does that mean that now we have the right to request bounty increase for reviewing large PRs? For me, some PRs took several days to complete review.
    I thought they were flatten no matter small or large PR, as they're balanced eventually.

    PS: #33371 was just console log change PR and fully rewarded here

  9. mountiny commented on Jan 18, 2024

    @mountiny
    Contributor

    I'm fine with any reward change but does that mean that now we have the right to request bounty increase for reviewing large PRs? For me, some PRs took several days to complete review. I thought they were flatten no matter small or large PR, as they're balanced eventually.

    PS: #33371 was just console log change PR and fully rewarded #33478 (comment)

    Yeah I see your point, lets keep it $500 then.

    I think the root cause is that we should get the same C+ review the clean up PRs too as in this case it was a regression from PR reviewed by another C+ so then we end up paying more in total for one task

  10. michaelhaxhiu commented on Jan 19, 2024

    @michaelhaxhiu
    Contributor

    Yeah I see your point, lets keep it $500 then.

    Sounds like we arrived at $500 standard rate for this PR review! I will make an upwork job now for it.

    I thought they were flatten no matter small or large PR, as they're balanced eventually.

    FWIW -- what you described here is indeed the core idea at play for the bounty methodology. It's a pay rate that is intended to be more than fair in the grand scheme of being a C+, unless a specific PR is a HUGE deviation from the typical workload and deserves a one-off consideration.

  11. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Jan 19, 2024
  12. changed the title [-][HOLD for payment 2024-01-18] Web - Double <Payer:> for IOU report preview in Search[/-] [+][$500] [HOLD for payment 2024-01-18] Web - Double <Payer:> for IOU report preview in Search[/+] on Jan 19, 2024
  13. melvin-bot commented on Jan 19, 2024

    @melvin-bot
  14. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 19, 2024
  15. removed
    ExternalAdded to denote the issue can be worked on by a contributor
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 19, 2024
  16. melvin-bot commented on Jan 19, 2024

    @melvin-bot

    Current assignee @situchan is eligible for the External assigner, not assigning anyone new.

  17. situchan commented on Jan 19, 2024

    @situchan
    Contributor

    @michaelhaxhiu after making External, if you unassign me and reassign, I will get offer

  18. michaelhaxhiu commented on Jan 19, 2024

    @michaelhaxhiu
    Contributor

    I just sent you an offer actually. But that's a good reminder of how to use the automation

  19. michaelhaxhiu commented on Jan 19, 2024

    @michaelhaxhiu
    Contributor

    paid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions