You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] [HOLD for payment 2024-01-18] Web - Double <Payer:> for IOU report preview in Search #33760
Version Number: v1.4.19-0 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
[User A] Request money from User B.
[User B] Pay the request.
[User A] Click on the IOU preview to open IOU report.
[User A] Click Search icon.
Note that the IOU report shows double Payer: in the preview in Search list.
Expected Result:
Single Payer: for IOU report preview in Search
Actual Result:
Double Payer: for IOU report preview in Search
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
What changes do you think we should make in order to solve the problem?
Since the lastMessageTextFromReport has changed for the money reports to include the payer name, we should handle this case and set result.alternateText to only lastMessageTextFromReport, not lastMessageText for such options.
It was occuring long before the merge and I found it while I was working on it (it was spotted by me on staging) #30042 (comment)
it displayed [firstName lastName]: [firstName]: but after my changes I had to make for LHN it displays firstName doubled. We agreed that it will be fixed in a separate PR
BZ Checklist:
Offending PR: #33346, though the root cause already existed - #33760 (comment)
As this was caught during staging regression testing, no need new regression test.
To prevent such bugs further, we decided to make LHN and search logic consistent as follow-up here
@situchan Can you complete the checklist here? this was a simple follow up to previou PR, I feel like the reward should be $250 for this one
I'm fine with any reward change but does that mean that now we have the right to request bounty increase for reviewing large PRs? For me, some PRs took several days to complete review.
I thought they were flatten no matter small or large PR, as they're balanced eventually.
PS: #33371 was just console log change PR and fully rewarded here
I'm fine with any reward change but does that mean that now we have the right to request bounty increase for reviewing large PRs? For me, some PRs took several days to complete review. I thought they were flatten no matter small or large PR, as they're balanced eventually.
I think the root cause is that we should get the same C+ review the clean up PRs too as in this case it was a regression from PR reviewed by another C+ so then we end up paying more in total for one task
Sounds like we arrived at $500 standard rate for this PR review! I will make an upwork job now for it.
I thought they were flatten no matter small or large PR, as they're balanced eventually.
FWIW -- what you described here is indeed the core idea at play for the bounty methodology. It's a pay rate that is intended to be more than fair in the grand scheme of being a C+, unless a specific PR is a HUGE deviation from the typical workload and deserves a one-off consideration.
changed the title [-][HOLD for payment 2024-01-18] Web - Double <Payer:> for IOU report preview in Search[/-][+][$500] [HOLD for payment 2024-01-18] Web - Double <Payer:> for IOU report preview in Search[/+]on Jan 19, 2024
Activity
github-actions commentedon Dec 29, 2023
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Dec 29, 2023
Triggered auto assignment to @cead22 (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.kbecciv commentedon Dec 29, 2023
Issue is not Reproduced on production
paultsimura commentedon Dec 29, 2023
Proposal
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
We prepend the payer name twice:
App/src/libs/ReportUtils.ts
Lines 2029 to 2032 in 8432563
And:
App/src/libs/OptionsListUtils.js
Lines 512 to 516 in 9692e48
What changes do you think we should make in order to solve the problem?
Since the lastMessageTextFromReport has changed for the money reports to include the payer name, we should handle this case and set
result.alternateTextto onlylastMessageTextFromReport, notlastMessageTextfor such options.We currently do similar thing for tasks:
App/src/libs/OptionsListUtils.js
Lines 532 to 534 in 9692e48
What alternative solutions did you explore? (Optional)
mountiny commentedon Dec 29, 2023
I think this was known and wanted to address in a follow up @koko57
koko57 commentedon Dec 29, 2023
It was occuring long before the merge and I found it while I was working on it (it was spotted by me on staging) #30042 (comment)
it displayed [firstName lastName]: [firstName]: but after my changes I had to make for LHN it displays firstName doubled. We agreed that it will be fixed in a separate PR
40 remaining items
situchan commentedon Jan 18, 2024
BZ Checklist:
Offending PR: #33346, though the root cause already existed - #33760 (comment)
As this was caught during staging regression testing, no need new regression test.
To prevent such bugs further, we decided to make LHN and search logic consistent as follow-up here
I'm fine with any reward change but does that mean that now we have the right to request bounty increase for reviewing large PRs? For me, some PRs took several days to complete review.
I thought they were flatten no matter small or large PR, as they're balanced eventually.
PS: #33371 was just console log change PR and fully rewarded here
mountiny commentedon Jan 18, 2024
Yeah I see your point, lets keep it $500 then.
I think the root cause is that we should get the same C+ review the clean up PRs too as in this case it was a regression from PR reviewed by another C+ so then we end up paying more in total for one task
michaelhaxhiu commentedon Jan 19, 2024
Sounds like we arrived at $500 standard rate for this PR review! I will make an upwork job now for it.
FWIW -- what you described here is indeed the core idea at play for the bounty methodology. It's a pay rate that is intended to be more than fair in the grand scheme of being a C+, unless a specific PR is a HUGE deviation from the typical workload and deserves a one-off consideration.
[-][HOLD for payment 2024-01-18] Web - Double <Payer:> for IOU report preview in Search[/-][+][$500] [HOLD for payment 2024-01-18] Web - Double <Payer:> for IOU report preview in Search[/+]melvin-bot commentedon Jan 19, 2024
Job added to Upwork: https://www.upwork.com/jobs/~016165d0cee06c5ac9
melvin-bot commentedon Jan 19, 2024
Current assignee @situchan is eligible for the External assigner, not assigning anyone new.
situchan commentedon Jan 19, 2024
@michaelhaxhiu after making External, if you unassign me and reassign, I will get offer
michaelhaxhiu commentedon Jan 19, 2024
I just sent you an offer actually. But that's a good reminder of how to use the automation
michaelhaxhiu commentedon Jan 19, 2024
paid