Skip to content

[HOLD for payment 2024-03-13] [MEDIUM] Follow-ups to the LHN previews #34411

Closed

Description

@koko57

Coming from: #30042

Tracking issue listing all of the issues that should be addressed in the follow-ups:

Ideas for other improvements:

  • move getting lastActor / actor display name to a separate function, try to move it out the functions called in getLastMessageTextForReport (create message text and get actor name separately then combine it)
  • getReportPreviewMessage - pass an object with params instead of comma separated params
Issue OwnerCurrent Issue Owner: @adelekennedy

Activity

  1. koko57 commented on Jan 12, 2024

    @koko57
    ContributorAuthor
  2. koko57 commented on Jan 17, 2024

    @koko57
    ContributorAuthor

    working on this one - I've extracted the logic into a separate function, but it's still WIP

  3. mountiny commented on Jan 18, 2024

    @mountiny
    Contributor

    Thanks!

  4. koko57 commented on Jan 22, 2024

    @koko57
    ContributorAuthor

    @mountiny the function I extracted still had some problems. I thought that it would be maybe better to divide this refactor into smaller steps. First one - I created a function for getting lastActorName. I also moved the logic for creating alternate text for archived room to getLastMessageTextForReport - I think we should move as much logic for alternateText as possible there.

    Let me know what you think about it and if I can open this PR for the review

  5. koko57 commented on Jan 23, 2024

    @koko57
    ContributorAuthor

    @mountiny just to make sure it's an expected behaviour (found it on staging, after applying the changes it's still the same):
    on the Search Page for archived rooms (workspace chats) we're displaying the reason for the member (pink underline), but a "Workspace" for the admin (blue unedrline). On LHN we're displaying the reason both for the member and the admin. Is that correct?
    Screenshot 2024-01-23 at 15 01 12

  6. mountiny commented on Jan 23, 2024

    @mountiny
    Contributor

    Hmm I would say this should be same for user and the admin

  7. trjExpensify commented on Jan 23, 2024

    @trjExpensify
    Contributor

    In search results, the workspace chat should be:

    Admin/other participants

    Tom Rhys Jones
    Duraflame, Inc.

    Member

    Duraflame, Inc.
    Workspace

  8. trjExpensify commented on Jan 23, 2024

    @trjExpensify
    Contributor

    @mountiny Nikki reported this here, but there hasn't been an issue created for it yet.

  9. mountiny commented on Jan 23, 2024

    @mountiny
    Contributor

    @trjExpensify So the fix is the other way we should not show the archive reason for any of them, right?

  10. 70 remaining items

  11. melvin-bot commented on Mar 13, 2024

    @melvin-bot
  12. melvin-bot commented on Mar 13, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    • Reviewer: @mananjadhav owed $500 via NewDot
    • Contributor: @koko57 is from an agency-contributor and not due payment

    BugZero Checklist (@adelekennedy)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  13. mananjadhav commented on Mar 13, 2024

    @mananjadhav
    Collaborator

    @mananjadhav Can you please help me with the payment summary here?

    @mountiny This got posted by the bot, is there anything else needed from me here? I can see multiple PRs previously here, and each of them has C+ assigned.

  14. mananjadhav commented on Mar 15, 2024

    @mananjadhav
    Collaborator

    quick bump here @mountiny. Meanwhile I am requesting my payout on the NewDot. Would be great if you can confirm the summary.

  15. mountiny commented on Mar 15, 2024

    @mountiny
    Contributor

    @mananjadhav could you actually help me list out the PRs?

  16. mananjadhav commented on Mar 17, 2024

    @mananjadhav
    Collaborator

    @mountiny I can see 4 PRs overall linked with this issue:

    @eVoloshchak reviewed the following, not sure if these are paid out. But both of them are merged more than a month ago:

    @situchan reviewed #35818, for which they're already paid.

    I (@mananjadhav) reviewed #36591

  17. mountiny commented on Mar 18, 2024

    @mountiny
    Contributor

    I believe @eVoloshchak was not paid out but the two PRs were one original and second a regression fix. So I would say the payout would be $500 to @eVoloshchak

    For @mananjadhav I assume classic $500 then.

    Sounds good?

  18. mananjadhav commented on Mar 18, 2024

    @mananjadhav
    Collaborator

    Sounds good. @mountiny

  19. JmillsExpensify commented on Mar 18, 2024

    @JmillsExpensify
    Contributor

    $500 approved for @mananjadhav based on summary.

  20. adelekennedy commented on Mar 18, 2024

    @adelekennedy
    Contributor

    @eVoloshchak based on the above I sent you a contract on Upwork

  21. eVoloshchak commented on Mar 19, 2024

    @eVoloshchak
    Contributor

    @adelekennedy, thanks! No need for Upwork though, I've just requested the payment via NewDot

  22. JmillsExpensify commented on Mar 22, 2024

    @JmillsExpensify
    Contributor

    $500 approved for @eVoloshchak based on summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionNewFeatureSomething to build that is a new item.TaskWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions