You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-03-13] [MEDIUM] Follow-ups to the LHN previews #34411
Do not show description for multiple request chat (reference)
Ideas for other improvements:
move getting lastActor / actor display name to a separate function, try to move it out the functions called in getLastMessageTextForReport (create message text and get actor name separately then combine it)
getReportPreviewMessage - pass an object with params instead of comma separated params
@mountiny the function I extracted still had some problems. I thought that it would be maybe better to divide this refactor into smaller steps. First one - I created a function for getting lastActorName. I also moved the logic for creating alternate text for archived room to getLastMessageTextForReport - I think we should move as much logic for alternateText as possible there.
Let me know what you think about it and if I can open this PR for the review
@mountiny just to make sure it's an expected behaviour (found it on staging, after applying the changes it's still the same):
on the Search Page for archived rooms (workspace chats) we're displaying the reason for the member (pink underline), but a "Workspace" for the admin (blue unedrline). On LHN we're displaying the reason both for the member and the admin. Is that correct?
@mananjadhav Can you please help me with the payment summary here?
@mountiny This got posted by the bot, is there anything else needed from me here? I can see multiple PRs previously here, and each of them has C+ assigned.
I believe @eVoloshchak was not paid out but the two PRs were one original and second a regression fix. So I would say the payout would be $500 to @eVoloshchak
Activity
koko57 commentedon Jan 12, 2024
cc @mountiny
koko57 commentedon Jan 17, 2024
working on this one - I've extracted the logic into a separate function, but it's still WIP
mountiny commentedon Jan 18, 2024
Thanks!
koko57 commentedon Jan 22, 2024
@mountiny the function I extracted still had some problems. I thought that it would be maybe better to divide this refactor into smaller steps. First one - I created a function for getting lastActorName. I also moved the logic for creating alternate text for archived room to
getLastMessageTextForReport- I think we should move as much logic for alternateText as possible there.Let me know what you think about it and if I can open this PR for the review
koko57 commentedon Jan 23, 2024
@mountiny just to make sure it's an expected behaviour (found it on staging, after applying the changes it's still the same):

on the Search Page for archived rooms (workspace chats) we're displaying the reason for the member (pink underline), but a "Workspace" for the admin (blue unedrline). On LHN we're displaying the reason both for the member and the admin. Is that correct?
mountiny commentedon Jan 23, 2024
Hmm I would say this should be same for user and the admin
trjExpensify commentedon Jan 23, 2024
In search results, the workspace chat should be:
Admin/other participants
Member
trjExpensify commentedon Jan 23, 2024
@mountiny Nikki reported this here, but there hasn't been an issue created for it yet.
mountiny commentedon Jan 23, 2024
@trjExpensify So the fix is the other way we should not show the archive reason for any of them, right?
70 remaining items
melvin-bot commentedon Mar 13, 2024
Triggered auto assignment to @adelekennedy (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.melvin-bot commentedon Mar 13, 2024
Payment Summary
Upwork Job
BugZero Checklist (@adelekennedy)
mananjadhav commentedon Mar 13, 2024
@mountiny This got posted by the bot, is there anything else needed from me here? I can see multiple PRs previously here, and each of them has C+ assigned.
mananjadhav commentedon Mar 15, 2024
quick bump here @mountiny. Meanwhile I am requesting my payout on the NewDot. Would be great if you can confirm the summary.
mountiny commentedon Mar 15, 2024
@mananjadhav could you actually help me list out the PRs?
mananjadhav commentedon Mar 17, 2024
@mountiny I can see 4 PRs overall linked with this issue:
@eVoloshchak reviewed the following, not sure if these are paid out. But both of them are merged more than a month ago:
@situchan reviewed #35818, for which they're already paid.
I (@mananjadhav) reviewed #36591
mountiny commentedon Mar 18, 2024
I believe @eVoloshchak was not paid out but the two PRs were one original and second a regression fix. So I would say the payout would be $500 to @eVoloshchak
For @mananjadhav I assume classic $500 then.
Sounds good?
mananjadhav commentedon Mar 18, 2024
Sounds good. @mountiny
JmillsExpensify commentedon Mar 18, 2024
$500 approved for @mananjadhav based on summary.
adelekennedy commentedon Mar 18, 2024
@eVoloshchak based on the above I sent you a contract on Upwork
eVoloshchak commentedon Mar 19, 2024
@adelekennedy, thanks! No need for Upwork though, I've just requested the payment via NewDot
JmillsExpensify commentedon Mar 22, 2024
$500 approved for @eVoloshchak based on summary.