Skip to content

Expense - LHN preview for request report shows owner name next to request edit system message #35515

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.34-0
Reproducible in staging?: yes
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Precondition: User is an employee of Collect workspace on Old Dot.

  1. Create a distance request in the workspace chat.
  2. Go to distance request details page.
  3. Go offline.
  4. Click Description.
  5. Edit the description and save it.
  6. Note that the LHN preview shows the owner name.
  7. Go online.

Expected Result:

In Step 6, LHN preview for the expense details report will not show the owner name (current user) next to the system message.

Actual Result:

In Step 6, LHN preview for the expense details report shows the owner name next to the system message.
The owner name disappears after returning online in Step 7.
The issue is reproducible without going online. In that case, the owner name appears and disappears quickly.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6362826_1706731589781.bandicam_2024-02-01_01-35-17-104.mp4

View all open jobs on GitHub

Activity

  1. github-actions commented on Jan 31, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Jan 31, 2024

    @melvin-bot

    Triggered auto assignment to @blimpich (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. kbecciv commented on Jan 31, 2024

    @kbecciv
    Author

    We think that this bug might be related to #wave6-collect-submitters
    CC @dylanexpensify

  4. blimpich commented on Jan 31, 2024

    @blimpich
    Contributor

    This isn't a blocker, too niche, should be solved though.

  5. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Jan 31, 2024
  6. blimpich commented on Jan 31, 2024

    @blimpich
    Contributor

    Looks like #34872 might be PR that caused this? @koko57 could you take a look and confirm or deny?

  7. koko57 commented on Feb 1, 2024

    @koko57
    Contributor

    @blimpich not sure if this one or the previous one I was working on a while ago. I'm still working on LHN previews follow-ups - I can fix this issue while working on the next PR 🙂

  8. blimpich commented on Feb 5, 2024

    @blimpich
    Contributor

    @koko57 sounds good, thank you! Is there already an issue and reviewer for that next PR or do you think I should mark this as external, get a C+ reviewer for it, and assign you to this issue? I'm fine either way.

  9. koko57 commented on Feb 5, 2024

    @koko57
    Contributor

    @blimpich I can do this as a part of LHN follow-ups issue

    cc @mountiny

  10. mountiny commented on Feb 5, 2024

    @mountiny
    Contributor

    We can handle it there or here @blimpich whatever you prefer, I can copy over this issue to the list in that linked PR. What do you think?

  11. blimpich commented on Feb 5, 2024

    @blimpich
    Contributor

    @mountiny copying it over to the linked PR sounds perfect to me, thank you both!

  12. mountiny commented on Feb 6, 2024

    @mountiny
    Contributor

    Added, thanks!

  13. added
    ReviewingHas a PR in review
    and removed on Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions