You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Expense - LHN preview for request report shows owner name next to request edit system message #35515
Version Number: v1.4.34-0 Reproducible in staging?: yes Reproducible in production?: no If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
Precondition: User is an employee of Collect workspace on Old Dot.
Create a distance request in the workspace chat.
Go to distance request details page.
Go offline.
Click Description.
Edit the description and save it.
Note that the LHN preview shows the owner name.
Go online.
Expected Result:
In Step 6, LHN preview for the expense details report will not show the owner name (current user) next to the system message.
Actual Result:
In Step 6, LHN preview for the expense details report shows the owner name next to the system message.
The owner name disappears after returning online in Step 7.
The issue is reproducible without going online. In that case, the owner name appears and disappears quickly.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@blimpich not sure if this one or the previous one I was working on a while ago. I'm still working on LHN previews follow-ups - I can fix this issue while working on the next PR 🙂
@koko57 sounds good, thank you! Is there already an issue and reviewer for that next PR or do you think I should mark this as external, get a C+ reviewer for it, and assign you to this issue? I'm fine either way.
Activity
github-actions commentedon Jan 31, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Jan 31, 2024
Triggered auto assignment to @blimpich (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.kbecciv commentedon Jan 31, 2024
We think that this bug might be related to #wave6-collect-submitters
CC @dylanexpensify
blimpich commentedon Jan 31, 2024
This isn't a blocker, too niche, should be solved though.
blimpich commentedon Jan 31, 2024
Looks like #34872 might be PR that caused this? @koko57 could you take a look and confirm or deny?
koko57 commentedon Feb 1, 2024
@blimpich not sure if this one or the previous one I was working on a while ago. I'm still working on LHN previews follow-ups - I can fix this issue while working on the next PR 🙂
blimpich commentedon Feb 5, 2024
@koko57 sounds good, thank you! Is there already an issue and reviewer for that next PR or do you think I should mark this as external, get a C+ reviewer for it, and assign you to this issue? I'm fine either way.
koko57 commentedon Feb 5, 2024
@blimpich I can do this as a part of LHN follow-ups issue
cc @mountiny
mountiny commentedon Feb 5, 2024
We can handle it there or here @blimpich whatever you prefer, I can copy over this issue to the list in that linked PR. What do you think?
blimpich commentedon Feb 5, 2024
@mountiny copying it over to the linked PR sounds perfect to me, thank you both!
mountiny commentedon Feb 6, 2024
Added, thanks!