Skip to content

CRITICAL: Kill areChatRoomsEnabled beta everywhere #33806

Closed

Description

@quinthar

Note: Decided here:

Strategy:
Not every feature is ready for a billion people to use. For this reason, we often put works in progress behind "betas" so we can test with some without risking premature exposure to others.

Problem:
While building out User Created Rooms (aka "workspace rooms"), we have hidden this functionality behind the areChatRoomsEnabled beta. This flags which specific policies are eligible to have rooms. Right now this is set as true by default for all Free workspaces, but can be set manually for others. However, at this time there's no reason to limit this to any specific workspaces, all are eligible.

Solution:
Find every instance of areChatRoomsEnabled and remove. This means:

  1. Don't set it on new Free workspaces
  2. Don't check it anywhere, on the client or server

Activity

  1. converted this from a draft issue on Dec 30, 2023
  2. added
    Hot PickReady for an engineer to pick up and run with
    on Dec 30, 2023
  3. changed the title [-]CRITICAL: Kill `defaultRooms` beta everywhere[/-] [+][HOLD] CRITICAL: Kill `defaultRooms` beta everywhere[/+] on Jan 2, 2024
  4. removed
    Hot PickReady for an engineer to pick up and run with
    on Jan 2, 2024
  5. changed the title [-][HOLD] CRITICAL: Kill `defaultRooms` beta everywhere[/-] [+][HOLD] CRITICAL: Deprecate chat betas[/+] on Jan 2, 2024
  6. changed the title [-][HOLD] CRITICAL: Deprecate chat betas[/-] [+][HOLD] CRITICAL: Kill areChatRoomsEnabled beta everywhere[/+] on Jan 3, 2024
  7. added
    Hot PickReady for an engineer to pick up and run with
    on Jan 3, 2024
  8. changed the title [-][HOLD] CRITICAL: Kill areChatRoomsEnabled beta everywhere[/-] [+][HOLD] CRITICAL: Kill `areChatRoomsEnabled` beta everywhere[/+] on Jan 3, 2024
  9. changed the title [-][HOLD] CRITICAL: Kill `areChatRoomsEnabled` beta everywhere[/-] [+]CRITICAL: Kill `areChatRoomsEnabled` beta everywhere[/+] on Jan 3, 2024
  10. self-assigned this
    on Jan 5, 2024
  11. 5 remaining items

  12. iwiznia commented on Jan 23, 2024

    @iwiznia
    Contributor

    I am so confused. I think someone re-added them for some reason?
    I checked out the commit from my PR and there's no references to areChatRoomsEnabled there 😕

  13. jasperhuangg commented on Jan 23, 2024

    @jasperhuangg
    Contributor

    @iwiznia it looks like your PR was reverted #34311

  14. jasperhuangg commented on Jan 23, 2024

    @jasperhuangg
    Contributor

    Do you want to take over on #34934 since you were assigned to this issue originally?

  15. iwiznia commented on Jan 23, 2024

    @iwiznia
    Contributor

    Well, first off, if you revert a PR, you should ping the person that created, I could've never known it was reverted otherwise.
    But more importantly, I see nowhere the reason why it was reverted.

  16. jasperhuangg commented on Jan 25, 2024

    @jasperhuangg
    Contributor

    cc @thienlnam 🙇 do you have any context as to why we had to move forward with this revert?

  17. thienlnam commented on Jan 26, 2024

    @thienlnam
    Contributor

    #34253 (comment)

    I told you here Ioni 😆
    #34253 (comment)

  18. iwiznia commented on Jan 26, 2024

    @iwiznia
    Contributor

    Ohhh, still, leaving info on the PR is always useful.

    Anyway, so can I just send this PR again as is or do we need to do something else?

  19. iwiznia commented on Feb 2, 2024

    @iwiznia
    Contributor

    ok PR sent

  20. quinthar commented on Feb 5, 2024

    @quinthar
    ContributorAuthor

    Can we close this?

  21. iwiznia commented on Feb 5, 2024

    @iwiznia
    Contributor

    No, issues get closed automatically when the corresponding PR gets deployed and the PR above is not even merged.

  22. quinthar commented on Feb 7, 2024

    @quinthar
    ContributorAuthor

    ah, what remains to be done, who is doing it, and when will it be done?

  23. iwiznia commented on Feb 8, 2024

    @iwiznia
    Contributor

    Seems the automation did not work since this was already deployed #35576 (comment) but issue was not closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Hot PickReady for an engineer to pick up and run withWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions