You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Strategy:
Not every feature is ready for a billion people to use. For this reason, we often put works in progress behind "betas" so we can test with some without risking premature exposure to others.
Problem:
While building out User Created Rooms (aka "workspace rooms"), we have hidden this functionality behind the areChatRoomsEnabled beta. This flags which specific policies are eligible to have rooms. Right now this is set as true by default for all Free workspaces, but can be set manually for others. However, at this time there's no reason to limit this to any specific workspaces, all are eligible.
Solution:
Find every instance of areChatRoomsEnabled and remove. This means:
I am so confused. I think someone re-added them for some reason?
I checked out the commit from my PR and there's no references to areChatRoomsEnabled there 😕
Well, first off, if you revert a PR, you should ping the person that created, I could've never known it was reverted otherwise.
But more importantly, I see nowhere the reason why it was reverted.
Activity
[-]CRITICAL: Kill `defaultRooms` beta everywhere[/-][+][HOLD] CRITICAL: Kill `defaultRooms` beta everywhere[/+][-][HOLD] CRITICAL: Kill `defaultRooms` beta everywhere[/-][+][HOLD] CRITICAL: Deprecate chat betas[/+][-][HOLD] CRITICAL: Deprecate chat betas[/-][+][HOLD] CRITICAL: Kill areChatRoomsEnabled beta everywhere[/+][-][HOLD] CRITICAL: Kill areChatRoomsEnabled beta everywhere[/-][+][HOLD] CRITICAL: Kill `areChatRoomsEnabled` beta everywhere[/+][-][HOLD] CRITICAL: Kill `areChatRoomsEnabled` beta everywhere[/-][+]CRITICAL: Kill `areChatRoomsEnabled` beta everywhere[/+]5 remaining items
iwiznia commentedon Jan 23, 2024
I am so confused. I think someone re-added them for some reason?
I checked out the commit from my PR and there's no references to
areChatRoomsEnabledthere 😕jasperhuangg commentedon Jan 23, 2024
@iwiznia it looks like your PR was reverted #34311
jasperhuangg commentedon Jan 23, 2024
Do you want to take over on #34934 since you were assigned to this issue originally?
iwiznia commentedon Jan 23, 2024
Well, first off, if you revert a PR, you should ping the person that created, I could've never known it was reverted otherwise.
But more importantly, I see nowhere the reason why it was reverted.
jasperhuangg commentedon Jan 25, 2024
cc @thienlnam 🙇 do you have any context as to why we had to move forward with this revert?
thienlnam commentedon Jan 26, 2024
#34253 (comment)
I told you here Ioni 😆
#34253 (comment)
iwiznia commentedon Jan 26, 2024
Ohhh, still, leaving info on the PR is always useful.
Anyway, so can I just send this PR again as is or do we need to do something else?
iwiznia commentedon Feb 2, 2024
ok PR sent
quinthar commentedon Feb 5, 2024
Can we close this?
iwiznia commentedon Feb 5, 2024
No, issues get closed automatically when the corresponding PR gets deployed and the PR above is not even merged.
quinthar commentedon Feb 7, 2024
ah, what remains to be done, who is doing it, and when will it be done?
iwiznia commentedon Feb 8, 2024
Seems the automation did not work since this was already deployed #35576 (comment) but issue was not closed