Skip to content

[CP Staging] Revert "[NO QA] Remove areChatRoomsEnabled checks" - #34311

Merged
yuwenmemon merged 1 commit into
mainfrom
revert-34046-ionatan_killareChatRoomsEnabled
Jan 11, 2024
Merged

yuwenmemon merged 1 commit into
mainfrom
revert-34046-ionatan_killareChatRoomsEnabled

Conversation

@thienlnam

Copy link
Copy Markdown
Contributor

Reverts #34046

@thienlnam
thienlnam marked this pull request as ready for review January 11, 2024 05:18
@thienlnam
thienlnam requested a review from a team as a code owner January 11, 2024 05:18
@melvin-bot
melvin-bot Bot requested review from Gonals and removed request for a team January 11, 2024 05:18
@melvin-bot

melvin-bot Bot commented Jan 11, 2024

Copy link
Copy Markdown

@Gonals Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@yuwenmemon

Copy link
Copy Markdown
Contributor

Straight revert so merging with failing tests

@yuwenmemon
yuwenmemon merged commit 778eee5 into main Jan 11, 2024
@yuwenmemon
yuwenmemon deleted the revert-34046-ionatan_killareChatRoomsEnabled branch January 11, 2024 05:57
@melvin-bot melvin-bot Bot added the Emergency label Jan 11, 2024
@melvin-bot

melvin-bot Bot commented Jan 11, 2024

Copy link
Copy Markdown

@yuwenmemon looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@thienlnam thienlnam changed the title Revert "[NO QA] Remove areChatRoomsEnabled checks" [CP Staging] Revert "[NO QA] Remove areChatRoomsEnabled checks" Jan 11, 2024
OSBotify pushed a commit that referenced this pull request Jan 11, 2024
…ChatRoomsEnabled

Revert "[NO QA] Remove areChatRoomsEnabled checks"

(cherry picked from commit 778eee5)
@github-actions github-actions Bot mentioned this pull request Jan 11, 2024
54 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.24-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 cancelled 🔪
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.24-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants