Repository navigation
Replace all spaces before compare with search text in workspace invite - #34083
Conversation
|
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Reviewing now |
|
Hi @dukenv0307 , there seems to be merge conflicts on the PR. Could you kindly fix the same? |
|
@abdulrahuman5196 Updated. |
|
@dukenv0307 Checklist tests are failing. Could you kindly fix this? |
|
@abdulrahuman5196 All checks have passed. Please check again |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-01-10.at.12.23.34.AM.mp4Android: mWeb ChromeScreen.Recording.2024-01-10.at.12.34.40.AM.mp4iOS: NativeScreen.Recording.2024-01-10.at.12.04.01.AM.mp4iOS: mWeb SafariScreen.Recording.2024-01-10.at.12.08.00.AM.mp4MacOS: Chrome / SafariScreen.Recording.2024-01-09.at.11.50.27.PM.mp4MacOS: DesktopScreen.Recording.2024-01-10.at.12.00.18.AM.mp4 |
abdulrahuman5196
left a comment
There was a problem hiding this comment.
Changes looks good and works well. Reviewers checklist is also complete.
All yours. @thienlnam
🎀 👀 🎀
C+ Reviewed
| @@ -1,3 +1,5 @@ | |||
| import {parsePhoneNumber} from 'awesome-phonenumber'; | |||
There was a problem hiding this comment.
Lint failing on main. Came from this PR.
| import {parsePhoneNumber} from 'awesome-phonenumber'; | |
| import {parsePhoneNumber} from '@libs/PhoneNumber'; |
And move this line below import * as OptionsListUtils from '@libs/OptionsListUtils';
Same applies to WorkspaceInvitePage.
@thienlnam how about adding this fix to #34311?
|
🚀 Deployed to staging by https://github.com/thienlnam in version: 1.4.24-4 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.24-8 🚀
|
Details
Fixed Issues
$ #34020
PROPOSAL: #34020 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
android.mov
iOS: Native
ios.mov
iOS: mWeb Safari
ios-mweb.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov