You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Remove MoneyRequestDatePage.js and copy any changes since Nov 27 into IOURequestStepDate.js #34608
Please re-state the problem that we are trying to solve in this issue.
Remove MoneyRequestDatePage.js and copy any changes since Nov 27 into IOURequestStepDate.js
What is the root cause of that problem?
Component update
What changes do you think we should make in order to solve the problem?
I checked all the commits after 27th Nov and the new component is updated according to the old component, we just need to remove the file and route created for it. I checked the commits thoroughly but will check again in the PR. There are total 7 commits after 27th Nov in the old component and most of them are about renaming constants and DatePicker component and imports.
changed the title [-]Remove MoneyRequestDatePage.js and copy any changes since Nov 27 into IOURequestStepDate.js[/-][+][$500] Remove MoneyRequestDatePage.js and copy any changes since Nov 27 into IOURequestStepDate.js[/+]on Jan 17, 2024
@DylanDylann I'm working on it right now, but I'm having a problem with 'edit/split'. In your PRs ( #35641 and #35137) I saw that you 'hard coded' the 'ioutype' in MoneyRequestView.tsx:
I thought that we needed to pass a dynamic iouType. Like we do it at MoneyTemporaryForRefactorRequestConfirmationList.
/create/request/date/, /edit/request/date/ and /create/split/date/ works fine. I'm 100% into it now, as soon I get the /edit/split/date/ I will raise the PR.
As I know MoneyRequestView.tsx is only used for REQUEST flow, and isn't used in SPLIT_BILL flow. It is the reason why I hardcoded CONST.IOU.TYPE.REQUEST
@DylanDylann The PR is ready for review, but I found a bug, also reproduced on 'staging' that I believe needs to be resolved so that the 'date' flow is perfect, I didn't find a related issue. In PR I bring more information.
Activity
melvin-bot commentedon Jan 16, 2024
Triggered auto assignment to @muttmuure (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.Krishna2323 commentedon Jan 16, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Remove MoneyRequestDatePage.js and copy any changes since Nov 27 into IOURequestStepDate.js
What is the root cause of that problem?
Component update
What changes do you think we should make in order to solve the problem?
I checked all the commits after 27th Nov and the new component is updated according to the old component, we just need to remove the file and route created for it. I checked the commits thoroughly but will check again in the PR. There are total 7 commits after 27th Nov in the old component and most of them are about renaming constants and
DatePickercomponent and imports.Component to remove:
https://github.com/Expensify/App/blob/main/src/pages/iou/MoneyRequestDatePage.js
App/src/libs/Navigation/AppNavigator/ModalStackNavigators.tsx
Line 98 in a7a3e7f
We also need to remove all traces from
src/libs/Navigation/types.ts&src/libs/Navigation/linkingConfig.tsApp/src/libs/Navigation/linkingConfig.ts
Line 430 in a2f5bd5
App/src/libs/Navigation/types.ts
Line 198 in a2f5bd5
Note: The below 2 steps can be omitted because we only use
IOURequestStepDatefor IOU creation flow.Result
njmulsqb commentedon Jan 17, 2024
I would love to take this!
[-]Remove MoneyRequestDatePage.js and copy any changes since Nov 27 into IOURequestStepDate.js[/-][+][$500] Remove MoneyRequestDatePage.js and copy any changes since Nov 27 into IOURequestStepDate.js[/+]melvin-bot commentedon Jan 17, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0155d041c50cef598e
melvin-bot commentedon Jan 17, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (
External)ishpaul777 commentedon Jan 17, 2024
Would love to work on this
35 remaining items
brunovjk commentedon Feb 5, 2024
@DylanDylann I'm working on it right now, but I'm having a problem with 'edit/split'. In your PRs ( #35641 and #35137) I saw that you 'hard coded' the 'ioutype' in
MoneyRequestView.tsx:I thought that we needed to pass a dynamic
iouType. Like we do it atMoneyTemporaryForRefactorRequestConfirmationList./create/request/date/,/edit/request/date/and/create/split/date/works fine. I'm 100% into it now, as soon I get the/edit/split/date/I will raise the PR.DylanDylann commentedon Feb 5, 2024
As I know
MoneyRequestView.tsxis only used for REQUEST flow, and isn't used in SPLIT_BILL flow. It is the reason why I hardcodedCONST.IOU.TYPE.REQUESTbrunovjk commentedon Feb 5, 2024
Awesome! Thank you :D
brunovjk commentedon Feb 5, 2024
@DylanDylann The PR is ready for review, but I found a bug, also reproduced on 'staging' that I believe needs to be resolved so that the 'date' flow is perfect, I didn't find a related issue. In PR I bring more information.
DylanDylann commentedon Feb 20, 2024
@muttmuure The PR was deployed to production 5 days ago. It seems the automation bot doesn't work on this issue. Please help to move forward this one
brunovjk commentedon Feb 21, 2024
@muttmuure 👉👈
muttmuure commentedon Feb 27, 2024
All paid up
melvin-bot commentedon Mar 11, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.