Repository navigation
Closed
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionDistanceWave5-free-submittersWave5-free-submittersEngineeringInternalRequires API changes or must be handled by Expensify staffRequires API changes or must be handled by Expensify staffTaskWeeklyKSv2KSv2
Description
In #26538 Most of the changes were made by adding new components. This eliminated a lot of conflicting headaches from people working on existing components.
Phase 2 is all about removing the original components and any of the duplicated efforts. The tasks that need to be done as part of this issue are:
- Remove
iou/ReceiptSelectorand copy any changes since Nov 27 intoIOURequestStepScan/ - Remove
WaypointEditor.jsand copy any changes since Nov 27 intoIOURequestStepWaypoint.js - [HOLD for payment 2024-03-04] [$250] Remove MoneyRequestCategoryPage.js and copy any changes since Nov 27 into IOURequestStepCategory.js #34606
- [HOLD for payment 2024-04-25] [$250] Remove IOUCurrencySelection.js and copy any changes since Nov 27 into IOURequestStepCurrency.js #34607
- [$250] Remove MoneyRequestDatePage.js and copy any changes since Nov 27 into IOURequestStepDate.js #34608
- [HOLD for payment 2024-02-19] [$250] Remove MoneyRequestDescriptionPage.js and copy any changes since Nov 27 into IOURequestStepDescription.js #34609
- [Pay 4/29][$250] Remove NewDistanceRequestPage.js and copy any changes since Nov 27 into IOURequestStepDistance.js #34610
- [HOLD for payment 2024-02-26] [$250] Remove MoneyRequestMerchantPage.js and copy any changes since Nov 27 into IOURequestStepMerchant.js #34611
- [HOLD for payment 2024-02-14] [$250] Remove MoneyRequestTagPage.js and copy any changes since Nov 27 into IOURequestStepTags.js #34612
- [HOLD for payment 2024-03-26] [$250] Remove MoneyRequestSelectorPage.js and copy any changes since Nov 27 into IOURequestStartPage.js #34613
- [HOLD for payment 2024-04-15] [$250] Remove NewRequestAmountPage.js and copy any changes since Nov 27 into IOURequestStepAmount.js #34614
- [HOLD for payment 2024-04-15] [$250] Remove MoneyRequestConfirmPage.js and copy any changes since Nov 27 into IOURequestStepConfirmation.js #34615
- [$250] Remove MoneyRequestParticipantsPage.js and copy any changes since Nov 27 into IOURequestStepParticipants.js #34616
- Remove MoneyRequestParticipantsSelector.js and copy any changes since Nov 27 into MoneyTemporaryForRefactorRequestParticipantsSelector #34617
- [HOLD for payment 2024-05-02] [$250] Remove
MoneyRequestConfirmationList.jsand copy any changes since Nov 27 intoMoneyTemporaryForRefactorRequestConfirmationList.js#39559 - HOLD Edit
ROUTES.tsand removeMONEY_REQUEST_*routes, remove "create" from the front of the routes - HOLD Edit
linkgingConfig.jsand removeMoney_Request*screens - HOLD Edit
ModalStackNavigators.jsremove oldMoney_Request*components - HOLD Edit
IOU.jsand remove_temporaryForRefactorfrom the name of any methods - HOLD Edit
IOU.jsand removestartMoneyRequest()method and renamestartMoneeRequest()tostartMoneyRequest() - HOLD Edit
IOU.jsand removecreateDistanceRequest()method and userequestMoneyFromDistance()everywhere - HOLD Remove
ONYXKEYS.IOU - HOLD Remove
EditRequestPage - HOLD Remove
EditSplitBillPage
git diff "tgolen-refactor-request-navigation2@{2023-11-15}..main" src/pages/iou/IOUCurrencySelection.js
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01b453df445e7dd962
- Upwork Job ID: 1711432700883152896
- Last Price Increase: 2023-10-09
Metadata
Metadata
Assignees
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionDistanceWave5-free-submittersWave5-free-submittersEngineeringInternalRequires API changes or must be handled by Expensify staffRequires API changes or must be handled by Expensify staffTaskWeeklyKSv2KSv2
Type
Projects
- StatusShow more project fieldsLOW
- StatusShow more project fieldsDone
Activity
melvin-bot commentedon Oct 9, 2023
Job added to Upwork: https://www.upwork.com/jobs/~01b453df445e7dd962
melvin-bot commentedon Oct 9, 2023
Triggered auto assignment to Contributor Plus for review of internal employee PR - @ntdiary (
Internal)[-]PHASE 2: Wave 5 CLEANUP Refactor navigation among screens related to money request features[/-][+][HOLD App/issues/26538] PHASE 2: Wave 5 CLEANUP Refactor navigation among screens related to money request features[/+]92 remaining items
DylanDylann commentedon May 7, 2024
Weekly Update
Everything in this checklist is done. We are waiting for #41216 to be merged to close this issue. The reason why we need to wait for #41216 to be merged is that besides migrating to typescript we also changed the name of the file, which is part of this issue
tgolen commentedon May 10, 2024
I was able to merge that PR this morning, so I will go ahead and close this issue out. Thanks for all the help with this!!
[-][LOW] Distance: PHASE 2 CLEANUP - Refactor navigation among screens related to money request features[/-][+][HOLD for payment 2024-05-22] [LOW] Distance: PHASE 2 CLEANUP - Refactor navigation among screens related to money request features[/+]melvin-bot commentedon May 15, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 15, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.73-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-05-22. 🎊
For reference, here are some details about the assignees on this issue: