Skip to content

[HOLD for payment 2024-05-22] [LOW] Distance: PHASE 2 CLEANUP - Refactor navigation among screens related to money request features #29107

Closed

Description

@tgolen

In #26538 Most of the changes were made by adding new components. This eliminated a lot of conflicting headaches from people working on existing components.

Phase 2 is all about removing the original components and any of the duplicated efforts. The tasks that need to be done as part of this issue are:

git diff "tgolen-refactor-request-navigation2@{2023-11-15}..main" src/pages/iou/IOUCurrencySelection.js
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b453df445e7dd962
  • Upwork Job ID: 1711432700883152896
  • Last Price Increase: 2023-10-09

Activity

  1. self-assigned this
    on Oct 9, 2023
  2. melvin-bot commented on Oct 9, 2023

    @melvin-bot
  3. melvin-bot commented on Oct 9, 2023

    @melvin-bot

    Triggered auto assignment to Contributor Plus for review of internal employee PR - @ntdiary (Internal)

  4. assigned and unassigned on Oct 9, 2023
  5. changed the title [-]PHASE 2: Wave 5 CLEANUP Refactor navigation among screens related to money request features[/-] [+][HOLD App/issues/26538] PHASE 2: Wave 5 CLEANUP Refactor navigation among screens related to money request features[/+] on Oct 9, 2023
  6. 92 remaining items

  7. DylanDylann commented on May 7, 2024

    @DylanDylann
    Contributor

    Weekly Update

    Everything in this checklist is done. We are waiting for #41216 to be merged to close this issue. The reason why we need to wait for #41216 to be merged is that besides migrating to typescript we also changed the name of the file, which is part of this issue

  8. tgolen commented on May 10, 2024

    @tgolen
    ContributorAuthor

    I was able to merge that PR this morning, so I will go ahead and close this issue out. Thanks for all the help with this!!

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on May 15, 2024
  10. changed the title [-][LOW] Distance: PHASE 2 CLEANUP - Refactor navigation among screens related to money request features[/-] [+][HOLD for payment 2024-05-22] [LOW] Distance: PHASE 2 CLEANUP - Refactor navigation among screens related to money request features[/+] on May 15, 2024
  11. melvin-bot commented on May 15, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on May 15, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.73-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-05-22. 🎊

    For reference, here are some details about the assignees on this issue:

    • @DylanDylann requires payment (Needs manual offer from BZ)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDistanceWave5-free-submittersEngineeringInternalRequires API changes or must be handled by Expensify staffTaskWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions