You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-04-15] [$250] Remove NewRequestAmountPage.js and copy any changes since Nov 27 into IOURequestStepAmount.js #34614
Please re-state the problem that we are trying to solve in this issue.
Remove NewRequestAmountPage.js and copy any changes since Nov 27 into IOURequestStepAmount.js
What is the root cause of that problem?
This is a refactor
What changes do you think we should make in order to solve the problem?
Look at the history of the Old Component
If there are any changes since Nov 27, 2023 which have not been added to the New Component, copy those changes
Update any logic like isEditing to use the new action param from the route
Re-use IOURequestStepAmount for edit case and remove EditRequestAmountPage.
We will handle edit when action param is edit and we can re-use the logic of the saveAmountAndCurrency function in EditRequestPage to update amount for edit case. And when we click on amount in transaction report detail we will navigate to IOURequestStepAmount with action param as edit.
Re-use IOURequestStepAmount for the edit split bill case. We can check this case by checking action and iouType param. We can re-use setDraftSplitTransaction function in EditSplitBillPage to update in IOURequestStepAmount as well
Edit the route of MONEY_REQUEST_CREATE_TAB_MANUAL
What alternative solutions did you explore? (Optional)
@tgolen I have a question, after refactor in edit request amount page we will use MoneyRequestAmountForm or use IOURequestStepAmount with action is edit
changed the title [-]Remove NewRequestAmountPage.js and copy any changes since Nov 27 into IOURequestStepAmount.js[/-][+][$500] Remove NewRequestAmountPage.js and copy any changes since Nov 27 into IOURequestStepAmount.js[/+]on Jan 17, 2024
changed the title [-][$250] Remove NewRequestAmountPage.js and copy any changes since Nov 27 into IOURequestStepAmount.js[/-][+][HOLD for payment 2024-04-15] [$250] Remove NewRequestAmountPage.js and copy any changes since Nov 27 into IOURequestStepAmount.js[/+]on Apr 8, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@dukenv0307 / @DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
[@dukenv0307 / @DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@dukenv0307 / @DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@dukenv0307 / @DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Jan 16, 2024
Triggered auto assignment to @lschurr (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.neonbhai commentedon Jan 16, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Remove NewRequestAmountPage.js and copy any changes since Nov 27 into IOURequestStepAmount.js
What is the root cause of that problem?
Clean up of
NewRequestAmountPageWhat changes do you think we should make in order to solve the problem?
We will be deleting the component here:
App/src/pages/iou/steps/NewRequestAmountPage.js
Lines 57 to 61 in 93e68b5
This file will be removed. Looking at history (link), we had three changes. We will incorporate these into the PR (making sure no regressions)
We will remove the screen from ModalStackNavigators.tsx here:
App/src/libs/Navigation/AppNavigator/ModalStackNavigators.tsx
Line 94 in 93e68b5
njmulsqb commentedon Jan 17, 2024
I would love to take this!
dukenv0307 commentedon Jan 17, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Remove NewRequestAmountPage.js and copy any changes since Nov 27 into IOURequestStepAmount.js
What is the root cause of that problem?
This is a refactor
What changes do you think we should make in order to solve the problem?
We have had three changes since Nov 27, 2023 but it already had in
IOURequestStepAmount. So no need to change hereNewRequestAmountPageis only used inMoneyRequestSelectorPageand this page is also removed so we don't any updates here.We only need to remove
NewRequestAmountPageinModalStackNavigators, remove.MONEY_REQUEST.AMOUNTfromSCREENS, and removeMONEY_REQUEST_AMOUNTrouteApp/src/libs/Navigation/AppNavigator/ModalStackNavigators.tsx
Line 94 in a8acf44
getRoutefunction with an extra paramactionand return it instead of always returningcreateApp/src/ROUTES.ts
Line 314 in a8acf44
We also need to update
MONEY_REQUEST_CREATE_TAB_MANUALroute by adding a newactionparam instead of a constantcreatedApp/src/ROUTES.ts
Lines 397 to 398 in 1b1eeb8
IOURequestStepAmountfor edit case and removeEditRequestAmountPage.We will handle edit when
actionparam iseditand we can re-use the logic of thesaveAmountAndCurrencyfunction inEditRequestPageto update amount for edit case. And when we click on amount in transaction report detail we will navigate toIOURequestStepAmountwithactionparam asedit.Re-use
IOURequestStepAmountfor the edit split bill case. We can check this case by checkingactionandiouTypeparam. We can re-usesetDraftSplitTransactionfunction inEditSplitBillPageto update inIOURequestStepAmountas wellEdit the route of
MONEY_REQUEST_CREATE_TAB_MANUALWhat alternative solutions did you explore? (Optional)
NA
dukenv0307 commentedon Jan 17, 2024
@tgolen I have a question, after refactor in edit request amount page we will use
MoneyRequestAmountFormor useIOURequestStepAmountwithactionisedit[-]Remove NewRequestAmountPage.js and copy any changes since Nov 27 into IOURequestStepAmount.js[/-][+][$500] Remove NewRequestAmountPage.js and copy any changes since Nov 27 into IOURequestStepAmount.js[/+]melvin-bot commentedon Jan 17, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01400d372c60004a9e
melvin-bot commentedon Jan 17, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (
External)58 remaining items
[-][$250] Remove NewRequestAmountPage.js and copy any changes since Nov 27 into IOURequestStepAmount.js[/-][+][HOLD for payment 2024-04-15] [$250] Remove NewRequestAmountPage.js and copy any changes since Nov 27 into IOURequestStepAmount.js[/+]melvin-bot commentedon Apr 8, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 8, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-04-15. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 8, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
lschurr commentedon Apr 12, 2024
@dukenv0307 @DylanDylann - Do we need a regression test here?
DylanDylann commentedon Apr 15, 2024
@lschurr This is a refactoring task, we don't need regression here.
lschurr commentedon Apr 15, 2024
Payment summary: