Skip to content

[$500] Task is not archived when delete WS Offline #35174

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.32-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #31900

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Log in
  3. Create a new workspace
  4. Open the workspace/policy expense chat
  5. Create a thread
  6. Turn off the internet connection
  7. Delete the workspace

Expected Result:

Thread is archived

Actual Result:

Thread is not archived when delete WS Offline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6354970_1706205858291.Thread_is_not_archived_when_delete_WS_Offline.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0148ea2ff5d6b35fdb
  • Upwork Job ID: 1750595971529564160
  • Last Price Increase: 2024-01-25
  • Automatic offers:
    • aimane-chnaif | Reviewer | 28148967
    • mkhutornyi | Contributor | 28148968

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jan 25, 2024
  2. changed the title [-]Tread - Thread is not archived when delete WS Offline[/-] [+][$500] Tread - Thread is not archived when delete WS Offline[/+] on Jan 25, 2024
  3. melvin-bot commented on Jan 25, 2024

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Jan 25, 2024
  5. melvin-bot commented on Jan 25, 2024

    @melvin-bot

    Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  6. melvin-bot commented on Jan 25, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

  7. kbecciv commented on Jan 25, 2024

    @kbecciv
    Author

    We think that this bug might be related to #vip-vsb
    CC @quinthar

  8. Tony-MK commented on Jan 25, 2024

    @Tony-MK
  9. ra-md commented on Jan 26, 2024

    @ra-md
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The thread is not archived when we delete WS in Offline mode.

    What is the root cause of that problem?

    The thread is actually archived, but we just don't add an "archived" indicator for threads in the LHN. Here, we don't check if the parent report is archived.

    What changes do you think we should make in order to solve the problem?

    we can add a condition like here to check if the parent report is archived and add Localize.translateLocal('common.archived') after parentReportActionMessage to show that the thread has been archived.

    What alternative solutions did you explore? (Optional)

    N/A

  10. aimane-chnaif commented on Jan 29, 2024

    @aimane-chnaif
    Contributor

    Proposals are in review

  11. 31 remaining items

  12. melvin-bot commented on Feb 7, 2024

    @melvin-bot

    📣 @mkhutornyi 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

    Offer link
    Upwork job
    Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
    Keep in mind: Code of Conduct | Contributing 📖

  13. melvin-bot commented on Feb 8, 2024

    @melvin-bot

    @johncschuster @cristipaval @aimane-chnaif @mkhutornyi this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  14. mkhutornyi commented on Feb 8, 2024

    @mkhutornyi
    Contributor

    PR will be ready by tomorrow

  15. added
    ReviewingHas a PR in review
    and removed on Feb 9, 2024
  16. dukenv0307 commented on Feb 9, 2024

    @dukenv0307
    Contributor

    This issue has the same root cause as #36022

    My proposal there comes first, then after that @mkhutornyi posted the same solution here.

    @cristipaval @aimane-chnaif Can you reevaluate which proposal should be selected in this case, since @mkhutornyi 's proposal is a dupe of mine.

    Thank you!

  17. mkhutornyi commented on Feb 9, 2024

    @mkhutornyi
    Contributor

    FYI: I just found out this issue today while looking for external issues to submit proposal.

  18. dukenv0307 commented on Feb 9, 2024

    @dukenv0307
    Contributor

    FYI: I just found out this issue today while looking for external issues to submit proposal.

    @mkhutornyi I believe we base the decision on timeline, not whether someone intends to post a dupe or not (we have no way to know for sure).

    Since you already raised the PR I'd be happy to split the compensation, since our proposals are same, just on 2 dupe issues (and yours are later) 👍. What do you think?

  19. aimane-chnaif commented on Feb 9, 2024

    @aimane-chnaif
    Contributor

    @dukenv0307 I checked your proposal. But lack of solution. You didn't point out which reports to archive.
    Btw, this seems like 2nd case of #26700 (comment).
    @dukenv0307 unfortunately, you're not eligible.

  20. aimane-chnaif commented on Feb 9, 2024

    @aimane-chnaif
    Contributor

    @dukenv0307 please submit proposal in #35855 where solution will be based on @mkhutornyi's PR. I don't see viable proposal yet because they didn't consider what reports to archive optimistically.
    This way, I can help you not lose your efforts.

  21. aimane-chnaif commented on Feb 29, 2024

    @aimane-chnaif
    Contributor

    Automation was broken here. PR was deployed to production on Feb 15 (#36225 (comment))
    Payment is due on Feb 22

    @cristipaval can you please remove Reviewing label and change to Daily?

  22. johncschuster commented on Mar 19, 2024

    @johncschuster
    Contributor

    Sorry for missing this! Payment has been issued!

  23. melvin-bot commented on Mar 26, 2024

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions