You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] Task is not archived when delete WS Offline #35174
Version Number: 1.4.32-2 Reproducible in staging?: y Reproducible in production?: y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
changed the title [-]Tread - Thread is not archived when delete WS Offline[/-][+][$500] Tread - Thread is not archived when delete WS Offline[/+]on Jan 25, 2024
Please re-state the problem that we are trying to solve in this issue.
The thread is not archived when we delete WS in Offline mode.
What is the root cause of that problem?
The thread is actually archived, but we just don't add an "archived" indicator for threads in the LHN. Here, we don't check if the parent report is archived.
What changes do you think we should make in order to solve the problem?
we can add a condition like here to check if the parent report is archived and add Localize.translateLocal('common.archived') after parentReportActionMessage to show that the thread has been archived.
What alternative solutions did you explore? (Optional)
📣 @mkhutornyi 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
@johncschuster@cristipaval@aimane-chnaif@mkhutornyi this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
FYI: I just found out this issue today while looking for external issues to submit proposal.
@mkhutornyi I believe we base the decision on timeline, not whether someone intends to post a dupe or not (we have no way to know for sure).
Since you already raised the PR I'd be happy to split the compensation, since our proposals are same, just on 2 dupe issues (and yours are later) 👍. What do you think?
@dukenv0307 I checked your proposal. But lack of solution. You didn't point out which reports to archive.
Btw, this seems like 2nd case of #26700 (comment). @dukenv0307 unfortunately, you're not eligible.
@dukenv0307 please submit proposal in #35855 where solution will be based on @mkhutornyi's PR. I don't see viable proposal yet because they didn't consider what reports to archive optimistically.
This way, I can help you not lose your efforts.
Activity
[-]Tread - Thread is not archived when delete WS Offline[/-][+][$500] Tread - Thread is not archived when delete WS Offline[/+]melvin-bot commentedon Jan 25, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0148ea2ff5d6b35fdb
melvin-bot commentedon Jan 25, 2024
Triggered auto assignment to @johncschuster (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jan 25, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (
External)kbecciv commentedon Jan 25, 2024
We think that this bug might be related to #vip-vsb
CC @quinthar
Tony-MK commentedon Jan 25, 2024
ra-md commentedon Jan 26, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
The thread is not archived when we delete WS in Offline mode.
What is the root cause of that problem?
The thread is actually archived, but we just don't add an "archived" indicator for threads in the LHN. Here, we don't check if the parent report is archived.
What changes do you think we should make in order to solve the problem?
we can add a condition like here to check if the parent report is archived and add
Localize.translateLocal('common.archived')afterparentReportActionMessageto show that the thread has been archived.What alternative solutions did you explore? (Optional)
N/A
aimane-chnaif commentedon Jan 29, 2024
Proposals are in review
31 remaining items
melvin-bot commentedon Feb 7, 2024
📣 @mkhutornyi 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!
Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑💻
Keep in mind: Code of Conduct | Contributing 📖
melvin-bot commentedon Feb 8, 2024
@johncschuster @cristipaval @aimane-chnaif @mkhutornyi this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
mkhutornyi commentedon Feb 8, 2024
PR will be ready by tomorrow
dukenv0307 commentedon Feb 9, 2024
This issue has the same root cause as #36022
My proposal there comes first, then after that @mkhutornyi posted the same solution here.
@cristipaval @aimane-chnaif Can you reevaluate which proposal should be selected in this case, since @mkhutornyi 's proposal is a dupe of mine.
Thank you!
mkhutornyi commentedon Feb 9, 2024
FYI: I just found out this issue today while looking for external issues to submit proposal.
dukenv0307 commentedon Feb 9, 2024
@mkhutornyi I believe we base the decision on timeline, not whether someone intends to post a dupe or not (we have no way to know for sure).
Since you already raised the PR I'd be happy to split the compensation, since our proposals are same, just on 2 dupe issues (and yours are later) 👍. What do you think?
aimane-chnaif commentedon Feb 9, 2024
@dukenv0307 I checked your proposal. But lack of solution. You didn't point out which reports to archive.
Btw, this seems like 2nd case of #26700 (comment).
@dukenv0307 unfortunately, you're not eligible.
aimane-chnaif commentedon Feb 9, 2024
@dukenv0307 please submit proposal in #35855 where solution will be based on @mkhutornyi's PR. I don't see viable proposal yet because they didn't consider what reports to archive optimistically.
This way, I can help you not lose your efforts.
aimane-chnaif commentedon Feb 29, 2024
Automation was broken here. PR was deployed to production on Feb 15 (#36225 (comment))
Payment is due on Feb 22
@cristipaval can you please remove
Reviewinglabel and change toDaily?johncschuster commentedon Mar 19, 2024
Sorry for missing this! Payment has been issued!
melvin-bot commentedon Mar 26, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.