Skip to content

[$500] Expense - "Pay with Expensify" button is grayed out briefly after requesting money #35894

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v.1.4-37.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:

Action Performed:

Precondition: User is a member of workspace in which the currency is different from the local currency.

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Create a manual request.
  4. Create another manual request.

Expected Result:

"Pay with Expensify" button in the main chat will not gray out.

Actual Result:

"Pay with Expensify" button is grayed out briefly after requesting money.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6369082_1707216168534.bandicam_2024-02-06_08-24-33-092.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b74cf4a81b61a7fd
  • Upwork Job ID: 1754829907209736192
  • Last Price Increase: 2024-02-13

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 6, 2024
  2. changed the title [-]Expense - "Pay with Expensify" button is grayed out briefly after requesting money[/-] [+][$500] Expense - "Pay with Expensify" button is grayed out briefly after requesting money[/+] on Feb 6, 2024
  3. melvin-bot commented on Feb 6, 2024

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 6, 2024
  5. melvin-bot commented on Feb 6, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

  6. melvin-bot commented on Feb 6, 2024

    @melvin-bot

    Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  7. github-actions commented on Feb 6, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  8. 36 remaining items

  9. danieldoglas commented on Mar 4, 2024

    @danieldoglas
    Contributor

    still on hold

  10. garrettmknight commented on Mar 5, 2024

    @garrettmknight
    Contributor

    Holding on #36440

  11. garrettmknight commented on Mar 14, 2024

    @garrettmknight
    Contributor

    Tested, still getting the greyed out part happening.

  12. changed the title [-][HOLD on E/E #369265] [$500] Expense - "Pay with Expensify" button is grayed out briefly after requesting money[/-] [+][$500] Expense - "Pay with Expensify" button is grayed out briefly after requesting money[/+] on Mar 14, 2024
  13. garrettmknight commented on Mar 14, 2024

    @garrettmknight
    Contributor

    @tienifr does your prososal still stand?

  14. garrettmknight commented on Mar 15, 2024

    @garrettmknight
    Contributor

    Actually, closing since this is behavior doesn't really stop anyone from using the app. This feels like extreme polish.

  15. tienifr commented on Mar 16, 2024

    @tienifr
    Contributor

    Actually, closing since this is behavior doesn't really stop anyone from using the app. This feels like extreme polish.

    This behavior might be a polish in online mode, but I believe in offline mode it's a far more serious issue since it will cause much confusion, see below.

    The problem also is if the user is in offline mode, the button will be grayed out forever without explanations.

    Also it's violating our app's form pattern, more explanation here, do you think we should reopen this?

    @tienifr does your prososal still stand?

    @garrettmknight Yes my proposal would still work well for this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions