You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$500] Workspace - App does not open WS chat after creating a new workspace and returning to Chats #38286
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@MariaHCD I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
Please re-state the problem that we are trying to solve in this issue.
Chats open the last chat instead of workspace chat.
What is the root cause of that problem?
After Idea nav2 is complete, workspace setting is moved to FullScreenNavigator and when we create a new workspace we don't switch navigate to new policy so after we back to chat, the active policy isn't changed
OPTIONAL: we can add an extra param in this function like shouldSwitchPolicy with default value as false and call Navigation.navigateWithSwitchPolicyID if it's true and then we will pass shouldSwitchPolicy as true when we click on plus icon of WorkspaceSwitcherPage
What alternative solutions did you explore? (Optional)
Accessing a workspace via the 🔧 resulted in a "lateral," global switch of someone's workspace. This was confusing because we created one known, obvious way to switch a worked – the workspace switcher – and then one secret, confusing way to "laterally" switch a workspace by choosing it in Settings.
The workspace in settings is no longer "connected" to the LHN workspace. It's a design change.
@mountiny When we create a new workspace, I think we can switch policy before we navigate to the setting workspace so after we click on back button in header of setting page, we can see the releated reports of the new workspace.
Activity
melvin-bot commentedon Mar 14, 2024
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.github-actions commentedon Mar 14, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Mar 14, 2024
Triggered auto assignment to @MariaHCD (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.izarutskaya commentedon Mar 14, 2024
@MariaHCD I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
izarutskaya commentedon Mar 14, 2024
We think that this bug might be related to #wave-collect - Release 1
CC @trjExpensify
nkdengineer commentedon Mar 14, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Chats open the last chat instead of workspace chat.
What is the root cause of that problem?
After Idea nav2 is complete, workspace setting is moved to
FullScreenNavigatorand when we create a new workspace we don't switch navigate to new policy so after we back to chat, the active policy isn't changedApp/src/libs/actions/App.ts
Line 332 in b7a230e
What changes do you think we should make in order to solve the problem?
We should switch the active
policyIDhere before navigating to workspace initial pageApp/src/libs/actions/App.ts
Line 332 in b7a230e
OPTIONAL: we can add an extra param in this function like
shouldSwitchPolicywith default value as false and callNavigation.navigateWithSwitchPolicyIDif it's true and then we will passshouldSwitchPolicyastruewhen we click on plus icon ofWorkspaceSwitcherPageWhat alternative solutions did you explore? (Optional)
NA
6 remaining items
nkdengineer commentedon Mar 14, 2024
@jjcoffee This PR #37421 cause this.
luacmartins commentedon Mar 14, 2024
@WojtekBoman @mountiny seems like a regression from ideal nav v2
kosmydel commentedon Mar 14, 2024
I think this one is expected (source):
The workspace in settings is no longer "connected" to the LHN workspace. It's a design change.
cc @mountiny, @trjExpensify
mountiny commentedon Mar 14, 2024
I think this does not have to be a blocker, I will assign myself and discuss if we want to keep this behaviour in the new design
mountiny commentedon Mar 14, 2024
@kosmydel this is not about selecting the workspace or not
When new workspace was created, the user was navigated to the admins room before this change, not to the settings
nkdengineer commentedon Mar 14, 2024
@mountiny When we create a new workspace, I think we can switch policy before we navigate to the setting workspace so after we click on back button in header of setting page, we can see the releated reports of the new workspace.
mountiny commentedon Mar 14, 2024
After discussing this is now going to be expected, not all workspaces will have admin rooms #36236 so navigating to settings is the best option.
@kavimuru @izarutskaya @isagoico Could you update testRail about this?
isagoico commentedon Mar 14, 2024
This TC should cover this behavior - Workspace Creation - Online