You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-04-05] [HOLD for payment 2024-03-29] [HOLD for payment 2024-03-26] [Simplified Collect][Taxes] iOS - Taxes - App crashes tapping tax value #38502
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
This was introduced #37967. This is NAB since this feature is only available on Collect policies in NewDot and users don't have access to that yet. I think we can address that as a follow up to the other tax PRs. cc @kosmydel@filip-solecki
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.54-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.55-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Activity
github-actions commentedon Mar 18, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Mar 18, 2024
Triggered auto assignment to @francoisl (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.kbecciv commentedon Mar 18, 2024
We think that this bug might be related to #wave-control
kbecciv commentedon Mar 18, 2024
@francoisl The app crashes when adding the distance rate, do we need to create a separate GH or the same root cause?
RPReplay_Final1710786838.MP4
allgandalf commentedon Mar 18, 2024
#38504 (comment)
@abzokhattab , looks like the same RCA is applicable here too as you mentioned over that issue
francoisl commentedon Mar 18, 2024
I can repro on iOS, this seems to come from #37967.
Not sure yet but it might be a different cause, the PR I linked to is specific to tax rates. Maybe it's safer to open a separate issue for now.
luacmartins commentedon Mar 18, 2024
This was introduced #37967. This is NAB since this feature is only available on Collect policies in NewDot and users don't have access to that yet. I think we can address that as a follow up to the other tax PRs. cc @kosmydel @filip-solecki
15 remaining items
[-][Simplified Collect][Taxes] iOS - Taxes - App crashes tapping tax value[/-][+][HOLD for payment 2024-03-26] [Simplified Collect][Taxes] iOS - Taxes - App crashes tapping tax value[/+]melvin-bot commentedon Mar 19, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 19, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.54-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-03-26. 🎊
[-][HOLD for payment 2024-03-26] [Simplified Collect][Taxes] iOS - Taxes - App crashes tapping tax value[/-][+][HOLD for payment 2024-03-29] [HOLD for payment 2024-03-26] [Simplified Collect][Taxes] iOS - Taxes - App crashes tapping tax value[/+]melvin-bot commentedon Mar 22, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.55-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-03-29. 🎊
[-][HOLD for payment 2024-03-29] [HOLD for payment 2024-03-26] [Simplified Collect][Taxes] iOS - Taxes - App crashes tapping tax value[/-][+][HOLD for payment 2024-04-05] [HOLD for payment 2024-03-29] [HOLD for payment 2024-03-26] [Simplified Collect][Taxes] iOS - Taxes - App crashes tapping tax value[/+]melvin-bot commentedon Mar 29, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-04-05. 🎊