You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-04-05] [HOLD for payment 2024-03-29] [HOLD for payment 2024-03-26] iOS - App Crashed when tap on request money #38504
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@AndrewGable FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
What changes do you think we should make in order to solve the problem?
either we can we revert the change completely
or we can revert the changes for only for the ios, as it seems to work with android:
to do that we can split the index.native file into two file one for android and one for ios:
index.android.ts: should be the same as the current index.native.ts file
index.ios.ts: should have the reverted change.
importpolyfillListFormatfrom'./polyfillListFormat';importpolyfillNumberFormatfrom'./polyfillNumberFormat';importtypeIntlPolyfillfrom'./types';/** * Polyfill the Intl API, always performed for native devices. */constintlPolyfill: IntlPolyfill=()=>{require('@formatjs/intl-locale/polyfill');require('@formatjs/intl-pluralrules/polyfill');polyfillNumberFormat();polyfillListFormat();};exportdefaultintlPolyfill;
It seems like #38502 (comment) has the same root cause as this issue. Given that #38502 was demoted to NAB, could we also test #38502 when we solve this one and close it if it's fixed?
changed the title [-] iOS - App Crashed when tap on request money[/-][+][HOLD for payment 2024-03-26] iOS - App Crashed when tap on request money[/+]on Mar 19, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.54-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
changed the title [-][HOLD for payment 2024-03-26] iOS - App Crashed when tap on request money[/-][+][HOLD for payment 2024-03-29] [HOLD for payment 2024-03-26] iOS - App Crashed when tap on request money[/+]on Mar 22, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.55-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
changed the title [-][HOLD for payment 2024-03-29] [HOLD for payment 2024-03-26] iOS - App Crashed when tap on request money[/-][+][HOLD for payment 2024-04-05] [HOLD for payment 2024-03-29] [HOLD for payment 2024-03-26] iOS - App Crashed when tap on request money[/+]on Mar 29, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Activity
github-actions commentedon Mar 18, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Mar 18, 2024
Triggered auto assignment to @AndrewGable (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.lanitochka17 commentedon Mar 18, 2024
@AndrewGable FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
abzokhattab commentedon Mar 18, 2024
Proposal
Please re-state the problem that we are trying to solve in this i issue.
iOS - App Crashed when tap on request money
What is the root cause of that problem?
regression from #38447. , the
intl-pluralrulesandintl-numberformatpolyfill is needed for theIntlsupport in ioshttps://github.com/abzokhattab/App/blob/dabcb166a9a0fba8dcbf2e11fe155c42b5eca678/src/libs/IntlPolyfill/index.native.ts
What changes do you think we should make in order to solve the problem?
android:to do that we can split the
index.nativefile into two file one for android and one for ios:index.android.ts: should be the same as the currentindex.native.tsfileindex.ios.ts: should have the reverted change.then we should remove the
index.nativefilemelvin-bot commentedon Mar 18, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
luacmartins commentedon Mar 18, 2024
It seems like #38502 (comment) has the same root cause as this issue. Given that #38502 was demoted to NAB, could we also test #38502 when we solve this one and close it if it's fixed?
allgandalf commentedon Mar 18, 2024
I guess we need to take opinion of @mountiny here, as he had opened the issue #38447
mountiny commentedon Mar 18, 2024
lets just revert that PR and handle these issues found in a v2.
We incorrectly assumed this will not be needed
mountiny commentedon Mar 18, 2024
I would like to not rush these decisions
9 remaining items
[-] iOS - App Crashed when tap on request money[/-][+][HOLD for payment 2024-03-26] iOS - App Crashed when tap on request money[/+]melvin-bot commentedon Mar 19, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Mar 19, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.54-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-03-26. 🎊
[-][HOLD for payment 2024-03-26] iOS - App Crashed when tap on request money[/-][+][HOLD for payment 2024-03-29] [HOLD for payment 2024-03-26] iOS - App Crashed when tap on request money[/+]melvin-bot commentedon Mar 22, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.55-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-03-29. 🎊
[-][HOLD for payment 2024-03-29] [HOLD for payment 2024-03-26] iOS - App Crashed when tap on request money[/-][+][HOLD for payment 2024-04-05] [HOLD for payment 2024-03-29] [HOLD for payment 2024-03-26] iOS - App Crashed when tap on request money[/+]melvin-bot commentedon Mar 29, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-04-05. 🎊