You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Pay 4/29][$500] Wallet - No error when clicking Save & continue button after selecting BA with existing draft #38518
@MitchExpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
Please re-state the problem that we are trying to solve in this issue.
The add personal bank account page doesn't show an error and just looks like do nothing when pressing the button.
What is the root cause of that problem?
When we press the save button, we actually request the BE to try saving it, and BE already returns the correct error message for us to show.
However, the add personal bank account form has a different key than the BE response. The BE response merges the errors to personalBankAccount, but the form has a key of personalBankAccountForm.
changed the title [-]Wallet - No error when clicking Save & continue button after selecting BA with existing draft[/-][+][$500] Wallet - No error when clicking Save & continue button after selecting BA with existing draft[/+]on Mar 25, 2024
changed the title [-][$500] Wallet - No error when clicking Save & continue button after selecting BA with existing draft[/-][+][Pay 4/29][$500] Wallet - No error when clicking Save & continue button after selecting BA with existing draft[/+]on Apr 24, 2024
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Activity
melvin-bot commentedon Mar 18, 2024
Triggered auto assignment to @MitchExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.kbecciv commentedon Mar 18, 2024
We think that this bug might be related to #wave-collect - Release 1
kbecciv commentedon Mar 18, 2024
@MitchExpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
bernhardoj commentedon Mar 19, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
The add personal bank account page doesn't show an error and just looks like do nothing when pressing the button.
What is the root cause of that problem?
When we press the save button, we actually request the BE to try saving it, and BE already returns the correct error message for us to show.
However, the add personal bank account form has a different key than the BE response. The BE response merges the errors to
personalBankAccount, but the form has a key ofpersonalBankAccountForm.App/src/pages/AddPersonalBankAccountPage.tsx
Lines 82 to 83 in 22bd9eb
App/src/ONYXKEYS.ts
Line 408 in 22bd9eb
This happens after this TS migration PR which unnecessarily changes the key.
If we look at the bank account step pages, we can see that they don't add
formsuffix to the key.App/src/pages/ReimbursementAccount/BankInfo/substeps/Manual.tsx
Lines 63 to 64 in 22bd9eb
App/src/ONYXKEYS.ts
Line 406 in 22bd9eb
What changes do you think we should make in order to solve the problem?
Remove the
formfromONYXKEYS.FORMS.PERSONAL_BANK_ACCOUNTandPERSONAL_BANK_ACCOUNT_DRAFTBut after fixing this, we will see the error message shown is still incorrect and this is a separate issue that is being handled here

Result after fixing all:
Screen.Recording.2024-03-19.at.13.10.58.mov
MitchExpensify commentedon Mar 19, 2024
Assigning to VSB as this is a personal account issue more in line with off workspace use
melvin-bot commentedon Mar 25, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0183d2c7f9a0e1aa53
[-]Wallet - No error when clicking Save & continue button after selecting BA with existing draft[/-][+][$500] Wallet - No error when clicking Save & continue button after selecting BA with existing draft[/+]melvin-bot commentedon Mar 25, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (
External)31 remaining items
[-][$500] Wallet - No error when clicking Save & continue button after selecting BA with existing draft[/-][+][Pay 4/29][$500] Wallet - No error when clicking Save & continue button after selecting BA with existing draft[/+]melvin-bot commentedon Apr 25, 2024
This issue has not been updated in over 15 days. @cubuspl42, @Gonals, @MitchExpensify, @bernhardoj eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
MitchExpensify commentedon Apr 25, 2024
Reminder set to pay on 4/29
Payment summary:
$500 Contributor @bernhardoj
$500 C+ @cubuspl42
melvin-bot commentedon May 3, 2024
@cubuspl42, @Gonals, @MitchExpensify, @bernhardoj Whoops! This issue is 2 days overdue. Let's get this updated quick!
MitchExpensify commentedon May 6, 2024
Paid and contract ended, apologies for the delay