Skip to content

[Pay 4/29][$500] Wallet - No error when clicking Save & continue button after selecting BA with existing draft #38518

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.54-0
Reproducible in staging?: y
Reproducible in production?: y
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com.
  2. Go to Profile > Workspaces > any workspace.
  3. Go to Bank account > Connect manually.
  4. Add the following bank account (important):
    Routing number - 011401533
    Account number - 1111222233331111
  5. Proceed the setup and quit in the middle of it (by clicking outside RHP).
  6. Go to Wallet > Add bank account > Personal bank account.
  7. Add any bank account and select Plaid Saving account (ends with 1111).
  8. Click Save & continue.

Expected Result:

App should present an error about unable to proceed with Plaid Saving account (ends with 1111) since there is draft in Step 5.

Actual Result:

There is no error when clicking Save & continue. Nothing happens when clicking on the button.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6418307_1710791246953.20240319_033905.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0183d2c7f9a0e1aa53
  • Upwork Job ID: 1772399631405613056
  • Last Price Increase: 2024-03-25
  • Automatic offers:
    • cubuspl42 | Reviewer | 0
    • bernhardoj | Contributor | 0

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Mar 18, 2024
  2. melvin-bot commented on Mar 18, 2024

    @melvin-bot

    Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. kbecciv commented on Mar 18, 2024

    @kbecciv
    Author

    We think that this bug might be related to #wave-collect - Release 1

  4. kbecciv commented on Mar 18, 2024

    @kbecciv
    Author

    @MitchExpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  5. bernhardoj commented on Mar 19, 2024

    @bernhardoj
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The add personal bank account page doesn't show an error and just looks like do nothing when pressing the button.

    What is the root cause of that problem?

    When we press the save button, we actually request the BE to try saving it, and BE already returns the correct error message for us to show.

    However, the add personal bank account form has a different key than the BE response. The BE response merges the errors to personalBankAccount, but the form has a key of personalBankAccountForm.

    <FormProvider
    formID={ONYXKEYS.FORMS.PERSONAL_BANK_ACCOUNT}

    PERSONAL_BANK_ACCOUNT: 'personalBankAccountForm',

    This happens after this TS migration PR which unnecessarily changes the key.

    If we look at the bank account step pages, we can see that they don't add form suffix to the key.

    <FormProvider
    formID={ONYXKEYS.FORMS.REIMBURSEMENT_ACCOUNT_FORM}

    REIMBURSEMENT_ACCOUNT_FORM: 'reimbursementAccount',

    What changes do you think we should make in order to solve the problem?

    Remove the form from ONYXKEYS.FORMS.PERSONAL_BANK_ACCOUNT and PERSONAL_BANK_ACCOUNT_DRAFT

    But after fixing this, we will see the error message shown is still incorrect and this is a separate issue that is being handled here
    image

    Result after fixing all:

    Screen.Recording.2024-03-19.at.13.10.58.mov
  6. MitchExpensify commented on Mar 19, 2024

    @MitchExpensify
    Contributor

    Assigning to VSB as this is a personal account issue more in line with off workspace use

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Mar 25, 2024
  8. melvin-bot commented on Mar 25, 2024

    @melvin-bot
  9. changed the title [-]Wallet - No error when clicking Save & continue button after selecting BA with existing draft[/-] [+][$500] Wallet - No error when clicking Save & continue button after selecting BA with existing draft[/+] on Mar 25, 2024
  10. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Mar 25, 2024
  11. melvin-bot commented on Mar 25, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

  12. 31 remaining items

  13. changed the title [-][$500] Wallet - No error when clicking Save & continue button after selecting BA with existing draft[/-] [+][Pay 4/29][$500] Wallet - No error when clicking Save & continue button after selecting BA with existing draft[/+] on Apr 24, 2024
  14. melvin-bot commented on Apr 25, 2024

    @melvin-bot

    This issue has not been updated in over 15 days. @cubuspl42, @Gonals, @MitchExpensify, @bernhardoj eroding to Monthly issue.

    P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

  15. MitchExpensify commented on Apr 25, 2024

    @MitchExpensify
    Contributor

    Reminder set to pay on 4/29

    Payment summary:

    $500 Contributor @bernhardoj
    $500 C+ @cubuspl42

  16. melvin-bot commented on May 3, 2024

    @melvin-bot

    @cubuspl42, @Gonals, @MitchExpensify, @bernhardoj Whoops! This issue is 2 days overdue. Let's get this updated quick!

  17. MitchExpensify commented on May 6, 2024

    @MitchExpensify
    Contributor

    Paid and contract ended, apologies for the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions