Repository navigation
[TS migration] Migrate 'AddPersonalBankAccount' page - #34430
techievivek merged 9 commits into
Conversation
|
@cubuspl42 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
I agree one is enough
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeAddPersonalBankAccount-page-ts-android-web-compressed.mp4iOS: NativeAddPersonalBankAccount-page-ts-ios-compressed.mp4iOS: mWeb SafariAddPersonalBankAccount-page-ts-ios-web-compressed.mp4MacOS: Desktop |
jakub-trzebiatowski
left a comment
There was a problem hiding this comment.
Please merge main, and we're good
|
@cubuspl42 Merged main |
|
Hello @techievivek, just pinging you to remind you about this PR, maybe it was lost on the workload. Thank you! |
|
Hello @mountiny, Can you please help this going through? |
|
@ruben-rebelo Can you please sync with main and retest? I believe @techievivek has been ooo and should be back this week I will ping him |
|
Sorry for the delay in the reviews since I was ooo.
Can you please follow this and I will review it today, thanks. |
882f9fc to
2b619ce
Compare
2b619ce to
8bd566b
Compare
|
Hello @techievivek, No problem at all! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Cherry-picked to staging by https://github.com/francoisl in version: 1.4.33-5 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
🚀 Deployed to staging by https://github.com/techievivek in version: 1.4.34-0 🚀
|
|
🚀 Deployed to staging by https://github.com/techievivek in version: 1.4.34-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.4.34-1 🚀
|

Details
[TS migration] Migrate AddPersonalBankAccount page to TypeScript
Fixed Issues
$ #25177
PROPOSAL: N/A
Tests
Test AddPersonalBankAccount:
Offline tests
N/A
QA Steps
Same as in the Tests section.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android-native.mov
Android: mWeb Chrome
android-web-c.mp4
iOS: Native
ios-native-c.mp4
iOS: mWeb Safari
ios-web-c.mp4
MacOS: Chrome / Safari
macos-web.mov
MacOS: Desktop
macos-native-c.mp4