Skip to content

[HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] Chat - Parent msgs disappear after back from thread by clicking header/browser back button #39277

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.58-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+ki3@applause.expensifail.com
Issue reported by: Applause - Internal Team

Issue found when executing PR #38978

Action Performed:

  1. Navigate to ND site & login
  2. Open any report
  3. Send some messages (around 6-7 messages)
  4. Hover over the 3rd or 4th parent message and click on Reply in thread
  5. Click on <<user's from>> link in header
  6. Hover over the same parent message (which is already highlighted)
  7. Click on reply in thread
  8. Go back to the main chat by back button browser or back button in header

Expected Result:

All parent messages should display in main chat after going back from thread by clicking header back button or browser back button

Actual Result:

All Parent messages below the message accessed to reply in thread disappear in main chat after back from thread by clicking header/browser back button

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6431843_1711732467563.Recording__116.mp4

View all open jobs on GitHub

Activity

  1. github-actions commented on Mar 29, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    Triggered auto assignment to @cead22 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. lanitochka17 commented on Mar 29, 2024

    @lanitochka17
    Author

    @cead22 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. lanitochka17 commented on Mar 29, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-vsp

  5. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  6. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  7. melvin-bot commented on Mar 29, 2024

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  8. rayane-d commented on Mar 29, 2024

    @rayane-d
    Contributor

    Partial revert merged

  9. removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Mar 29, 2024
  10. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Apr 2, 2024
  11. changed the title [-]Chat - Parent msgs disappear after back from thread by clicking header/browser back button[/-] [+][HOLD for payment 2024-04-09] Chat - Parent msgs disappear after back from thread by clicking header/browser back button[/+] on Apr 2, 2024
  12. melvin-bot commented on Apr 2, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Apr 2, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-09. 🎊

  14. changed the title [-][HOLD for payment 2024-04-09] Chat - Parent msgs disappear after back from thread by clicking header/browser back button[/-] [+][HOLD for payment 2024-04-15] [HOLD for payment 2024-04-09] Chat - Parent msgs disappear after back from thread by clicking header/browser back button[/+] on Apr 8, 2024
  15. melvin-bot commented on Apr 8, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-15. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions