You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[MEDIUM] [Group Chats] Thread - Invited thread member can click on "Thread" when they are not a member of main chat #39331
Version Number: 1.4.58-4 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Go to staging.new.expensify.com
Go to FAB > Start chat
Create a group chat with User B and C
Send a message in group chat
Right click on the message > Reply in thread
Mention User D and invite User D from Concierge whisper
As User D, navigate to the thread
As User D, click on the blue "Thread" above the parent message
Expected Result:
Since User D is not in the group chat, the blue "Thread" should be disabled
Actual Result:
The blue "Thread" is not disabled and it is clickable, which leads to not here page.
When returning to thread after clicking on the Thread button, the header subtitle shows "From" with empty destination
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@pecanoro FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
changed the title [-]Thread - Invited thread member can click on "Thread" when they are not a member of main chat[/-][+][MEDIUM] [Group Chats] Thread - Invited thread member can click on "Thread" when they are not a member of main chat[/+]on Apr 2, 2024
This issue has not been updated in over 15 days. @pecanoro eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
changed the title [-][MEDIUM] [Group Chats] Thread - Invited thread member can click on "Thread" when they are not a member of main chat[/-][+][HOLD auth 384761] [MEDIUM] [Group Chats] Thread - Invited thread member can click on "Thread" when they are not a member of main chat[/+]on Apr 29, 2024
changed the title [-][HOLD auth 384761] [MEDIUM] [Group Chats] Thread - Invited thread member can click on "Thread" when they are not a member of main chat[/-][+][MEDIUM] [Group Chats] Thread - Invited thread member can click on "Thread" when they are not a member of main chat[/+]on May 28, 2024
Activity
github-actions commentedon Mar 31, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Mar 31, 2024
Triggered auto assignment to @pecanoro (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.lanitochka17 commentedon Mar 31, 2024
@pecanoro FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Mar 31, 2024
We think that this bug might be related to #vip-vsp
pecanoro commentedon Apr 1, 2024
Posted here #39343 since I think we are fixing it there.
marcaaron commentedon Apr 1, 2024
I'm a little confused about this bug report. It seems similar to #39333 in that:
marcaaron commentedon Apr 1, 2024
Posted here
marcaaron commentedon Apr 1, 2024
The outcome seems to be that we can remove the blocker for now and plan how this will work.
4 remaining items
marcaaron commentedon Apr 2, 2024
I think it's ok to keep fixing this, but heads up I created an issue here for some backend changes to make this work correctly.
[-]Thread - Invited thread member can click on "Thread" when they are not a member of main chat[/-][+][MEDIUM] [Group Chats] Thread - Invited thread member can click on "Thread" when they are not a member of main chat[/+]pecanoro commentedon Apr 3, 2024
@marcaaron Did you mean to add the
Reviewinglabel or only thePlanningone?marcaaron commentedon Apr 4, 2024
Oh it was already on, sorry. I accidentally removed it then put it back. And meant to add only the
Planninglabel and removeDeployBlockerlabels.melvin-bot commentedon Apr 26, 2024
This issue has not been updated in over 15 days. @pecanoro eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
[-][MEDIUM] [Group Chats] Thread - Invited thread member can click on "Thread" when they are not a member of main chat[/-][+][HOLD auth 384761] [MEDIUM] [Group Chats] Thread - Invited thread member can click on "Thread" when they are not a member of main chat[/+][-][HOLD auth 384761] [MEDIUM] [Group Chats] Thread - Invited thread member can click on "Thread" when they are not a member of main chat[/-][+][MEDIUM] [Group Chats] Thread - Invited thread member can click on "Thread" when they are not a member of main chat[/+]pecanoro commentedon May 28, 2024
I can't reproduce this one anymore so I am going to close