You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Thread - "Report no longer exists" when sending message in thread as invited user #39333
Version Number: 1.4.58-4 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
Action Performed:
Go to staging.new.expensify.com
Go to FAB > Start chat
Create a group chat with two users
Send a message in group chat
Right click on message > Reply in thread
Invite another user to the thread via mention
As the invited user, navigate to the thread
Send a message to the thread
Dismiss the error
Refresh the thread as group creator and invited thread member
Expected Result:
In Step 8, the invited member should be able to send a message to thread without error
Actual Result:
In Step 8, "Report no longer exists" when sending message in thread as invited user when the thread comes from a group chat.
After refreshing the page, the message is sent and appears for both group creator and invited member
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Ok, so based on that thread the expected behavior for this is gonna be:
People should be able to invite other people to DM or Group Chat threads.
If that happens we should treat this the same way as we do a “private” workspace room. Namely, the invited member can only see the parent report action and only the ancestry of threads that they are a member of.
They should be able to invite other people to these threads freely regardless of membership in the top level chat.
I'm going to close this out and create an Expensify/Expensify issue since this will require some backend changes.
Activity
github-actions commentedon Mar 31, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Mar 31, 2024
Triggered auto assignment to @amyevans (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.amyevans commentedon Apr 1, 2024
I verified I can reproduce in staging. Here are logs for the AddComment request with the error: https://www.expensify.com/_devportal/tools/logSearch/#query=request_id:(%2286d99c70b9678f9f-BOS%22)+AND+timestamp:[2024-04-01T14:28:51.871Z+TO+2024-04-01T16:28:51.871Z]&index=logs_expensify-027594
Since it's related to Group Chats, going to hand it off to @marcaaron 🙇
marcaaron commentedon Apr 1, 2024
🤔 this is not really supported yet
marcaaron commentedon Apr 1, 2024
Or maybe it should be?! I tried to do this on a DM and it worked 🤔
marcaaron commentedon Apr 1, 2024
Ah no this doesn't work for a DM either. I'm not sure if this is a blocker. I think it's just not supported or maybe only partially works.
@jasperhuangg do you know if people can be invited to DM threads via the actionable mention whisper?
marcaaron commentedon Apr 1, 2024
This is not really true. I tried to leave a comment on a thread in a DM after getting invited to it and it does not work on production.
marcaaron commentedon Apr 1, 2024
Gonna stay assigned for now but this feels more
New FeaturethanBugto me.melvin-bot commentedon Apr 1, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
marcaaron commentedon Apr 1, 2024
More context about why the Deploy Blocker label was removed can be found here.
marcaaron commentedon Apr 2, 2024
Ok, so based on that thread the expected behavior for this is gonna be:
I'm going to close this out and create an Expensify/Expensify issue since this will require some backend changes.
marcaaron commentedon Apr 2, 2024
Moved to https://github.com/Expensify/Expensify/issues/384761