Skip to content

Thread - "Report no longer exists" when sending message in thread as invited user #39333

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.58-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to FAB > Start chat
  3. Create a group chat with two users
  4. Send a message in group chat
  5. Right click on message > Reply in thread
  6. Invite another user to the thread via mention
  7. As the invited user, navigate to the thread
  8. Send a message to the thread
  9. Dismiss the error
  10. Refresh the thread as group creator and invited thread member

Expected Result:

In Step 8, the invited member should be able to send a message to thread without error

Actual Result:

In Step 8, "Report no longer exists" when sending message in thread as invited user when the thread comes from a group chat.
After refreshing the page, the message is sent and appears for both group creator and invited member

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6432878_1711831921117.20240331_044805.mp4

View all open jobs on GitHub

Activity

  1. github-actions commented on Mar 31, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Mar 31, 2024

    @melvin-bot

    Triggered auto assignment to @amyevans (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. amyevans commented on Apr 1, 2024

    @amyevans
    Contributor

    I verified I can reproduce in staging. Here are logs for the AddComment request with the error: https://www.expensify.com/_devportal/tools/logSearch/#query=request_id:(%2286d99c70b9678f9f-BOS%22)+AND+timestamp:[2024-04-01T14:28:51.871Z+TO+2024-04-01T16:28:51.871Z]&index=logs_expensify-027594

    Since it's related to Group Chats, going to hand it off to @marcaaron 🙇

  4. marcaaron commented on Apr 1, 2024

    @marcaaron
    Contributor

    Invite another user to the thread via mention

    🤔 this is not really supported yet

  5. marcaaron commented on Apr 1, 2024

    @marcaaron
    Contributor

    Or maybe it should be?! I tried to do this on a DM and it worked 🤔

  6. marcaaron commented on Apr 1, 2024

    @marcaaron
    Contributor

    Ah no this doesn't work for a DM either. I'm not sure if this is a blocker. I think it's just not supported or maybe only partially works.

    @jasperhuangg do you know if people can be invited to DM threads via the actionable mention whisper?

  7. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 1, 2024
  8. marcaaron commented on Apr 1, 2024

    @marcaaron
    Contributor

    Reproducible in production?: N

    This is not really true. I tried to leave a comment on a thread in a DM after getting invited to it and it does not work on production.

  9. marcaaron commented on Apr 1, 2024

    @marcaaron
    Contributor

    Gonna stay assigned for now but this feels more New Feature than Bug to me.

  10. melvin-bot commented on Apr 1, 2024

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  11. marcaaron commented on Apr 1, 2024

    @marcaaron
    Contributor

    More context about why the Deploy Blocker label was removed can be found here.

  12. marcaaron commented on Apr 2, 2024

    @marcaaron
    Contributor

    Ok, so based on that thread the expected behavior for this is gonna be:

    • People should be able to invite other people to DM or Group Chat threads.
    • If that happens we should treat this the same way as we do a “private” workspace room. Namely, the invited member can only see the parent report action and only the ancestry of threads that they are a member of.
    • They should be able to invite other people to these threads freely regardless of membership in the top level chat.

    I'm going to close this out and create an Expensify/Expensify issue since this will require some backend changes.

  13. marcaaron commented on Apr 2, 2024

    @marcaaron
    Contributor
  14. removed their assignment
    on Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions