Skip to content

[$500] [HOLD for payment 2024-05-08] CRITICAL: [Send invoice] Implement Send Invoice flow from Global Create #40012

Closed

Description

@cristipaval

Part of the Invoicing V0.1 project

Main issue: https://github.com/Expensify/Expensify/issues/341717
Doc section: Invoicing V1
Project: #vip-billpay

Feature Description

Send Invoice from Global Create

Manual Test Steps

Automated Tests

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e31d2e6653cca734
  • Upwork Job ID: 1788335672367525888
  • Last Price Increase: 2024-05-08

Activity

  1. melvin-bot commented on Apr 10, 2024

    @melvin-bot

    Triggered auto assignment to @alexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

  2. melvin-bot commented on Apr 10, 2024

    @melvin-bot

    ⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

  3. VickyStash commented on Apr 10, 2024

    @VickyStash
    Contributor

    Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

  4. VickyStash commented on Apr 11, 2024

    @VickyStash
    Contributor

    Updates:

    • Updated IOU steps to support invoices flow: start, participants, confirmation.
    • Implemented a new Send from screen to support invoice sender updates.
    • Implemented building of optimistic data for SendInvoice api request, as well as preparing params/onyx updates, but it's not tested yet

    TODOs:

    • Resolve some left TODOs
    • Fix lint and TS issues
    • Improve invoice room chat creation (still need a final decision regarding receiver info storage)
    • Do UI improvements
    • Test the flow in different scenarios on different platforms and make improvements where necessary
    Screenshots/recordings
    web12.mp4
  5. VickyStash commented on Apr 12, 2024

    @VickyStash
    Contributor

    Updates:

    • resolved TS-related issues
    • fixed invoice creation from global create in case invoice room report for sender/receiver already exists
    • implemented function for invite report action optimistic building
    • resolved left TODOs for send invoice functionality
    • tested functionality on web using offline mode

    TODOs:

    • confirm all Spanish translations
    • fix lint issues
    • do UI improvements
    • test the flow in different scenarios on mobile platforms and make improvements where necessary
    • check the implementation using staging API endpoints (can be done when API is deployed)
  6. 43 remaining items

  7. melvin-bot commented on May 8, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @VickyStash is from an agency-contributor and not due payment
    • C+: @shubham1206agra paid $500 via Upwork (LINK)-- there is regression, but this C+ was involved after for the clean up.

    BugZero Checklist (@alexpensify)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on May 8, 2024
  9. changed the title [-][HOLD for payment 2024-05-08] CRITICAL: [Send invoice] Implement Send Invoice flow from Global Create[/-] [+][$250] [HOLD for payment 2024-05-08] CRITICAL: [Send invoice] Implement Send Invoice flow from Global Create[/+] on May 8, 2024
  10. melvin-bot commented on May 8, 2024

    @melvin-bot
  11. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on May 8, 2024
  12. melvin-bot commented on May 8, 2024

    @melvin-bot

    Current assignee @shubham1206agra is eligible for the External assigner, not assigning anyone new.

  13. changed the title [-][$250] [HOLD for payment 2024-05-08] CRITICAL: [Send invoice] Implement Send Invoice flow from Global Create[/-] [+][$500] [HOLD for payment 2024-05-08] CRITICAL: [Send invoice] Implement Send Invoice flow from Global Create[/+] on May 8, 2024
  14. melvin-bot commented on May 8, 2024

    @melvin-bot

    Upwork job price has been updated to $500

  15. alexpensify commented on May 8, 2024

    @alexpensify
    Contributor

    @shubham1206agra - please accept the Upwork invite and I can complete the payment process. Thanks!

  16. shubham1206agra commented on May 9, 2024

    @shubham1206agra
    Contributor

    @alexpensify Accepted.

  17. alexpensify commented on May 9, 2024

    @alexpensify
    Contributor

    Thanks! I've completed the payment process in Upwork and am going to close this GH now.

  18. Krishna2323 commented on Sep 22, 2026

    @Krishna2323
    Contributor

    Heads up: the send-invoice flow implemented here caused #97203. receiverEmail was sent as a raw phone number, never normalized with addSMSDomainIfPhoneNumber() like every sibling flow does, so the backend rejected it with Invalid invoice receiver and the invoice room got stuck on a skeleton loader. Fixed in #100892.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsNewFeatureSomething to build that is a new item.

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions