Skip to content

Normalize phone receiver login with SMS domain in SendInvoice - #100892

Merged
luacmartins merged 10 commits into
Expensify:mainfrom
ashu75575:issue-97203
Sep 14, 2026
Merged

luacmartins merged 10 commits into
Expensify:mainfrom
ashu75575:issue-97203

Conversation

@ashu75575

@ashu75575 ashu75575 commented Sep 10, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

SendInvoice was sending a raw phone number (e.g., +918375818761) as receiverEmail instead of the normalized SMS login (+918375818341@expensify.sms). Every sibling flow (SendMoney, Split, PerDiem, MoneyRequestBuilder) normalizes phone receivers through addSMSDomainIfPhoneNumber, but SendInvoice was the outlier.

Without the @expensify.sms domain, Auth returns { "jsonCode": 666, "message": "Invalid invoice receiver" }, which triggers failureData and writes errorFields.createChat on the optimistic invoice room.

Changes:

  1. Imported addSMSDomainIfPhoneNumber from @libs/PhoneNumber in SendInvoice.ts.
  2. Normalized the receiver login by extracting and hoisting addSMSDomainIfPhoneNumber(receiverParticipant.login) so that it applies uniformly whether we are creating an optimistic personal detail or falling back on an existing participant.
  3. Added unit test should normalize phone receiver login with SMS domain to verify that API.write is called with the correctly formatted receiverEmail (e.g., +918375818761@expensify.sms).

Fixed Issues

$ #97203
PROPOSAL: #97203

Tests

  1. Set up a workspace and send an invoice to a recipient's phone number (e.g. +918375818761) who has no existing Expensify account
  2. Verify the invoice is sent without the "Unexpected error creating this chat…" error banner
  3. Verify the invoice room is created and visible without an infinite loading skeleton
  • Verify that no errors appear in the JS console

Offline tests

  1. Turn off your network connection
  2. Log in as a workspace admin and navigate to New Invoice
  3. Send an invoice to a phone number recipient (user with no Expensify account)
  4. Verify the optimistic invoice room and report appear immediately with no skeleton or error state
  5. Turn the network back on
  6. Verify the invoice room resolves correctly — no error message and no lingering skeleton

QA Steps

  1. Log in as a workspace admin on staging
  2. Navigate to New Invoice and enter a recipient's phone number (a user with no Expensify account)
  3. Fill in invoice details (amount, merchant, date) and tap Send
  4. Verify the invoice is sent successfully — no "Unexpected error" banner on the invoice room
  5. Verify the invoice room loads correctly without an infinite skeleton
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2026-09-11.at.5.40.09.PM.mov
Android: mWeb Chrome
Screen.Recording.2026-09-11.at.7.20.00.PM.mov
iOS: Native
Screen.Recording.2026-09-11.at.6.24.12.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-09-11.at.7.34.36.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-09-11.at.7.28.28.PM.mov

ashu75575 and others added 4 commits September 11, 2026 02:51
SendInvoice was sending raw phone numbers (e.g. +918375818341) as
receiverEmail instead of the normalized SMS login (+918375818341@expensify.sms).
This caused Auth to return 'Invalid invoice receiver' (jsonCode 666),
triggering failure data and an error banner on the optimistic invoice room.

- Import addSMSDomainIfPhoneNumber in SendInvoice.ts
- Normalize receiver.login via addSMSDomainIfPhoneNumber in getSendInvoiceInformation
  for both optimistic personal details and existing participant flows
- Normalize receiverEmail API parameter in sendInvoice
- Add unit test verifying phone receiver login gets SMS domain appended
@ashu75575 ashu75575 changed the title Fixes Issue 97203- Normalize phone receiver login with SMS domain in SendInvoice Normalize phone receiver login with SMS domain in SendInvoice Sep 10, 2026
@ashu75575
ashu75575 marked this pull request as ready for review September 11, 2026 14:08
@ashu75575
ashu75575 requested review from a team as code owners September 11, 2026 14:08
@melvin-bot
melvin-bot Bot requested review from Krishna2323 and joekaufmanexpensify and removed request for a team September 11, 2026 14:08
@melvin-bot

melvin-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed request for a team and joekaufmanexpensify September 11, 2026 14:08
@codecov

codecov Bot commented Sep 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/libs/actions/IOU/SendInvoice.ts 93.18% <100.00%> (+0.10%) ⬆️
... and 9 files with indirect coverage changes

@Krishna2323

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
android_hybrid.mp4
Android: mWeb Chrome
android_mWeb.mp4
iOS: HybridApp
ios_hybrid.mp4
iOS: mWeb Safari
ios_mWeb.mp4
MacOS: Chrome / Safari
web_chrome.mp4

@Krishna2323 Krishna2323 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@melvin-bot
melvin-bot Bot requested a review from luacmartins September 14, 2026 14:26
@luacmartins
luacmartins merged commit b472214 into Expensify:main Sep 14, 2026
35 of 37 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 luacmartins has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.4.78-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

MelvinBot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

🤖 No help site changes are required for this PR, so I did not create a draft docs PR.

Why: This is a bug fix with no user-facing behavior or copy change. It normalizes a phone receiver's login to the SMS format (+1555…@expensify.sms) before sending receiverEmail to SendInvoice, matching what SendMoney, Split, and PerDiem already do. The user-facing flow is unchanged — sending an invoice to a phone number simply now works instead of erroring.

The help site already documents phone recipients as supported, so the docs described the intended behavior all along:

What I checked
  • The full PR diff: only src/libs/actions/IOU/SendInvoice.ts (4 added / 1 removed) and a new unit test. No new settings, toggles, buttons, labels, or entry points.
  • Every file under docs/articles mentioning invoices, for both New Expensify and Expensify Classic. No article claims phone recipients are unsupported, and none describes an error state this fix removes.
  • No article documents the @expensify.sms normalization — that is an internal implementation detail and does not belong on the help site per HELP_AUTHORING_GUIDELINES.md.

If you'd still like a docs update — for example, an FAQ entry clarifying that phone recipients receive invoices by text — reply with @MelvinBot and what you want covered, and I'll open the draft PR.

@ashu75575, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review


view run · no recording available

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.78-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants