You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-05-02] Scan - "Let it go" copy is not centered when dragging and dropping a file to Scan RHP #40539
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@bfitzexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
Please re-state the problem that we are trying to solve in this issue.
"Let it go" copy is not centered when dragging and dropping a file to Scan RHP
What is the root cause of that problem?
The Let it go image's container has absolute position and we get the top of Upload Receipt image's container and set to "Let it go" image's container. But we do not calculate that the parent of Upload Receipt image's container does not have full screen height but the parent of Let it go image's container has full screen height
What changes do you think we should make in order to solve the problem?
changed the title [-]Scan - "Let it go" copy is not centered when dragging and dropping a file to Scan RHP[/-][+][HOLD for payment 2024-05-02] Scan - "Let it go" copy is not centered when dragging and dropping a file to Scan RHP[/+]on Apr 25, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@MonilBhavsar] The PR that introduced the bug has been identified. Link to the PR:
[@MonilBhavsar] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@MonilBhavsar] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@MonilBhavsar] Determine if we should create a regression test for this bug.
[@MonilBhavsar] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
Activity
melvin-bot commentedon Apr 19, 2024
Triggered auto assignment to @danieldoglas (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 19, 2024
Triggered auto assignment to @bfitzexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Apr 19, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
izarutskaya commentedon Apr 19, 2024
@bfitzexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
izarutskaya commentedon Apr 19, 2024
We think this issue might be related to the #collect project.
izarutskaya commentedon Apr 19, 2024
Production
shahinyan11 commentedon Apr 19, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
"Let it go" copy is not centered when dragging and dropping a file to Scan RHP
What is the root cause of that problem?
The
Let it goimage's container hasabsoluteposition and we get the top ofUpload Receiptimage's container and set to "Let it go" image's container. But we do not calculate that the parent ofUpload Receiptimage's container does not have full screen height but the parent ofLet it goimage's container has full screen heightWhat changes do you think we should make in order to solve the problem?
Remove this style form image container
What alternative solutions did you explore?
Change nativeEvent.layout.y to
nativeEvent.layout.top13 remaining items
thienlnam commentedon Apr 20, 2024
It's not centered - but not breaking the app in any way so demoting
[-]Scan - "Let it go" copy is not centered when dragging and dropping a file to Scan RHP[/-][+][HOLD for payment 2024-05-02] Scan - "Let it go" copy is not centered when dragging and dropping a file to Scan RHP[/+]melvin-bot commentedon Apr 25, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 25, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-05-02. 🎊
melvin-bot commentedon Apr 25, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
melvin-bot commentedon May 2, 2024
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
MonilBhavsar commentedon May 2, 2024
No action required