Skip to content

[HOLD for payment 2024-05-02] Scan - "Let it go" copy is not centered when dragging and dropping a file to Scan RHP #40539

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.63-5
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4494504
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to FAB > Submit request > Scan.
  3. Drag and drop a file to the Scan RHP.

Expected Result:

"Let it go" copy is centered when dragging and dropping a file to Scan RHP.

Actual Result:

"Let it go" copy is not centered when dragging and dropping a file to Scan RHP.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6454413_1713492432352.20240419_100401.mp4
Bug6454413_1713492432338!Screenshot_2024-04-19_at_10 04 42

View all open jobs on GitHub

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 19, 2024
  2. melvin-bot commented on Apr 19, 2024

    @melvin-bot

    Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Apr 19, 2024

    @melvin-bot

    Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. github-actions commented on Apr 19, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. izarutskaya commented on Apr 19, 2024

    @izarutskaya
    Author

    @bfitzexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on Apr 19, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #collect project.

  7. izarutskaya commented on Apr 19, 2024

    @izarutskaya
    Author

    Production

    image (9)

  8. shahinyan11 commented on Apr 19, 2024

    @shahinyan11

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    "Let it go" copy is not centered when dragging and dropping a file to Scan RHP

    What is the root cause of that problem?

    The Let it go image's container has absolute position and we get the top of Upload Receipt image's container and set to "Let it go" image's container. But we do not calculate that the parent of Upload Receipt image's container does not have full screen height but the parent of Let it go image's container has full screen height

    What changes do you think we should make in order to solve the problem?

    Remove this style form image container

    What alternative solutions did you explore?

    Change nativeEvent.layout.y to nativeEvent.layout.top

  9. 13 remaining items

  10. thienlnam commented on Apr 20, 2024

    @thienlnam
    Contributor

    It's not centered - but not breaking the app in any way so demoting

  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Apr 25, 2024
  12. changed the title [-]Scan - "Let it go" copy is not centered when dragging and dropping a file to Scan RHP[/-] [+][HOLD for payment 2024-05-02] Scan - "Let it go" copy is not centered when dragging and dropping a file to Scan RHP[/+] on Apr 25, 2024
  13. melvin-bot commented on Apr 25, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  14. melvin-bot commented on Apr 25, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-05-02. 🎊

  15. melvin-bot commented on Apr 25, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@MonilBhavsar] The PR that introduced the bug has been identified. Link to the PR:
    • [@MonilBhavsar] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@MonilBhavsar] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@MonilBhavsar] Determine if we should create a regression test for this bug.
    • [@MonilBhavsar] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  16. melvin-bot commented on May 2, 2024

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

  17. MonilBhavsar commented on May 2, 2024

    @MonilBhavsar
    Contributor

    No action required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions