Repository navigation
Fix: "Let it go" copy is not centered when dragging and dropping a file to Scan RHP - #40545
Conversation
|
@codinggeek2023 Could you explain why the issue occurred in the first place? I'm not convinced that this is the root cause of the problem because the style on the view existed prior to the conversion to TypeScript. |
|
One other option is we put a |
MonilBhavsar
left a comment
There was a problem hiding this comment.
Can you update title to meaningful phrase please
Do we want to do go this way? |
|
Okay, I tested and looks like this is still not a ideal fix. The image before drop and while dropping should have same position, which is not the case with this branch |
|
@MonilBhavsar , I think we need to follow the pattern we used in native where App/src/pages/iou/request/step/IOURequestStepScan/index.tsx Lines 101 to 102 in 305f12c |
I tested if we use top here and put an exception then we get the ui drop at the exact same place: Screen.Recording.2024-04-19.at.4.28.01.PM.mov |
Looking...
I don't think that's the ideal way |
|
Okay, I tried if we can derive top from other properties of layout object, but no dice |
|
pushed the latest changes @akinwale @MonilBhavsar :) |
| <> | ||
| <View onLayout={({nativeEvent}) => setReceiptImageTopPosition(PixelRatio.roundToNearestPixel(nativeEvent.layout.y))}> | ||
| <View | ||
| // @ts-expect-error `LayoutChangeEvent` doesn't contain a `top` property, but it is needed in the code to set the position of the receipt image |
There was a problem hiding this comment.
LayoutChangeEventdoesn't contain atopproperty
This is not true. It has a top property but not defined in the types(I haven't closely looked at this)
|
@codinggeek2023 Please update the PR based on https://expensify.slack.com/archives/C01GTK53T8Q/p1713539777823679?thread_ts=1712578137.578349&cid=C01GTK53T8Q as that's a much cleaner approach. Thanks. |
|
I did go through the conversation, i’m out currently, will update the
latest changes As soon as I get back to my laptop
…On Fri, Apr 19, 2024 at 9:37 PM Akinwale Ariwodola ***@***.***> wrote:
@codinggeek2023 <https://github.com/codinggeek2023> Please update the PR
based on
https://expensify.slack.com/archives/C01GTK53T8Q/p1713539777823679?thread_ts=1712578137.578349&cid=C01GTK53T8Q
as that's a much cleaner approach. Thanks.
—
Reply to this email directly, view it on GitHub
<#40545 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BFJXGIZBNPYROJICP23AF3LY6E6MJAVCNFSM6AAAAABGO4UFDSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRWHA3TMNBRGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.4.65-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.65-5 🚀
|


Details
Fixed Issues
$ #40539
$ #32000 (comment)
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
MacOS: Chrome / Safari
323932364-01479404-684f-4264-8966-a70b3aa8dd12.mov
MacOS: Desktop
Screen.Recording.2024-04-19.at.3.48.45.PM.mov
Android: Native
Cannot drag and drop on this deviceAndroid: mWeb Chrome
Cannot drag and drop on this deviceiOS: Native
Cannot drag and drop on this deviceiOS: mWeb Safari
Cannot drag and drop on this device