You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Track expense- Unable to close Track expense RHP with ESC key after dismissing education modal #41134
Issue found when validating #40675 Version Number: 1.4.67-0 Reproducible in staging?: y Reproducible in production?: n If this was caught during regression testing, add the test name, ID and link from TestRail: n/a Email or phone of affected tester (no customers): Logs:https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause internal team Slack conversation:
Action Performed:
Go to staging.new.expensify.com
Go to FAB.
Select Track Expense.
Press ESC to dismiss the education modal.
Press ESC again.
Expected Result:
Track expense RHP will be dismissed.
Actual Result:
Unable to dismiss Track expense RHP with ESC key after dismissing the education modal.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
Based on the history in this issue it looks like this issue was never linked in the PR which is probably why the automation failed? @rushatgabhane@dragnoir Do you guys mind updating the PR to link this issue please?
@lschurr I think we just need to pay out @allroundexperts and close this out. They reviewed proposals for this issue. Since something went wrong with the Github automation then they couldn't have done anything differently.
Activity
melvin-bot commentedon Apr 27, 2024
Triggered auto assignment to @youssef-lr (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 27, 2024
Triggered auto assignment to @lschurr (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.github-actions commentedon Apr 27, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
m-natarajan commentedon Apr 27, 2024
@lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
m-natarajan commentedon Apr 27, 2024
We think this bug might be related to #vip-vsb
thienlnam commentedon Apr 28, 2024
Doesn't seem like it needs to be a blocker
58 remaining items
jasperhuangg commentedon Jul 20, 2024
Based on the history in this issue it looks like this issue was never linked in the PR which is probably why the automation failed? @rushatgabhane @dragnoir Do you guys mind updating the PR to link this issue please?
cc @thienlnam
jasperhuangg commentedon Jul 20, 2024
Not overdue just sorting out some payment/automation weirdness
lschurr commentedon Jul 22, 2024
Just a bump on this @jasperhuangg @thienlnam
jasperhuangg commentedon Jul 22, 2024
@lschurr I think we just need to pay out @allroundexperts and close this out. They reviewed proposals for this issue. Since something went wrong with the Github automation then they couldn't have done anything differently.
mallenexpensify commentedon Jul 22, 2024
I think 50% for payment to @allroundexperts makes sense, since they only reviewed the initial proposals and didn't have to work on and test the PR.
allroundexperts commentedon Jul 22, 2024
Agreed with Matt!
lschurr commentedon Jul 22, 2024
Great, I updated the payment summary here: #41134 (comment)
lschurr commentedon Jul 25, 2024
Closing since the payment summary is complete.
JmillsExpensify commentedon Aug 21, 2024
$125 approved for @allroundexperts