Skip to content

[$250] Track expense- Unable to close Track expense RHP with ESC key after dismissing education modal #41134

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when validating #40675
Version Number: 1.4.67-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to FAB.
  3. Select Track Expense.
  4. Press ESC to dismiss the education modal.
  5. Press ESC again.

Expected Result:

Track expense RHP will be dismissed.

Actual Result:

Unable to dismiss Track expense RHP with ESC key after dismissing the education modal.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6463572_1714204673665.20240427_155503.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e2861236b6929afb
  • Upwork Job ID: 1784977082974711808
  • Last Price Increase: 2024-04-29
Issue OwnerCurrent Issue Owner: @lschurr

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 27, 2024
  2. melvin-bot commented on Apr 27, 2024

    @melvin-bot

    Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Apr 27, 2024

    @melvin-bot

    Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. github-actions commented on Apr 27, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. m-natarajan commented on Apr 27, 2024

    @m-natarajan
    Author

    @lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. m-natarajan commented on Apr 27, 2024

    @m-natarajan
    Author

    We think this bug might be related to #vip-vsb

  7. thienlnam commented on Apr 28, 2024

    @thienlnam
    Contributor

    Doesn't seem like it needs to be a blocker

  8. 58 remaining items

  9. jasperhuangg commented on Jul 20, 2024

    @jasperhuangg
    Contributor

    Based on the history in this issue it looks like this issue was never linked in the PR which is probably why the automation failed? @rushatgabhane @dragnoir Do you guys mind updating the PR to link this issue please?

    cc @thienlnam

  10. jasperhuangg commented on Jul 20, 2024

    @jasperhuangg
    Contributor

    Not overdue just sorting out some payment/automation weirdness

  11. lschurr commented on Jul 22, 2024

    @lschurr
    Contributor

    Just a bump on this @jasperhuangg @thienlnam

  12. jasperhuangg commented on Jul 22, 2024

    @jasperhuangg
    Contributor

    @lschurr I think we just need to pay out @allroundexperts and close this out. They reviewed proposals for this issue. Since something went wrong with the Github automation then they couldn't have done anything differently.

  13. mallenexpensify commented on Jul 22, 2024

    @mallenexpensify
    Contributor

    I think 50% for payment to @allroundexperts makes sense, since they only reviewed the initial proposals and didn't have to work on and test the PR.

  14. allroundexperts commented on Jul 22, 2024

    @allroundexperts
    Contributor

    Agreed with Matt!

  15. lschurr commented on Jul 22, 2024

    @lschurr
    Contributor

    Great, I updated the payment summary here: #41134 (comment)

  16. lschurr commented on Jul 25, 2024

    @lschurr
    Contributor

    Closing since the payment summary is complete.

  17. JmillsExpensify commented on Aug 21, 2024

    @JmillsExpensify
    Contributor

    $125 approved for @allroundexperts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions