Repository navigation
Feature: Track expense training modal - #40675
Conversation
|
Hey @rushatgabhane, if you could take a look at this as soon as possible that would be great. We're looking to get this merged by Tuesday. |
|
yes, this is # 1 priority |
|
@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Basically I just reused the onboarding welcome video component. |
|
Adding @Expensify/design here for review as well. We'll swap out the video once that's ready. As for the other parts of the UI, this looks good!
Great move! I think we'd want the same behavior so that works for me. Keen to hear what @Expensify/design team thinks. Especially the centered modal on desktop. |
|
It seems like the padding and button spacing is off. I think there should only be 20px of inner padding in the content area, and I think the button stack might be too close together? It also feels like a lot of space above the checkbox. @dubielzyk-expensify perhaps you can provide the exact desktop mock for this so we have the right guide here? |
|
Agree with Shawn, generally looking good but that button stack is pretty tight. |
|
Hi @tienifr, here is the URL for the |
|
@tienifr could you please resolve merge conflicts |
rushatgabhane
left a comment
There was a problem hiding this comment.
Looks good! Just a few minor comments
Currently the horizontal padding for onboarding welcome video is |
Co-authored-by: Rushat Gabhane <rushatgabhane@gmail.com>
….com/tienifr/App into feature/track-expense-training-modal
|
Awating last design decision:
|
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-04-24.at.15.07.24.movAndroid: mWeb ChromeScreen.Recording.2024-04-24.at.15.13.28.moviOS: NativeScreen.Recording.2024-04-24.at.15.15.07.movScreen.Recording.2024-04-24.at.15.14.44.moviOS: mWeb SafariScreen.Recording.2024-04-24.at.15.16.18.movMacOS: Chrome / SafariScreen.Recording.2024-04-24.at.14.54.43.movScreen.Recording.2024-04-24.at.14.54.28.movMacOS: DesktopScreen.Recording.2024-04-24.at.15.18.43.mov |
I'm curious for @Expensify/design's thoughts—but I don't see why we wouldn't allow all controls? Personally I'd rather them all be available, but I don't want to uproot a strategic decision if it was done for a specific purpose. |
|
Same thoughts here, I would think all of those controls would be available to the user. |
#40675 (comment) @dubielzyk-expensify I wondered if we could make this track traning video and the onboarding video here consistent in aspect ratio (I just thought there should be consistency, shouldn't it??). They're |
|
So this Track video was created mostly for a different use case which is why the aspect ratio is different. I'd ideally want the dialog to load and scale to the video size. If not, I can look into resizing them, but might wanna do that in a follow-up PR cause that means me changing 4 other videos we've made as well. |
|
@dubielzyk-expensify Okay so I guess I should fix it now in this PR.
This is fixed now. |
|
@srikarparsi We're ready for your review. |
|
@tienifr lint looks to be failing. Can you run |
|
@srikarparsi Updated! |
srikarparsi
left a comment
There was a problem hiding this comment.
lgtm thanks @tienifr and @rushatgabhane!
|
🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.4.67-0 🚀
|
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.4.67-7 🚀
|
1 similar comment
|
🚀 Deployed to production by https://github.com/francoisl in version: 1.4.67-7 🚀
|
| onInputChange={toggleWillShowAgain} | ||
| /> | ||
| )} | ||
| {helpText && ( |
There was a problem hiding this comment.
Coming from #45619 (comment), we need to ensure that the left part of a conditional rendering a React component is a boolean and NOT a string









Details
This PR creates a training interstitial when you click Track expense.
Fixed Issues
$ #40156
PROPOSAL: #40156 (comment)
Tests
Don't show me this again>> Press Got itSetNameValuePairAPI is calledOffline tests
Precondition: User has not togggled the
Don't show me this againoption.QA Steps
Don't show me this again>> Press Got itPR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
Screen.Recording.2024-04-22.at.15.57.07-compressed.mov
iOS: Native
Screen.Recording.2024-04-22.at.16.13.12-compressed.mov
iOS: mWeb Safari
Screen.Recording.2024-04-22.at.15.51.21-compressed.mov
MacOS: Chrome / Safari
Untitled.mov
Screen.Recording.2024-04-22.at.14.57.22-compressed.mov
MacOS: Desktop
Screen.Recording.2024-04-22.at.14.59.07-compressed.mov