Skip to content

[HOLD App #43133] Search-Navigating to new search page app crashes #41883

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.72-0
Reproducible in staging?: Y
Reproducible in production?: Unable to check
Email or phone of affected tester (no customers): Reproducible only in this accounts vincenzoddragon@gmail.com, jaihanumanblog@gmail.com, vincenzoddragon+life@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Login with gmail account with many transactions (not a new account)
  3. Tap profile -- troubleshoot
  4. Navigate to new search page

Expected Result:

Navigating to new search page app must not crash.

Actual Result:

Navigating to new search page app crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6475531_1715233311628.crash.mp4

logs.txt

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @Christinadobrzyn

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on May 9, 2024
  2. melvin-bot commented on May 9, 2024

    @melvin-bot

    Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on May 9, 2024

    @melvin-bot

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on May 9, 2024

    @melvin-bot

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

    1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
      • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
    2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
      • You can adjust the urgency of the issue to better represent the gravity of the bug.
      • If the issue is super low priority, feel free to un-assign yourself.
      • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
      • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

    Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

  5. github-actions commented on May 9, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. 24 remaining items

  7. melvin-bot commented on May 23, 2024

    @melvin-bot

    @Julesssss @Christinadobrzyn this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  8. luacmartins commented on May 27, 2024

    @luacmartins
    Contributor

    @kbecciv can you share the test account credentials?

  9. self-assigned this
    on May 27, 2024
  10. luacmartins commented on May 27, 2024

    @luacmartins
    Contributor

    From the latest video, seems like we have an invalid currency here. I wanna take a look at the data we're passing in to confirm where the issue is.

  11. mvtglobally commented on May 30, 2024

    @mvtglobally

    Issue not reproducible during KI retests. (Third week)

  12. Christinadobrzyn commented on Jun 5, 2024

    @Christinadobrzyn
    Contributor

    I'm also not able to reproduce this - @luacmartins can you test and let us know if this can be closed?

  13. Julesssss commented on Jun 5, 2024

    @Julesssss
    Contributor

    I'm not sure where we can locate the PW to these users, but happy to test these.

    I'm not data on the new search page in my personal Gmail account, but I don't get a crash either.

  14. luacmartins commented on Jun 5, 2024

    @luacmartins
    Contributor

    RangeError: Malformed currency code

    It seems like one of the transactions had a bad currency code stored in, which is being handled here and will be fixed in this PR.

  15. changed the title [-]Search-Navigating to new search page app crashes[/-] [+][HOLD App #43133] Search-Navigating to new search page app crashes[/+] on Jun 5, 2024
  16. luacmartins commented on Jun 5, 2024

    @luacmartins
    Contributor

    Let's retest once that PR is merged

  17. mvtglobally commented on Jun 5, 2024

    @mvtglobally

    Issue not reproducible during KI retests. (Fourth week)

  18. luacmartins commented on Jun 5, 2024

    @luacmartins
    Contributor

    I think we are good to close this issue given that we haven't been able to reproduce this in four weeks and we have another issue that solves the currency crash. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.EngineeringNeeds ReproductionReproducible steps neededWeeklyKSv2retest-weeklyApply this label if you want this issue tested on a Weekly basis by Applause

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions