You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD App #43133] Search-Navigating to new search page app crashes #41883
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:
If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
You can adjust the urgency of the issue to better represent the gravity of the bug.
If the issue is super low priority, feel free to un-assign yourself.
Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.
Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@Julesssss@Christinadobrzyn this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
changed the title [-]Search-Navigating to new search page app crashes[/-][+][HOLD App #43133] Search-Navigating to new search page app crashes[/+]on Jun 5, 2024
I think we are good to close this issue given that we haven't been able to reproduce this in four weeks and we have another issue that solves the currency crash. Thanks everyone!
Activity
melvin-bot commentedon May 9, 2024
Triggered auto assignment to @Julesssss (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon May 9, 2024
Triggered auto assignment to @Christinadobrzyn (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon May 9, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:
Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.
github-actions commentedon May 9, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
24 remaining items
melvin-bot commentedon May 23, 2024
@Julesssss @Christinadobrzyn this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
luacmartins commentedon May 27, 2024
@kbecciv can you share the test account credentials?
luacmartins commentedon May 27, 2024
From the latest video, seems like we have an invalid currency here. I wanna take a look at the data we're passing in to confirm where the issue is.
mvtglobally commentedon May 30, 2024
Issue not reproducible during KI retests. (Third week)
Christinadobrzyn commentedon Jun 5, 2024
I'm also not able to reproduce this - @luacmartins can you test and let us know if this can be closed?
Julesssss commentedon Jun 5, 2024
I'm not sure where we can locate the PW to these users, but happy to test these.
I'm not data on the new search page in my personal Gmail account, but I don't get a crash either.
luacmartins commentedon Jun 5, 2024
It seems like one of the transactions had a bad currency code stored in, which is being handled here and will be fixed in this PR.
[-]Search-Navigating to new search page app crashes[/-][+][HOLD App #43133] Search-Navigating to new search page app crashes[/+]luacmartins commentedon Jun 5, 2024
Let's retest once that PR is merged
mvtglobally commentedon Jun 5, 2024
Issue not reproducible during KI retests. (Fourth week)
luacmartins commentedon Jun 5, 2024
I think we are good to close this issue given that we haven't been able to reproduce this in four weeks and we have another issue that solves the currency crash. Thanks everyone!