Skip to content

[HOLD for payment 2024-06-11] [$250] Web - Accounting - Xero - Console error shows up when opening Preferred exporter #42195

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when validating #41641
Version Number: 1.4.74-0
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Precondition:

  • Workspace is connected to Xero.
  1. Go to staging.new.expensify.com
  2. Go to workspace settings.
  3. Go to Accounting.
  4. Go to Export.
  5. Click Preferred exporter.

Expected Result:

No console error will show up.

Actual Result:

Console error shows up.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6481656_1715779259909!staging.new.expensify.com-1715778677003.txt

Bug6481656_1715779259903.bandicam_2024-05-15_21-11-02-900.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f939b9bc571e795d
  • Upwork Job ID: 1791257784808251392
  • Last Price Increase: 2024-05-17
  • Automatic offers:
    • ahmedGaber93 | Reviewer | 0
    • tienifr | Contributor | 0
Issue OwnerCurrent Issue Owner: @twisterdotcom

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on May 15, 2024
  2. github-actions commented on May 15, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on May 16, 2024
  4. melvin-bot commented on May 16, 2024

    @melvin-bot

    Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. 25 remaining items

  6. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jun 4, 2024
  7. changed the title [-][$250] Web - Accounting - Xero - Console error shows up when opening Preferred exporter[/-] [+][HOLD for payment 2024-06-11] [$250] Web - Accounting - Xero - Console error shows up when opening Preferred exporter[/+] on Jun 4, 2024
  8. melvin-bot commented on Jun 4, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  9. melvin-bot commented on Jun 4, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.78-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-06-11. 🎊

    For reference, here are some details about the assignees on this issue:

  10. melvin-bot commented on Jun 4, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ahmedGaber93] The PR that introduced the bug has been identified. Link to the PR:
    • [@ahmedGaber93] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@ahmedGaber93] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@ahmedGaber93] Determine if we should create a regression test for this bug.
    • [@ahmedGaber93] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  11. twisterdotcom commented on Jun 11, 2024

    @twisterdotcom
    Contributor

    Payment Summary:

    I don't think we need a test case for a console error here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions