Repository navigation
Conversation
|
Hold for #41554 |
|
This should be blocked for Invoice Account Selector PR as well right? I can see changes that I just reviewed. |
|
This PR is not ready yet. Please wait until I mark it as ready 😄 |
|
Ohh 😄. I stumbled upon this one. |
Still being held but almost ready! |
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
mananjadhav
left a comment
There was a problem hiding this comment.
Small refactor comments, but I think we should test this once Export page is merged.
Reviewer Checklist
Screenshots/VideosAndroid: NativeRevised Old Android: mWeb ChromeRevised mweb-xero-preferred-exporter.movOld iOS: NativeRevised ios-xero-preferred-exporter.movOld iOS: mWeb SafariRevised Old MacOS: Chrome / SafariRevised web-xero-preferred-exporter.movOld MacOS: DesktopRevised desktop-xero-preferred-exporter.movOld |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #39742 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
Tagging @Expensify/design. I wanted to also confirm if it's the only email in the list do we need to navigate twice? |
| { | ||
| description: translate('workspace.xero.preferredExporter'), | ||
| onPress: () => {}, | ||
| onPress: () => { |
There was a problem hiding this comment.
@hungvu193 @lakchote I am not sure how we're handling the pendingFields here. I can see it's tagged as policy.pendingFields.xeroConfigPreferredExporter in the document but I don't see it being used. Neither here nor in @lakchote's PR for Bill selector.
There was a problem hiding this comment.
Yeah, I didn't find any usage of it.
There was a problem hiding this comment.
Yes, it shouldn't be xeroConfigPreferredExporter or anything like that. I previously wrote that before the implementation and I was wrong.
The correct way to do this is would be here to use pendingFields?.export for the pending action.
|
Exactly. Thanks for clarifying, @dannymcclain . I assume this is reflected in the Figma file? If not, let's update it |
|
I did it like the docs: https://docs.google.com/document/d/1VEIzxwNzedLNestAFVT5InGvD4N6FHb0922xjMGOkko/edit#heading=h.fbu7ml85rrhl |
|
Big agree with where you landed Danny. |
|
Cool. Let's me update it then. |
|
Updated! Screen.Recording.2024-05-08.at.10.00.43.mov |
|
cc @Expensify/design does that look good to you too now? |
|
That looks right to me! |
|
@lakchote @hungvu193 I've raised another question related to pendingFields. |
mananjadhav
left a comment
There was a problem hiding this comment.
Reviewed again and uploaded revised screenshots in the checklist.
|
@lakchote This will be ready for your final review 👀 |
Approved, conflicts to be solved and then I'll merge it @hungvu193 👍 |
|
Cool! I've resolved the conflicts |
|
I've fixed the lint as well, this will be ready to merge 😄 |
|
🚀 Deployed to staging by https://github.com/lakchote in version: 1.4.74-0 🚀
|
|
🚀 Deployed to production by https://github.com/chiragsalian in version: 1.4.74-6 🚀
|


Details
Create the Preferred exporter select page
Fixed Issues
$ #39742
PROPOSAL: N/A
Tests
Precondition: User connected to Xero
Offline tests
Same as Tests.
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2024-05-06.at.17.16.02.mov
Android: mWeb Chrome
Screen.Recording.2024-05-06.at.17.23.48.mov
iOS: Native
Screen.Recording.2024-05-06.at.17.07.24.mov
iOS: mWeb Safari
Screen.Recording.2024-05-06.at.17.08.33.mov
MacOS: Chrome / Safari
Screen.Recording.2024-05-06.at.16.20.54.mov
MacOS: Desktop
Screen.Recording.2024-05-06.at.16.21.31.mov