You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-07-24] [$250] Buttons are covered by keyboard and cutting off the view #44009
I'm trying it on prod now and I can't totally recreate it, sometimes if I rapid click around the page and then back into the sign in field the black block will pop up for a second but doesn't stop me from signing in. I think it's the blank block space above the sign in GIF (at least that's what it looks like to me). Iphone 13, chrome incognito, Expensify version v1.4.85-7
It could be related to this? The associated PR was deployed last week which may be why it's not reproducible on staging
@danielrvidal I'm still not able to reproduce this on the newest staging version, this is annoying but can you try it one more time on the newest staging?
It does look like those PRs were supposed to handle it, but I'm still getting it if I go to staging.expensify.com. I'm wondering if it is has something to do with my pws trying to be suggested. Maybe that is causing the issue?
changed the title [-][$250] Buttons are covered by keyboard and cutting off the view[/-][+][HOLD for payment 2024-07-24] [$250] Buttons are covered by keyboard and cutting off the view[/+]on Jul 17, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@suneox / @eh2077] The PR that introduced the bug has been identified. Link to the PR:
[@suneox / @eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@suneox / @eh2077] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@suneox / @eh2077] Determine if we should create a regression test for this bug.
[@suneox / @eh2077] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
[@eh2077] The PR that introduced the bug has been identified. Link to the PR: There's no such a PR that causes this issue. It's an edge case that's not covered before.
[@eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
[@eh2077] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[@eh2077] Determine if we should create a regression test for this bug. No, I don't think we need a regression test for this as it's an edge case and the related code won't be changed often.
Activity
melvin-bot commentedon Jun 19, 2024
Triggered auto assignment to @adelekennedy (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.MelvinBot commentedon Jun 19, 2024
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989
adelekennedy commentedon Jun 20, 2024
I can't reproduce this - I'm on IOS web chrome, staging v1. 4. 84-3 - I can't reproduce but asked for more context and logs in Slack
danielrvidal commentedon Jun 21, 2024
Okay, so I'm not super sure what is causing it. Here is what I can tell you.
https://github.com/Expensify/App/assets/2364487/f00908ac-056f-4b5e-a1d4-1ffd33f37407
https://github.com/Expensify/App/assets/2364487/d16384b4-8e51-4fb8-960b-7bb88304f507
adelekennedy commentedon Jun 21, 2024
I'm trying it on prod now and I can't totally recreate it, sometimes if I rapid click around the page and then back into the sign in field the black block will pop up for a second but doesn't stop me from signing in. I think it's the blank block space above the sign in GIF (at least that's what it looks like to me). Iphone 13, chrome incognito, Expensify version v1.4.85-7
It could be related to this? The associated PR was deployed last week which may be why it's not reproducible on staging
adelekennedy commentedon Jun 24, 2024
@danielrvidal I'm still not able to reproduce this on the newest staging version, this is annoying but can you try it one more time on the newest staging?
danielrvidal commentedon Jun 25, 2024
It does look like those PRs were supposed to handle it, but I'm still getting it if I go to staging.expensify.com. I'm wondering if it is has something to do with my pws trying to be suggested. Maybe that is causing the issue?
RPReplay_Final1719287328.mov
adelekennedy commentedon Jun 25, 2024
Maybe? I think even if we can't nail the reproduction steps it's worth it to make this external and at least investigate
RPReplay_Final1719289328.MP4
43 remaining items
mvtglobally commentedon Jul 11, 2024
Issue not reproducible during KI retests. (First week)
[-][$250] Buttons are covered by keyboard and cutting off the view[/-][+][HOLD for payment 2024-07-24] [$250] Buttons are covered by keyboard and cutting off the view[/+]melvin-bot commentedon Jul 17, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jul 17, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-24. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 17, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
adelekennedy commentedon Jul 25, 2024
payments made - do we need a regression test here @eh2077?
adelekennedy commentedon Jul 28, 2024
bump @eh2077
eh2077 commentedon Jul 29, 2024
Checklist
cc @adelekennedy