Skip to content

[HOLD for payment 2024-07-24] [$250] Buttons are covered by keyboard and cutting off the view #44009

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: need reproduction
Reproducible in production?: needs reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @danielrvidal
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1713930362161559

Action Performed:

  1. Sign up with gmail
  2. In the onboarding flow tap any option and tap name field
  3. Sign out and sign in with existing account
  4. Observe the magic code screen

Expected Result:

Buttons should be completely visible

Actual Result:

Buttons are covered by the keyboard and black patch covers in the sign in screen

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Chrome
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

RPReplay_Final1718743402.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c0acece4b6e020ff
  • Upwork Job ID: 1805457325237784450
  • Last Price Increase: 2024-07-02
  • Automatic offers:
    • rayane-djouah | Reviewer | 103032748
    • suneox | Contributor | 103032750
    • eh2077 | Contributor | 103033350
Issue OwnerCurrent Issue Owner: @adelekennedy

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 19, 2024
  2. melvin-bot commented on Jun 19, 2024

    @melvin-bot

    Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. MelvinBot commented on Jun 19, 2024

    @MelvinBot
    Contributor

    This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

  4. adelekennedy commented on Jun 20, 2024

    @adelekennedy
    Contributor

    I can't reproduce this - I'm on IOS web chrome, staging v1. 4. 84-3 - I can't reproduce but asked for more context and logs in Slack

  5. danielrvidal commented on Jun 21, 2024

    @danielrvidal
    Contributor

    Okay, so I'm not super sure what is causing it. Here is what I can tell you.

    1. Chrome, incognito latest version
    2. iPhone 13 Pro
    3. Go to new.expensify.com
    4. Click on the sign in and it shows up
    5. Sometimes I have to click in and out multiple times before it shows up

    https://github.com/Expensify/App/assets/2364487/f00908ac-056f-4b5e-a1d4-1ffd33f37407
    https://github.com/Expensify/App/assets/2364487/d16384b4-8e51-4fb8-960b-7bb88304f507

  6. adelekennedy commented on Jun 21, 2024

    @adelekennedy
    Contributor

    I'm trying it on prod now and I can't totally recreate it, sometimes if I rapid click around the page and then back into the sign in field the black block will pop up for a second but doesn't stop me from signing in. I think it's the blank block space above the sign in GIF (at least that's what it looks like to me). Iphone 13, chrome incognito, Expensify version v1.4.85-7

    It could be related to this? The associated PR was deployed last week which may be why it's not reproducible on staging

  7. added
    retest-weeklyApply this label if you want this issue tested on a Weekly basis by Applause
    on Jun 24, 2024
  8. adelekennedy commented on Jun 24, 2024

    @adelekennedy
    Contributor

    @danielrvidal I'm still not able to reproduce this on the newest staging version, this is annoying but can you try it one more time on the newest staging?

  9. danielrvidal commented on Jun 25, 2024

    @danielrvidal
    Contributor

    It does look like those PRs were supposed to handle it, but I'm still getting it if I go to staging.expensify.com. I'm wondering if it is has something to do with my pws trying to be suggested. Maybe that is causing the issue?

    RPReplay_Final1719287328.mov
  10. adelekennedy commented on Jun 25, 2024

    @adelekennedy
    Contributor

    Maybe? I think even if we can't nail the reproduction steps it's worth it to make this external and at least investigate

    RPReplay_Final1719289328.MP4
  11. 43 remaining items

  12. mvtglobally commented on Jul 11, 2024

    @mvtglobally

    Issue not reproducible during KI retests. (First week)

  13. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jul 17, 2024
  14. changed the title [-][$250] Buttons are covered by keyboard and cutting off the view[/-] [+][HOLD for payment 2024-07-24] [$250] Buttons are covered by keyboard and cutting off the view[/+] on Jul 17, 2024
  15. melvin-bot commented on Jul 17, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  16. melvin-bot commented on Jul 17, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-24. 🎊

    For reference, here are some details about the assignees on this issue:

  17. melvin-bot commented on Jul 17, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@suneox / @eh2077] The PR that introduced the bug has been identified. Link to the PR:
    • [@suneox / @eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@suneox / @eh2077] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@suneox / @eh2077] Determine if we should create a regression test for this bug.
    • [@suneox / @eh2077] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  18. adelekennedy commented on Jul 25, 2024

    @adelekennedy
    Contributor

    payments made - do we need a regression test here @eh2077?

  19. adelekennedy commented on Jul 28, 2024

    @adelekennedy
    Contributor

    bump @eh2077

  20. eh2077 commented on Jul 29, 2024

    @eh2077
    Contributor

    Checklist

    • [@eh2077] The PR that introduced the bug has been identified. Link to the PR: There's no such a PR that causes this issue. It's an edge case that's not covered before.
    • [@eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
    • [@eh2077] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • [@eh2077] Determine if we should create a regression test for this bug. No, I don't think we need a regression test for this as it's an edge case and the related code won't be changed often.

    cc @adelekennedy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions