Skip to content

[HOLD for payment 2024-07-10] [$250] Chat - Report in the background loads infinitely after refreshing group confirmation page #44442

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.2-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to FAB > Start chat.
  3. Click Add to group next to a few users.
  4. Click Next.
  5. Refresh the confirmation page.
  6. Dismiss the confirmation page.

Expected Result:

In Step 5, after refreshing the confirmation page, the report in the background will load.

Actual Result:

In Step 5, after refreshing the confirmation page, the report in the background shows infinite loading.
In Step 6, after dismissing the confirmation page, the link is https://staging.new.expensify.com/r

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6524928_1719389626682.20240626_160912.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @CortneyOfstad

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Jun 26, 2024
  2. melvin-bot commented on Jun 26, 2024

    @melvin-bot

    Triggered auto assignment to @flodnv (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Jun 26, 2024

    @melvin-bot

    Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. github-actions commented on Jun 26, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. izarutskaya commented on Jun 26, 2024

    @izarutskaya
    Author

    @CortneyOfstad I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  6. izarutskaya commented on Jun 26, 2024

    @izarutskaya
    Author

    We think this issue might be related to the #vip-vsb

  7. flodnv commented on Jun 26, 2024

    @flodnv
    Contributor

    @luacmartins @truph01 @akinwale I see that we modified the loading skeleton in this PR - #43652 - could this DeployBlocker be related with that PR?

  8. 34 remaining items

  9. changed the title [-][Pay 7/4] Chat - Report in the background loads infinitely after refreshing group confirmation page[/-] [+][$250] Chat - Report in the background loads infinitely after refreshing group confirmation page[/+] on Jul 3, 2024
  10. melvin-bot commented on Jul 3, 2024

    @melvin-bot

    ⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

  11. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jul 3, 2024
  12. changed the title [-][$250] Chat - Report in the background loads infinitely after refreshing group confirmation page[/-] [+][HOLD for payment 2024-07-10] [$250] Chat - Report in the background loads infinitely after refreshing group confirmation page[/+] on Jul 3, 2024
  13. melvin-bot commented on Jul 3, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-07-10. 🎊

    For reference, here are some details about the assignees on this issue:

    • @c3024 requires payment (Needs manual offer from BZ)
  14. melvin-bot commented on Jul 3, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@c3024] The PR that introduced the bug has been identified. Link to the PR:
    • [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@c3024] Determine if we should create a regression test for this bug.
    • [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  15. CortneyOfstad commented on Jul 9, 2024

    @CortneyOfstad
    Contributor

    @c3024 can you please complete the checklist above so there is no delay in issuing payment?

    Also, i sent you an offer in Upwork (job post here) Let me know once you accept and I'll get that paid ASAP tomorrow 👍

  16. c3024 commented on Jul 10, 2024

    @c3024
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@c3024] The PR that introduced the bug has been identified. Link to the PR: No PR can be help responsible.
    • [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
    • [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No. This could not have been identified earlier.
    • [@c3024] Determine if we should create a regression test for this bug. Yes
    • [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression test proposal

    1. Open any report
    2. Press on FAB > Start Chat
    3. Press on Add to group on some users
    4. Press Next
    5. Refresh the page.
    6. Verify that the report opened in step 1 correctly loads in the background.
  17. c3024 commented on Jul 10, 2024

    @c3024
    Contributor

    @CortneyOfstad accepted, thanks!

  18. CortneyOfstad commented on Jul 10, 2024

    @CortneyOfstad
    Contributor

    Payment Summary

    @c3024 — paid $250 via Upwork

    Regression Test

    Created here

  19. melvin-bot commented on Jul 16, 2024

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions