Skip to content

[HOLD for payment 2024-10-24] [HOLD for payment 2024-10-16] Add LHN debugging to Debug Mode #46992

Closed

Description

@puneetlath

We are adding a debug mode to the App here: #45481

What I would really love from the Debug Mode is something that tells me why a given report is in the LHN. So if I'm seeing a report in the LHN, why is it there? And similarly if it has an RBR/GBR, what is causing that to be there?
This might be more useful in Focus Mode than in Most Recent, but I think it would help with a lot of the recent issues we've been troubleshooting.

cc @pac-guerreiro

Issue OwnerCurrent Issue Owner: @puneetlath

Activity

  1. self-assigned this
    on Aug 7, 2024
  2. melvin-bot commented on Aug 7, 2024

    @melvin-bot

    Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.

  3. melvin-bot commented on Aug 7, 2024

    @melvin-bot

    ⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

  4. melvin-bot commented on Aug 7, 2024

    @melvin-bot

    Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

  5. pac-guerreiro commented on Aug 7, 2024

    @pac-guerreiro
    Contributor

    Hi! I’m Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this task!

  6. puneetlath commented on Aug 16, 2024

    @puneetlath
    ContributorAuthor

    Still waiting for the first PR to get merged.

  7. DylanDylann commented on Aug 16, 2024

    @DylanDylann
    Contributor

    yeah, I will try to complete check list today

  8. 55 remaining items

  9. DylanDylann commented on Oct 17, 2024

    @DylanDylann
    Contributor

    @puneetlath Do we require the regression test on debug feature issues?

  10. puneetlath commented on Oct 17, 2024

    @puneetlath
    ContributorAuthor

    Yes please. We rely on these features quite a bit, so it'd be good to have some regression testing to make sure we don't break them accidentally. Otherwise we won't realize they are broken until we need them to help us debug something.

  11. DylanDylann commented on Oct 18, 2024

    @DylanDylann
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    [@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: NA
    [@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
    [@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
    [@DylanDylann] Determine if we should create a regression test for this bug. Yes
    [@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Proposal 1

    1. Enable the Debug feature
    2. On the home page, open a chat report from LHN
    3. Click on the header of the chat you just opened, then click on Debug
    4. On the Details tab, confirm that "Visible in LHN" provides the correct reason for the report to be shown on LHN
    5. Confirm that "GBR" shows the correct reason, if the report has GBR in LHN
    6. Confirm that "RBR" shows the correct reason, if the report has RBR in LHN

    Regression Test Proposal 2

    1. Enable the Debug feature
    2. On the home page, right-click or long-press a report from LHN,
    3. Select Debug option
    4. The debug page is displayed

    Do we agree 👍 or 👎

  12. melvin-bot commented on Oct 24, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @pac-guerreiro is from an agency-contributor and not due payment
    • ROLE: @DylanDylann paid $(AMOUNT) via Upwork (LINK)

    BugZero Checklist (@puneetlath)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  13. puneetlath commented on Oct 24, 2024

    @puneetlath
    ContributorAuthor

    @DylanDylann were there multiple PRs for this one?

  14. DylanDylann commented on Oct 29, 2024

    @DylanDylann
    Contributor

    @puneetlath Initially we implemented this first PR, after that we have a new requirement to add debug option to context menu on LHN, the second PR was created to address this. Finally, we created the third PR to add RBR reason to debug mode that we missed in the first PR (Note that: we already have an issue for this problem)

  15. DylanDylann commented on Oct 29, 2024

    @DylanDylann
    Contributor

    I also updated the regression test to cover all implementations

  16. puneetlath commented on Nov 5, 2024

    @puneetlath
    ContributorAuthor

    @DylanDylann I'm going to have each of the debug mode PRs be a milestone on one Upwork job. Just to make things easier for me to pay.

    The offer for is here: https://www.upwork.com/nx/wm/offer/new/1039087488. I've added 3 PRs as milestones so far. I'll add the others as milestones as we go.

    Please ping me here when you've accepted.

  17. DylanDylann commented on Nov 6, 2024

    @DylanDylann
    Contributor

    @puneetlath Accepted 🙏

  18. puneetlath commented on Nov 6, 2024

    @puneetlath
    ContributorAuthor

    Paid these milestones:

    • Add LHN debugging to Debug Mode
    • Add debug option to LHN context menu

    Regression test issue here: https://github.com/Expensify/Expensify/issues/442178

    Closing this one out. Thanks y'all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionNewFeatureSomething to build that is a new item.ReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions