You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-10-24] [HOLD for payment 2024-10-16] Add LHN debugging to Debug Mode #46992
We are adding a debug mode to the App here: #45481
What I would really love from the Debug Mode is something that tells me why a given report is in the LHN. So if I'm seeing a report in the LHN, why is it there? And similarly if it has an RBR/GBR, what is causing that to be there?
This might be more useful in Focus Mode than in Most Recent, but I think it would help with a lot of the recent issues we've been troubleshooting.
⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️
Yes please. We rely on these features quite a bit, so it'd be good to have some regression testing to make sure we don't break them accidentally. Otherwise we won't realize they are broken until we need them to help us debug something.
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: NA
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@DylanDylann] Determine if we should create a regression test for this bug. Yes
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal 1
Enable the Debug feature
On the home page, open a chat report from LHN
Click on the header of the chat you just opened, then click on Debug
On the Details tab, confirm that "Visible in LHN" provides the correct reason for the report to be shown on LHN
Confirm that "GBR" shows the correct reason, if the report has GBR in LHN
Confirm that "RBR" shows the correct reason, if the report has RBR in LHN
Regression Test Proposal 2
Enable the Debug feature
On the home page, right-click or long-press a report from LHN,
@puneetlath Initially we implemented this first PR, after that we have a new requirement to add debug option to context menu on LHN, the second PR was created to address this. Finally, we created the third PR to add RBR reason to debug mode that we missed in the first PR (Note that: we already have an issue for this problem)
Activity
melvin-bot commentedon Aug 7, 2024
Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.
melvin-bot commentedon Aug 7, 2024
melvin-bot commentedon Aug 7, 2024
Triggered auto assignment to Design team member for new feature review - @shawnborton (
NewFeature)pac-guerreiro commentedon Aug 7, 2024
Hi! I’m Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this task!
puneetlath commentedon Aug 16, 2024
Still waiting for the first PR to get merged.
DylanDylann commentedon Aug 16, 2024
yeah, I will try to complete check list today
55 remaining items
DylanDylann commentedon Oct 17, 2024
@puneetlath Do we require the regression test on debug feature issues?
puneetlath commentedon Oct 17, 2024
Yes please. We rely on these features quite a bit, so it'd be good to have some regression testing to make sure we don't break them accidentally. Otherwise we won't realize they are broken until we need them to help us debug something.
DylanDylann commentedon Oct 18, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: NA
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: NA
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
[@DylanDylann] Determine if we should create a regression test for this bug. Yes
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal 1
Regression Test Proposal 2
Do we agree 👍 or 👎
melvin-bot commentedon Oct 24, 2024
Payment Summary
Upwork Job
BugZero Checklist (@puneetlath)
puneetlath commentedon Oct 24, 2024
@DylanDylann were there multiple PRs for this one?
DylanDylann commentedon Oct 29, 2024
@puneetlath Initially we implemented this first PR, after that we have a new requirement to add debug option to context menu on LHN, the second PR was created to address this. Finally, we created the third PR to add RBR reason to debug mode that we missed in the first PR (Note that: we already have an issue for this problem)
DylanDylann commentedon Oct 29, 2024
I also updated the regression test to cover all implementations
puneetlath commentedon Nov 5, 2024
@DylanDylann I'm going to have each of the debug mode PRs be a milestone on one Upwork job. Just to make things easier for me to pay.
The offer for is here: https://www.upwork.com/nx/wm/offer/new/1039087488. I've added 3 PRs as milestones so far. I'll add the others as milestones as we go.
Please ping me here when you've accepted.
DylanDylann commentedon Nov 6, 2024
@puneetlath Accepted 🙏
puneetlath commentedon Nov 6, 2024
Paid these milestones:
Regression test issue here: https://github.com/Expensify/Expensify/issues/442178
Closing this one out. Thanks y'all!