Skip to content

[HOLD for payment 2024-10-30] Add RBR reason to LHN debugging #50665

Closed

Description

@puneetlath

As discussed here, let's add the reason a given report is showing an RBR in the LHN to the reports debug information. Similar to what we do for GBRs.

cc @pac-guerreiro

Issue OwnerCurrent Issue Owner: @puneetlath

Activity

  1. melvin-bot commented on Oct 11, 2024

    @melvin-bot

    Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.

  2. melvin-bot commented on Oct 11, 2024

    @melvin-bot

    ⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

  3. melvin-bot commented on Oct 11, 2024

    @melvin-bot

    Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

  4. pac-guerreiro commented on Oct 11, 2024

    @pac-guerreiro
    Contributor

    Hi! I’m Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this task!

  5. 18 remaining items

  6. melvin-bot commented on Oct 23, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-10-30. 🎊

    For reference, here are some details about the assignees on this issue:

  7. melvin-bot commented on Oct 23, 2024

    @melvin-bot

    BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@DylanDylann] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
    • [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.
  8. melvin-bot commented on Oct 30, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @pac-guerreiro is from an agency-contributor and not due payment
    • ROLE: @DylanDylann paid $(AMOUNT) via Upwork (LINK)

    BugZero Checklist (@puneetlath)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  9. DylanDylann commented on Oct 31, 2024

    @DylanDylann
    Contributor

    The regression test is covered here

  10. melvin-bot commented on Nov 1, 2024

    @melvin-bot

    @puneetlath, @pac-guerreiro, @DylanDylann Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  11. melvin-bot commented on Nov 5, 2024

    @melvin-bot

    @puneetlath, @pac-guerreiro, @DylanDylann Still overdue 6 days?! Let's take care of this!

  12. puneetlath commented on Nov 5, 2024

    @puneetlath
    ContributorAuthor

    @DylanDylann I'm going to have each of the debug mode PRs be a milestone on one Upwork job. Just to make things easier for me to pay.

    The offer for is here: https://www.upwork.com/nx/wm/offer/new/1039087488. I've added 3 PRs as milestones so far. I'll add the others as milestones as we go.

    Please ping me here when you've accepted.

  13. DylanDylann commented on Nov 6, 2024

    @DylanDylann
    Contributor

    @puneetlath Accepted 🙏

  14. puneetlath commented on Nov 6, 2024

    @puneetlath
    ContributorAuthor

    Paid this one. Thanks y'all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2NewFeatureSomething to build that is a new item.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions