Skip to content

[Workspace Feeds] unable to change card limit to $0 #48904

Closed

Description

@kevinksullivan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Reproducible in staging?: Y
Email or phone of affected tester (no customers):

Issue reported by: @kevinksullivan
Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1725978148730949

Action Performed:

  1. Add account to workspaceFeeds beta
  2. Sign in with test account
  3. Select Manage my team’s expenses
  4. Enter any business name / personal name
  5. Navigate to the workspace editor of the newly created workspace
  6. Navigate to More features tab
  7. Toggle on the feature
  8. Navigate to the Expensify Card page
  9. Select Issue new card
  10. Follow the steps for an OPEN bank account (option 3) of this SO, and exit the onboarding flow at the requestor information section
    Select Finish setup and continue through the VBBA flow
    Finish the setup process
  11. Issue an Expensify Card with >$0 limit
  12. Select the newly issued card in the cards list
  13. Change the limit to $0

Expected Result:

See a modal with the following copy:

Header: “change card limit”
Body: “If you change this card’s limit to $[new limit], new transactions will be declined until next month.”
Buttons: “Change limit” and “Cancel”

Actual Result:

Unable to change to $0

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

2024-09-10_10-19-36.mp4

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 10, 2024
  2. melvin-bot commented on Sep 10, 2024

    @melvin-bot

    Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. changed the title [-][workspace feeds] unable to change card limit to $0[/-] [+][Workspace Feeds] unable to change card limit to $0[/+] on Sep 10, 2024
  4. moved this to Release 3: Autumn 2024 (Nov) in [#whatsnext] #wave-collecton Sep 10, 2024
  5. moved this from Release 3: Autumn 2024 (Nov) to Release 2.5: SuiteWorld (Sept 9th) in [#whatsnext] #wave-collecton Sep 10, 2024
  6. kevinksullivan commented on Sep 10, 2024

    @kevinksullivan
    ContributorAuthor
  7. cretadn22 commented on Sep 10, 2024

    @cretadn22
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    unable to change card limit to $0

    What is the root cause of that problem?

    if (!Number(values.limit) || !Number.isInteger(Number(values.limit))) {
    errors.limit = translate('iou.error.invalidAmount');
    }

    The validate function return error because values.limit = 0

    What changes do you think we should make in order to solve the problem?

    if (!Number(values.limit) || !Number.isInteger(Number(values.limit))) {
    errors.limit = translate('iou.error.invalidAmount');
    }

    Remove !Number(values.limit) condition

    What alternative solutions did you explore? (Optional)

  8. mountiny commented on Sep 10, 2024

    @mountiny
    Contributor

    @allgandalf will handle the PR for this as they work as dedicated C+ for this feature project

  9. allgandalf commented on Sep 11, 2024

    @allgandalf
    Contributor

    PR merged !

  10. cretadn22 commented on Sep 11, 2024

    @cretadn22
    Contributor

    I submitted two accurate proposals that is used in the PR for the following issues:

    #48905
    #48904

    @adelekennedy @mountiny These might be very helpful for @allgandalf's PR. Am I eligible for any compensation?

  11. allgandalf commented on Sep 11, 2024

    @allgandalf
    Contributor

    Both these issues weren’t marked as external, and those are part of ongoing project

  12. allgandalf commented on Sep 11, 2024

    @allgandalf
    Contributor

    Lets close this issue, the PR was deployed to production

  13. removed their assignment
    on Sep 11, 2024
  14. moved this from Release 2.5: SuiteWorld (Sept 9th) to Done in [#whatsnext] #wave-collecton Sep 11, 2024
  15. mountiny commented on Sep 15, 2024

    @mountiny
    Contributor

    @cretadn22 agreed with @allgandalf sorry for this but it is part of an ongoing project and we pay for the entire project there, the issues were not marked as external and the project team was supposed to handle it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.ReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions