You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Workspace Feeds] unable to change card limit to $0 #48904
Navigate to the workspace editor of the newly created workspace
Navigate to More features tab
Toggle on the feature
Navigate to the Expensify Card page
Select Issue new card
Follow the steps for an OPEN bank account (option 3) of this SO, and exit the onboarding flow at the requestor information section
Select Finish setup and continue through the VBBA flow
Finish the setup process
Issue an Expensify Card with >$0 limit
Select the newly issued card in the cards list
Change the limit to $0
Expected Result:
See a modal with the following copy:
Header: “change card limit”
Body: “If you change this card’s limit to $[new limit], new transactions will be declined until next month.”
Buttons: “Change limit” and “Cancel”
Actual Result:
Unable to change to $0
Platforms:
Which of our officially supported platforms is this issue occurring on?
@cretadn22 agreed with @allgandalf sorry for this but it is part of an ongoing project and we pay for the entire project there, the issues were not marked as external and the project team was supposed to handle it
Activity
melvin-bot commentedon Sep 10, 2024
Triggered auto assignment to @adelekennedy (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.[-][workspace feeds] unable to change card limit to $0[/-][+][Workspace Feeds] unable to change card limit to $0[/+]kevinksullivan commentedon Sep 10, 2024
CC @mountiny
cretadn22 commentedon Sep 10, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
unable to change card limit to $0
What is the root cause of that problem?
App/src/pages/workspace/expensifyCard/WorkspaceEditCardLimitPage.tsx
Lines 91 to 93 in c4c46fe
The validate function return error because values.limit = 0
What changes do you think we should make in order to solve the problem?
App/src/pages/workspace/expensifyCard/WorkspaceEditCardLimitPage.tsx
Lines 91 to 93 in c4c46fe
Remove !Number(values.limit) condition
What alternative solutions did you explore? (Optional)
mountiny commentedon Sep 10, 2024
@allgandalf will handle the PR for this as they work as dedicated C+ for this feature project
allgandalf commentedon Sep 11, 2024
PR merged !
cretadn22 commentedon Sep 11, 2024
I submitted two accurate proposals that is used in the PR for the following issues:
#48905
#48904
@adelekennedy @mountiny These might be very helpful for @allgandalf's PR. Am I eligible for any compensation?
allgandalf commentedon Sep 11, 2024
Both these issues weren’t marked as external, and those are part of ongoing project
allgandalf commentedon Sep 11, 2024
Lets close this issue, the PR was deployed to production
mountiny commentedon Sep 15, 2024
@cretadn22 agreed with @allgandalf sorry for this but it is part of an ongoing project and we pay for the entire project there, the issues were not marked as external and the project team was supposed to handle it