Skip to content

[HOLD for payment 2025-01-24] [$250] IOS - Empty screen seen when navigating back from workspace description the second time #53589

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.71-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): nathanmulugetatesting+2338@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Open IOS hybrid app
  2. Create a workspace give it a custom description
  3. Navigate to the inbox
  4. Open workspace chat
  5. Tap on the custom description to navigate to description setting of the workspace
  6. Navigate back twice by tapping on the top left back icon until you reach workspace editor page
  7. Tap on Workspace chat
  8. Re do step 5
  9. Tap on the top corner back icon or swipe from left to right

Expected Result:

Empty screen does not get shown

Actual Result:

Empty screen gets shown and the workspace profile settings page animation is wrong, it slides from right to left after the empty screen has been shown first

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6684551_1733335793079.ScreenRecording_12-04-2024_21-02-36_1.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021865096772528155887
  • Upwork Job ID: 1865096772528155887
  • Last Price Increase: 2025-01-10
  • Automatic offers:
    • ishpaul777 | Reviewer | 105677024
    • ikevin127 | Contributor | 105677027
Issue OwnerCurrent Issue Owner: @muttmuure

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Dec 4, 2024
  2. melvin-bot commented on Dec 4, 2024

    @melvin-bot

    Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed on Dec 6, 2024
  4. melvin-bot commented on Dec 6, 2024

    @melvin-bot
  5. changed the title [-] IOS - Empty screen seen when navigating back from workspace description the second time[/-] [+][$250] IOS - Empty screen seen when navigating back from workspace description the second time[/+] on Dec 6, 2024
  6. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Dec 6, 2024
  7. melvin-bot commented on Dec 6, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)

  8. ikevin127 commented on Dec 7, 2024

    @ikevin127
  9. 61 remaining items

  10. melvin-bot commented on Jan 17, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Jan 17, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.86-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-01-24. 🎊

    For reference, here are some details about the assignees on this issue:

  12. melvin-bot commented on Jan 17, 2025

    @melvin-bot

    @ikevin127 / @ishpaul777 @muttmuure @ikevin127 / @ishpaul777 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. mvtglobally commented on Jan 18, 2025

    @mvtglobally

    Issue not reproducible during KI retests. (Second week)

  14. ikevin127 commented on Jan 25, 2025

    @ikevin127
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: #37165 (commit comment).

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A.

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test 1:

    1. Create a workspace give it a custom description (WS Settings > Workspage profile > Description).
    2. Navigate to inbox.
    3. Open workspace chat.
    4. Verify that click / tap on the report's custom description welcome text doesn't do anything.
    5. Verify that click / tap on the report header custom description text opens the report details page (RHP).

    Test 2:

    1. Start a #room chat and give it a custom description.
    2. Open the chat.
    3. Verify that click / tap on the report's custom description welcome text doesn't do anything.
    4. Verify that click / tap on the report header custom description text opens the report details page (RHP).

    Test 3:

    1. Navigate to an existing invoice room.
    2. Give the invoice room a custom description.
    3. Verify that click / tap on the report's custom description welcome text doesn't do anything.
    4. Verify that click / tap on the report header custom description text opens the report details page (RHP).

    Do we agree 👍 or 👎.

    cc @muttmuure for payments

  15. melvin-bot commented on Jan 27, 2025

    @melvin-bot

    @deetergp, @muttmuure, @ikevin127, @ishpaul777 Whoops! This issue is 2 days overdue. Let's get this updated quick!

  16. ishpaul777 commented on Jan 27, 2025

    @ishpaul777
    Contributor

    just waiting payment here

  17. ikevin127 commented on Jan 27, 2025

    @ikevin127
    Contributor

    cc @muttmuure for payments (tagged on Slack thread as well)

  18. mallenexpensify commented on Jan 28, 2025

    @mallenexpensify
    Contributor

    Contributor: @ikevin127 paid $250 via Upwork
    Contributor+: @ishpaul777 paid $250 via Upwork

    Test case - https://github.com/Expensify/Expensify/issues/465111

    Think I got it all, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions