Repository navigation
Remove custom report welcome message pressable functionality - #55177
Conversation
|
@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@ishpaul777 Fixed the above eslint issues by importing the methods directly as instructed by the rule and added Not sure what's the correct style in this case, I asked on Slack in this thread and awaiting a response. |
…7-removeReportWelcomePressable
|
@ishpaul777 🟢 PR is ready for review now, just synced w/ main and updated imported ReportUtils methods to the naming convention specified on Slack in this thread, only for those methods that were conflicting with already existing variable names. |
Screen.Recording.2025-01-14.at.5.04.42.PM.mov@ikevin127 can we remove the navigation from here as well |
|
actually wait let me confirm first ^, (asked here) |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2025-01-14.at.5.15.17.PM.movAndroid: mWeb ChromeScreen.Recording.2025-01-14.at.5.17.27.PM.moviOS: NativeScreen.Recording.2025-01-14.at.5.19.56.PM.movScreen.Recording.2025-01-15.at.3.23.21.AM.moviOS: mWeb SafariScreen.Recording.2025-01-14.at.5.22.18.PM.movMacOS: Chrome / SafariScreen.Recording.2025-01-14.at.5.01.11.PM.movScreen.Recording.2025-01-15.at.3.17.50.AM.movMacOS: DesktopScreen.Recording.2025-01-14.at.5.34.10.PM.mov |
…7-removeReportWelcomePressable
|
@ishpaul777 Applied changes discussed in Slack for #rooms and invoice rooms as well, we're now aligned on all 3 for both header and report welcome text. I updated the Tests steps as well to include all 3 changes ✅ web.mov |
|
Looking good to me! cc @Expensify/design too. (Sorry for the double ping here and in Slack—that's my bad!) |
|
i dont think UI tests will do any good here since we removing a click-ability here not adding any functionality, test case is just not worth it and will be confusing |
deetergp
left a comment
There was a problem hiding this comment.
Looks good & tests well 👍
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/deetergp in version: 9.0.86-0 🚀
|
|
🚀 Deployed to staging by https://github.com/deetergp in version: 9.0.86-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.0.86-3 🚀
|
Explanation of Change
We decided to remove the pressable navigation from a custom report welcome message since it wasn't making much sense from a UX / UI point of view and was creating a navigation issue.
Fixed Issues
$ #53589
PROPOSAL: #53589 (comment)
Tests
Test 1:
Test 2:
Test 3:
Offline tests
Same as tests.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Uploading android.mp4…
Android: mWeb Chrome
android-mweb.mp4
iOS: Native
ios.mp4
iOS: mWeb Safari
ios-mweb.mp4
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov