Repository navigation
Closed
Labels
MonthlyKSv2KSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Description
Release Version: 9.0.89-8
Compare Changes: production...staging
This release contains changes from the following pull requests:
- fix: report fields are not disabled after disconnect accounting integration #51717
- [NO QA] feat: Step 3 logic #52954
- fix: Hmm it's not here in RHP is displayed after deleting a workspace #53816
- [HybridApp] Fix
Not found pageon shortcuts #53954 - Sending a message scrolls down to previous message #54071
- Fix can't interact with workspace item that is previously failed to delete #54278
- Align default IDs in Report.ts file #54306
- Fix - Search - Expense from the list does not disappear after deletion #54407
- Align default IDs in IOU.ts file #54534
- Don't automatically unpause focus trap #54593
- refactor shareTrackedExpense function #54650
- fix: mobile doesn't need manual focus anymore for autoFocus #54755
- Implemented International Bank Account flow #54798
- [No QA] fix: Allow private_ prefix lint rule for variable naming #54937
- Add useCallback to avoid unnecessary rerenders of FloatingMessageCounter #54944
- fix: highlight parent conversation when go back in offline #55014
- Tweaks to the expense flow #55016
- Fix - Update the Group Creation flow #55030
- Add view transactions cta to Expensify card and company cards page #55095
- fix: reverting the amount and currency after error clearance. #55102
- [No QA] Add files via upload #55170
- Migrate last components to reanimated #55202
- Show loading when map component is loading #55259
- perf: avoid using getOrderedReportIDs when calculating GBR/RBR state #55260
- Remove the getTripTransactions method #55264
- [No QA] Applying changes to searchParser.peggy #55284
- Update focus trap #55285
- perf: create report -> transactions map to optimize performance #55297
- Update AddressStep.tsx #55327
- [No QA] Proposal Police™ Structured Response Follow-Up #55330
- Fix: In 2FA magic code page, after refresh briefly error message is displayed #55332
- Simplify single line TextInput styling to allow for different heights #55343
- Fix extra spacing before field label #55346
- perf: optionsToExclude array to loginsToExclude map #55348
- fix(search): tag names with colon showed \: instead of : #55360
- [No QA] Manually reconnect to pusher when there is a 1006 error message #55369
- [No QA] [HelpDot]: add new route and article skeleton to newdot documentation #55385
- Update Workspace profile to Overview #55388
- fix: Advanced page for "custom form ID" detail is not visible #55389
- Fixed Onyx serialization of FileObject #55395
- Set an initial value for draft comment collection #55411
- Bump react-fast-pdf #55421
- [No QA] Publish user_id with GTM events #55434
- Update educational tooltip style to conditionally apply pointer events #55440
- fix: in debug menu toggle action delay #55442
- Fix prev workspace is shown when switching workspace #55443
- Remove some dots at the end of system message #55444
- Add onTooltipPress callback to various tooltip components #55454
- Center-me button is missing on the map #55458
- fix: next button in card instruction page is overlapped #55470
- fix: Delete Receipt button is not displayed in merged transaction #55474
- [No QA] Add one more commercial feeds helpdot image #55480
- 53814 fix confirmation button jump #55494
- fix: max image file size #55499
- [No QA] Add beta for NSQS #55502
- Hide pay button if submit button is visible #55503
- Migrate AuthScreens to useOnyx #55528
- Draft report not showing in the draft status filter #55544
- Change design of WorkspaceMoreFeaturePage sections. #55556
- [No QA] 50360 - Follow up to fix eslint errors #55566
- Update Create-expense-categories.md to include CSV upload #55574
- Fix - Web - Profile - App does not dynamically translate address options #55580
- Fix new messages indicator after comment linking #55582
- [NoQA] Update copy to commercial feeds #55584
- Fix public room doesn't open if deep link as anonymous user #55592
- Prevent tooltip from showing when a fullscreen is visible #55593
- fix: Align Receipt Image Consistently in Expense Preview and Expense View. #55598
- [No QA] Create Expense Clean Up (follow up) - Add unit tests #55600
- perf: filter reports by workspace to improve workspace LHN load #55604
- [No QA] Pick PR number from issue description #55609
- Create Using-Reports-in-New-Expensify.md #55618
- Create TooltipsTemplate.md #55632
- Update optimistic next steps for manual and empty reports #55635
- Removing one value from Search filter clears the search #55636
- Update Approve-travel-expenses.md #55640
- Update and rename Dispute-Expensify-Card-transaction.md to Dispute-Ex… #55641
- Travel_soft_approval #55643
- [CP Staging] Fix wrong align of TextInput when displaying currency/icon #55711
- [CP Staging] fix: partial scroll when returning from expense thread #55712
- [CP Staging] Fix - Self DM - User can submit track expense to self (You) again and send invoice to self AND fix smartscan share in oldDot #55716
- [CP Staging] Revert PR #54071 #55790
- [CP Staging] Fix postcode validation for add payment card flow #55812
- Revert "Merge pull request #55528 from software-mansion-labs/use-onyx/auth-screens #55815
Internal QA:
- [Internal QA]: Update web behaviour of bank connection for card assign #55561 - @mountiny
- fix: logic enable allow deleting transaction #55387 - @mountiny
- Fix desktop build issue with notarization #55282 - @mountiny
Deploy Blockers:
- [HOLD for payment 2025-02-05] [HOLD for payment 2025-02-04] [$250] Report - Chat is partially scrolled down when returning from expense thread #55660
- [HOLD for payment 2025-02-05] [HOLD for payment 2025-02-04] Self DM - User can submit track expense to self (You) again and send invoice to self #55661
- [HOLD for payment 2025-02-05] [HOLD for payment 2025-02-04] Split - Individual split amount field is not aligned correctly #55662
- [HOLD: #49539] Invoices - Bank account setup RHP starts from the beginning after adding a US bank account #55672
- Invoices - Bank account row is missing currency after reset and restart app #55674
- [Due for payment 2025-02-18] Invoices - Bank account pop-up shows "undefined" instead of the bank currency #55675
- Wallet - Confirm button is not shown on the currency selector page #55678
- [HOLD for payment 2025-02-05] [HOLD for payment 2025-02-04] [$250] Desktop - App auto relogins after signing out #55681
- [$250 reproduction steps][CRITICAL] Login - Unable to sign in with Google #55682
- [Due for payment 2025-03-31] [$250] Wallet - Check Box is unselected when changing Account Type #55688
- [HOLD App#53186] [$250] Android - Workspace overview buttons are cut off at the bottom #55690
- Chat does not scroll to the bottom when submitting expenses while being at the top of the chat #55693
- iOS Reports - Card details page opens in the background when opening and closing filter page #55707
- [$250] Expense - Recipient list auto scrolls down to reveal only "Contacts" after clearing search field #55715
- Wallet - No error message when adding same non-US bank account #55726
- Create expense-Error appears in console when creating a Scan expense #55733
- [HOLD for payment 2025-02-05] [HOLD for payment 2025-02-04] Not auto scrolled when send another chat after reload from last chat #55780
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics for this release version and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked Firebase Crashlytics for the previous release version and verified that the release did not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Metadata
Metadata
Labels
MonthlyKSv2KSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Activity
mountiny commentedon Jan 23, 2025
desktop build was successful so checking #55282 off
francoisl commentedon Jan 23, 2025
Demoting #55672 as it's behind a beta
jasperhuangg commentedon Jan 23, 2025
Demoting #55690
mvtglobally commentedon Jan 24, 2025
Regression is at 60% TCs completed. High number of PRs still need testing
Blockers
#55660
#55661
#55662
#55674
#55675
#55678
#55681
#55690
PRs
Checking off #54306 (comment)
Beamanator commentedon Jan 24, 2025
#55678 confirmed nab
izarutskaya commentedon Jan 24, 2025
Regression is at 92% TCs completed.
#54278 - failing with #54278 (comment)
#54534 - failing with #54534 (comment)
#54798 - pending validation on all environments
#55285 - #55285 (comment)
#55443 - failing on Android and iOS app with original issue #55443 (comment)
DB:
#55660
#55661
#55662
#55674
#55675
#55678
#55681
#55693
#55707
Beamanator commentedon Jan 24, 2025
#55707 marked NAB 👍
grgia commentedon Jan 24, 2025
Cannot reproduce #55733 so I closed it
joekaufmanexpensify commentedon Jan 24, 2025
checked off #55387
joekaufmanexpensify commentedon Jan 24, 2025
checked off #55561
1 remaining item
isagoico commentedon Jan 24, 2025
Highlighting this issue as it's failing a Critical TC - #55682. It was intermittent but several testers were ablet to reproduce and some were able to reproduce in Prod. Labeled it as Hourly.
mvtglobally commentedon Jan 27, 2025
Regression is completed
#54278 - failing with #55666. This seems a big one, but its repro in PROD. Let us know if we are ok to check it off.
#54798 - pending validation on IOS
#55095 - Pending validation on Web/Desktop/IOS
#55264 - Pending validation on Android
#55443 - failing on Android and iOS app with original issue #55443 (comment)
#55474 - Pending validation on Web/Desktop/Native Apps
#55494 - Pending validation on mWeb
#55503 - Pending validation on Android
#55592 - Pending validation on Android
#55716 - Checking CP
DB:
#55660
#55661
#55681
#55693
#55715
Beamanator commentedon Jan 27, 2025
#55660 checked off as fixed by #55712
Beamanator commentedon Jan 27, 2025
#55682 was marked nAB
mountiny commentedon Jan 27, 2025
Checked #55443 off
checked #55693 off
mountiny commentedon Jan 27, 2025
Checked #55716 off
amyevans commentedon Jan 27, 2025
Checked off #55780 after CP
yuwenmemon commentedon Jan 27, 2025
Checking off #54798 as it's still on a beta.
yuwenmemon commentedon Jan 27, 2025
Checking off #54278 as per the conversation with @srikarparsi here
mvtglobally commentedon Jan 27, 2025
@yuwenmemon Unchecked PRs
#55494 (comment)
#55474 - still pending validation. It would be great if you can also cross check internally with real PayPal receipts.
#55592 We are unable to access Public room on Android Hybrid app as it leads to mWeb. I believe its ok to check it off. Pls confirm
yuwenmemon commentedon Jan 28, 2025
For #55494 (comment) I won't consider that last part a blocker since it's pretty minor. I'll make sure to comment on the original issue that the author will need to make a follow-up to fix android in order to get paid.
yuwenmemon commentedon Jan 28, 2025
Checking off #55474 as per the convo here: https://expensify.slack.com/archives/C9YU7BX5M/p1738027073070519?thread_ts=1738019554.655479&cid=C9YU7BX5M
yuwenmemon commentedon Jan 28, 2025