Skip to content

[Due for payment 2025-04-08] Tags - "Track billable" is enabled when workspace is created offline and disabled when online #59230

Closed

Description

@mitarachim

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.20-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp #58768
Email or phone of affected tester (no customers): sdjsdjsoidmsod@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Workspace Settings

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go offline.
  3. Create a new workspace.
  4. Go to workspace settings > More features/
  5. Enable Tags.
  6. Go to Tags.
  7. Click Settings.
  8. Note that "Track billable expenses" is enabled by default when workspace is created offline.
  9. Go to workspace chat.
  10. Click + > Create expense > Manual.
  11. Enter amount > Next.
  12. Note that Billable toggle is absent on the confirmation page when "Track billable expenses" is enabled by default in Step 8.
  13. Go to workspace settings > Tags > Settings.
  14. Go online.
  15. Now "Track billable expenses" is disabled.

Expected Result:

In Step 8, "Track billable expenses" should be disabled by default when workspace is created offline.

Actual Result:

In Step 8, "Track billable expenses" is enabled by default when workspace is created offline.
In Step 12, Billable toggle is absent on the confirmation page when "Track billable expenses" is enabled by default in Step 8.
In Step 15, after returning online, "Track billable expenses" is disabled.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6784265_1743088614444.20250327_231037.mp4

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    DeployBlockerCashThis issue or pull request should block deployment
    on Mar 27, 2025
  2. melvin-bot commented on Mar 27, 2025

    @melvin-bot

    Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Mar 27, 2025

    @melvin-bot

    Triggered auto assignment to @NikkiWines (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Mar 27, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Mar 27, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. added
    ReviewingHas a PR in review
    and removed on Mar 27, 2025
  7. 5 remaining items

  8. cristipaval commented on Mar 28, 2025

    @cristipaval
    Contributor

    Agree, thanks for managing it! 🙏

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Apr 1, 2025
  10. changed the title [-]Tags - "Track billable" is enabled when workspace is created offline and disabled when online[/-] [+][Due for payment 2025-04-08] Tags - "Track billable" is enabled when workspace is created offline and disabled when online[/+] on Apr 1, 2025
  11. melvin-bot commented on Apr 1, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Apr 1, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.21-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-04-08. 🎊

  13. melvin-bot commented on Apr 1, 2025

    @melvin-bot

    @NikkiWines @lschurr @NikkiWines The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. lschurr commented on Apr 7, 2025

    @lschurr
    Contributor

    Hey @NikkiWines - It looks like the PR was raised by @FitseTLT and reviewed by @dominictb but they aren't assigned to this GH. Is there another GH or should they be assigned here for payment?

  15. dominictb commented on Apr 8, 2025

    @dominictb
    Contributor

    @lschurr This is a follow up of #58587. No need for payment.

  16. melvin-bot commented on Apr 8, 2025

    @melvin-bot

    Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions