Skip to content

Admins room - 'Settings > Subscription' deeplink redirects to mWeb #59486

Closed

Description

@vincdargento

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.22-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): lusiannn@tstsg.com
Issue reported by: Applause Internal Team
Device used: Samsung A15, Android 14 | iPhone SE 3rd generation (2022), iOS 18.4
App Component: Other

Action Performed:

  1. Open Hybrid app
  2. Sign up with an account like: chooseYourName@tstsg.com
  3. Tap on 'Manage my team's expenses' > '1-10 employees' > 'QuickBooks Desktop' > 'Continue'
  4. Tap on #admins room chat
  5. Tap on 'Settings > Subscription' deeplink

Expected Result:

The user is redirected to the expected feature within the app.

Actual Result:

The user is redirected to mWeb.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 1, 2025
  2. melvin-bot commented on Apr 1, 2025

    @melvin-bot

    Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot commented on Apr 1, 2025

    @melvin-bot

    Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot commented on Apr 1, 2025

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Apr 1, 2025

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. vincdargento commented on Apr 1, 2025

    @vincdargento
    Author

    @zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

  7. tgolen commented on Apr 1, 2025

    @tgolen
    Contributor

    I don't think this is a deploy blocker. From what I can tell, that message has been the same for months.

  8. removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 1, 2025
  9. 1 remaining item

  10. MonilBhavsar commented on Apr 1, 2025

    @MonilBhavsar
    Contributor

    Yes, this link is unchanged since while. I wonder if it is indeed a blocker and we changed navigation/deep link functionality at the client side
    Nothing seems suspicious from the deployment difference 🤔

  11. melvin-bot commented on Apr 1, 2025

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  12. zanyrenney commented on Apr 2, 2025

    @zanyrenney
    Contributor

    Catching up here but do we want to keep this hourly as a deploy blocker or can we make daily and handle via the existing BZ process?

  13. zanyrenney commented on Apr 2, 2025

    @zanyrenney
    Contributor

    Tim seems to say its not a deploy blocker but @MonilBhavsar thought it could be?

  14. tgolen commented on Apr 2, 2025

    @tgolen
    Contributor

    Since the link in the message is unchanged, it must be a frontend issue as @MonilBhavsar suggests. I'm going to take a closer look at it this morning and use git bisect to locate the source of the problem. 🤞

  15. tgolen commented on Apr 2, 2025

    @tgolen
    Contributor

    OK, before trying to git bisect, I just wanted to reproduce it first. I performed the reproduction steps locally, and the link in the message points to https://new.expensify.com/settings/subscription. When I click on it, a new tab is opened which goes to the production site.

    This is the source of the problem and why on a mobile client, the link is opened in mWeb.

    The link needs to point to whatever environment that the user is in. It looks like we do this with other links, such as the onboarding tasks:

    Image

    Which are constructed on the frontend here and were added in this PR

    The #admins link in the Concierge message is also correct:

    Image

    This message comes from Auth here and you can see the logic that it uses there will use the correct URL.

    Conclusion

    This is a backend bug that has existed for quite some time. The solution is to update the message in Auth to use the correct base URL, just like the #admins link in the concierge message.

    Therefore, it's not a deploy blocker.

    I'll submit a PR for this today.

  16. youssef-lr commented on Apr 2, 2025

    @youssef-lr
    Contributor

    I suppose it's the same root cause for this issue as well #59489

  17. tgolen commented on Apr 2, 2025

    @tgolen
    Contributor

    Hm, I don't think so. Isn't that the link I showed in my last screenshot and it has the proper URL? I suppose maybe the issue is that it doesn't point to staging when the user is on staging. Which is perhaps a bigger issue since Auth has no knowledge of staging.

  18. tgolen commented on Apr 7, 2025

    @tgolen
    Contributor

    Daily Update

    • This is being fixed by this Auth PR

    What's Next

    ETA

    • Merged today, Apr. 7
  19. tgolen commented on Apr 8, 2025

    @tgolen
    Contributor

    Daily Update

    Next Steps

    • @tgolen Wait for it to deploy to production and then do a quick QA on it, then close this out

    ETA

    • Today, Apr. 8
  20. tgolen commented on Apr 8, 2025

    @tgolen
    Contributor

    Daily Update

    • The Auth PR was deployed to production
    • I tested it out with a new account
    • The behavior is fixed, so I am closing this out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringReviewingHas a PR in review

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions