You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Version Number: 9.1.22-1 Reproducible in staging?: Yes Reproducible in production?: No If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):lusiannn@tstsg.com Issue reported by: Applause Internal Team Device used: Samsung A15, Android 14 | iPhone SE 3rd generation (2022), iOS 18.4 App Component: Other
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
Yes, this link is unchanged since while. I wonder if it is indeed a blocker and we changed navigation/deep link functionality at the client side
Nothing seems suspicious from the deployment difference 🤔
Since the link in the message is unchanged, it must be a frontend issue as @MonilBhavsar suggests. I'm going to take a closer look at it this morning and use git bisect to locate the source of the problem. 🤞
OK, before trying to git bisect, I just wanted to reproduce it first. I performed the reproduction steps locally, and the link in the message points to https://new.expensify.com/settings/subscription. When I click on it, a new tab is opened which goes to the production site.
This is the source of the problem and why on a mobile client, the link is opened in mWeb.
The link needs to point to whatever environment that the user is in. It looks like we do this with other links, such as the onboarding tasks:
Which are constructed on the frontend here and were added in this PR
The #admins link in the Concierge message is also correct:
This message comes from Auth here and you can see the logic that it uses there will use the correct URL.
Conclusion
This is a backend bug that has existed for quite some time. The solution is to update the message in Auth to use the correct base URL, just like the #admins link in the concierge message.
Hm, I don't think so. Isn't that the link I showed in my last screenshot and it has the proper URL? I suppose maybe the issue is that it doesn't point to staging when the user is on staging. Which is perhaps a bigger issue since Auth has no knowledge of staging.
Activity
melvin-bot commentedon Apr 1, 2025
Triggered auto assignment to @tgolen (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Apr 1, 2025
Triggered auto assignment to @zanyrenney (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Apr 1, 2025
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Apr 1, 2025
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
vincdargento commentedon Apr 1, 2025
@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.
tgolen commentedon Apr 1, 2025
I don't think this is a deploy blocker. From what I can tell, that message has been the same for months.
1 remaining item
MonilBhavsar commentedon Apr 1, 2025
Yes, this link is unchanged since while. I wonder if it is indeed a blocker and we changed navigation/deep link functionality at the client side
Nothing seems suspicious from the deployment difference 🤔
melvin-bot commentedon Apr 1, 2025
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
zanyrenney commentedon Apr 2, 2025
Catching up here but do we want to keep this hourly as a deploy blocker or can we make daily and handle via the existing BZ process?
zanyrenney commentedon Apr 2, 2025
Tim seems to say its not a deploy blocker but @MonilBhavsar thought it could be?
tgolen commentedon Apr 2, 2025
Since the link in the message is unchanged, it must be a frontend issue as @MonilBhavsar suggests. I'm going to take a closer look at it this morning and use
git bisectto locate the source of the problem. 🤞tgolen commentedon Apr 2, 2025
OK, before trying to
git bisect, I just wanted to reproduce it first. I performed the reproduction steps locally, and the link in the message points tohttps://new.expensify.com/settings/subscription. When I click on it, a new tab is opened which goes to the production site.This is the source of the problem and why on a mobile client, the link is opened in mWeb.
The link needs to point to whatever environment that the user is in. It looks like we do this with other links, such as the onboarding tasks:
Which are constructed on the frontend here and were added in this PR
The #admins link in the Concierge message is also correct:
This message comes from Auth here and you can see the logic that it uses there will use the correct URL.
Conclusion
This is a backend bug that has existed for quite some time. The solution is to update the message in Auth to use the correct base URL, just like the #admins link in the concierge message.
Therefore, it's not a deploy blocker.
I'll submit a PR for this today.
youssef-lr commentedon Apr 2, 2025
I suppose it's the same root cause for this issue as well #59489
tgolen commentedon Apr 2, 2025
Hm, I don't think so. Isn't that the link I showed in my last screenshot and it has the proper URL? I suppose maybe the issue is that it doesn't point to
stagingwhen the user is on staging. Which is perhaps a bigger issue since Auth has no knowledge of staging.tgolen commentedon Apr 7, 2025
Daily Update
What's Next
ETA
tgolen commentedon Apr 8, 2025
Daily Update
Next Steps
ETA
tgolen commentedon Apr 8, 2025
Daily Update