Repository navigation
Add call-to-action links to onboarding task titles - #58895
techievivek merged 2 commits into
Conversation
Reviewer Checklist
Screenshots/Videos |
|
@Shahidullah-Muffakir i think we need to update this line as well: Line 150 in c9c0d82 |
|
@getusha I’ve updated it. Thanks |
|
Yes just realized that @Shahidullah-Muffakir :) |
| workspaceMembersLink: `${environmentURL}/${ROUTES.WORKSPACE_MEMBERS.getRoute(onboardingPolicyID)}`, | ||
| workspaceMoreFeaturesLink: `${environmentURL}/${ROUTES.WORKSPACE_MORE_FEATURES.getRoute(onboardingPolicyID)}`, | ||
| navatticURL: getNavatticURL(environment, engagementChoice), | ||
| workspaceAccountingLink: `${environmentURL}/${ROUTES.POLICY_ACCOUNTING.getRoute(onboardingPolicyID)}`, |
There was a problem hiding this comment.
aren't we missing adminsRoomLink?
There was a problem hiding this comment.
It was not used anywhere
There was a problem hiding this comment.
Looks like we don't need it since it's a room and will be highlighted anyway. thanks
There was a problem hiding this comment.
Right, as now the the onboarding tasks are being created in the adminsRoom itself, hence no need to add its link.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/techievivek in version: 9.1.18-0 🚀
|
|
@Shahidullah-Muffakir This PR is failing because of issue #59060
Bug6781446_1742905126668.SkreenRecordin.mp4 |
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.1.18-4 🚀
|










Explanation of Change
Fixed Issues
$ #58772
PROPOSAL: #58772 (comment)
Tests
Offline tests
Signup requires an internet connection.
QA Steps
Same as Tests steps.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
I am facing an Android build issue, and these changes are not Android-specific.
Android: mWeb Chrome
android.20web-6.mp4
iOS: Native
ios.20native-6.mp4
iOS: mWeb Safari
ios.web.mov
MacOS: Chrome / Safari
macos.20web-5.mp4
MacOS: Desktop
macos.20desktop-4.mp4